From: Mike Snitzer Subject: Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required Date: Fri, 27 Jul 2018 15:33:33 -0400 Message-ID: <20180727193333.GA23266@redhat.com> References: <20180725162849.8320-1-yehs2007@zoho.com> <20180725162849.8320-6-yehs2007@zoho.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180725162849.8320-6-yehs2007-ytc+IHgoah0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Huaisheng Ye Cc: jack-AlSwsSmVLrQ@public.gmane.org, heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, bart.vanassche-Sjgp3cTcYWE@public.gmane.org, chengnt-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org, colyli-l3A5Bk7waGM@public.gmane.org, schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: dm-devel.ids On Wed, Jul 25 2018 at 12:28pm -0400, Huaisheng Ye wrote: > From: Huaisheng Ye > > Function persistent_memory_claim doesn't need to get local pointer > dummy_addr from direct_access. Using NULL instead of having to pass > in a useless local pointer that caller then just throw away. > > Suggested-by: Ross Zwisler > Signed-off-by: Huaisheng Ye Acked-by: Mike Snitzer