From: Imre Deak Subject: Re: [PATCH 1/3] drm/i915/cnl+: Reload CSR firmware when coming back from low power states Date: Sat, 28 Jul 2018 11:40:42 +0300 Message-ID: <20180728084042.GA9131@ideak-desk.fi.intel.com> References: <20180727233626.9216-1-jose.souza@intel.com> <20180728051940.GB14046@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E468A88635 for ; Sat, 28 Jul 2018 08:41:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180728051940.GB14046@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgMTA6MTk6NDJQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIEZyaSwgSnVsIDI3LCAyMDE4IGF0IDA0OjM2OjI0UE0gLTA3MDAsIEpvc8OpIFJv YmVydG8gZGUgU291emEgd3JvdGU6Cj4gPiBXaGVuIHJldHVybmluZyBmcm9tIGxvdyBwb3dlciBz dGF0ZXMgdGhlIENTUiBmaXJtd2FyZSB3YXMgbm90IGJlaW5nCj4gPiBsb2FkZWQgYWdhaW4gaW4g Q05MIGFuZCBJQ0wuCgpXaGljaCBwb3dlciBzdGF0ZXMgYXJlIHlvdSByZWZlcnJpbmcgdG8/IFdl IHNob3VsZCBhbHJlYWR5IHJlc3RvcmUgdGhlCmZpcm13YXJlIGZyb20gYWxsIHJlbGV2YW50IHN0 YXRlcyBpbiBpOTE1X2RybV9yZXN1bWVfZWFybHkoKS4gVGhlIHBhdGNoCnRvIGxvYWQgdGhlIGZp cm13YXJlIG9uIElDTCBpcyBub3QgeWV0IG1lcmdlZCB0byBkcm0tdGlwLgoKPiA+IEFsc28gdGFr aW5nIHRoZSBvcHBvcnR1bml0eSB0byBzaGFyZSB0aGUgbG9hZCBjYWxsIGZvciBnZW4gPj0gOSwK PiA+IGluc3RlYWQgb2YgY2FsbGluZyBpdCBmcm9tIGVhY2ggZGlzcGxheV9jb3JlX2luaXQoKSBm dW5jdGlvbi4KPiA+IAo+ID4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwu Y29tPgo+ID4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVsLmNvbT4K PiAKPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IAo+ID4gU2lnbmVkLW9m Zi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gPiAt LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgICAgfCAgOSArKysr KystLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAxMyAr KysrLS0tLS0tLS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiBpbmRleCAxOGE0 NWU3YTNkN2MuLmE0MmYwZGZlMTlkYSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMK PiA+IEBAIC0yNjk5LDkgKzI2OTksMTIgQEAgc3RhdGljIGludCBpbnRlbF9ydW50aW1lX3Jlc3Vt ZShzdHJ1Y3QgZGV2aWNlICprZGV2KQo+ID4gIAlpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikpIHsK PiA+ICAJCWJ4dF9kaXNhYmxlX2RjOShkZXZfcHJpdik7Cj4gPiAgCQlieHRfZGlzcGxheV9jb3Jl X2luaXQoZGV2X3ByaXYsIHRydWUpOwo+ID4gLQkJaWYgKGRldl9wcml2LT5jc3IuZG1jX3BheWxv YWQgJiYKPiA+IC0JCSAgICAoZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2sgJiBEQ19TVEFU RV9FTl9VUFRPX0RDNSkpCj4gPiAtCQkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiA+ICsJ CWlmIChkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2FkKSB7Cj4gPiArCQkJaW50ZWxfY3NyX2xvYWRf cHJvZ3JhbShkZXZfcHJpdik7Cj4gPiArCQkJaWYgKGRldl9wcml2LT5jc3IuYWxsb3dlZF9kY19t YXNrICYKPiA+ICsJCQkgICAgRENfU1RBVEVfRU5fVVBUT19EQzUpCj4gPiArCQkJCWdlbjlfZW5h YmxlX2RjNShkZXZfcHJpdik7Cj4gPiArCQl9Cj4gPiAgCX0gZWxzZSBpZiAoSVNfSEFTV0VMTChk ZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+ID4gIAkJaHN3X2Rpc2FibGVf cGM4KGRldl9wcml2KTsKPiA+ICAJfSBlbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8 fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkgewo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3J1bnRpbWVfcG0uYwo+ID4gaW5kZXggY2Y4OTE0MWIyMjgxLi44ZmRjZmZlMDIzZmUgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gQEAgLTMwNzUs OSArMzA3NSw2IEBAIHN0YXRpYyB2b2lkIHNrbF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCXNrbF9pbml0X2NkY2xrKGRldl9wcml2KTsK PiA+ICAKPiA+ICAJZ2VuOV9kYnVmX2VuYWJsZShkZXZfcHJpdik7Cj4gPiAtCj4gPiAtCWlmIChy ZXN1bWUgJiYgZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiA+IC0JCWludGVsX2Nzcl9sb2Fk X3Byb2dyYW0oZGV2X3ByaXYpOwo+IAo+IGFuZCByZXN1bWUgYmVjb21lcyB1bnNlZCwgc28gcGxl YXNlIGtpbGwgaXQuCj4gCj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIHNrbF9kaXNwbGF5 X2NvcmVfdW5pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+IEBAIC0z MTQwLDkgKzMxMzcsNiBAQCB2b2lkIGJ4dF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCWJ4dF9pbml0X2NkY2xrKGRldl9wcml2KTsKPiA+ ICAKPiA+ICAJZ2VuOV9kYnVmX2VuYWJsZShkZXZfcHJpdik7Cj4gPiAtCj4gPiAtCWlmIChyZXN1 bWUgJiYgZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiA+IC0JCWludGVsX2Nzcl9sb2FkX3By b2dyYW0oZGV2X3ByaXYpOwo+IAo+IHNhbWUKPiAKPiA+ICB9Cj4gPiAgCj4gPiAgdm9pZCBieHRf ZGlzcGxheV9jb3JlX3VuaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g PiBAQCAtMzI4Myw5ICszMjc3LDYgQEAgc3RhdGljIHZvaWQgY25sX2Rpc3BsYXlfY29yZV9pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9vbCByZXN1bWUKPiA+ICAKPiA+ ICAJLyogNi4gRW5hYmxlIERCVUYgKi8KPiA+ICAJZ2VuOV9kYnVmX2VuYWJsZShkZXZfcHJpdik7 Cj4gPiAtCj4gPiAtCWlmIChyZXN1bWUgJiYgZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiA+ IC0JCWludGVsX2Nzcl9sb2FkX3Byb2dyYW0oZGV2X3ByaXYpOwo+IAo+IHNhbWUKPiAKPiA+ICB9 Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgY25sX2Rpc3BsYXlfY29yZV91bmluaXQoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gQEAgLTM1NjEsNiArMzU1MiwxMCBAQCB2b2lk IGludGVsX3Bvd2VyX2RvbWFpbnNfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGJvb2wgcmVzdW1lKQo+ID4gIAo+ID4gIAkvKiBGb3Igbm93LCB3ZSBuZWVkIHRoZSBw b3dlciB3ZWxsIHRvIGJlIGFsd2F5cyBlbmFibGVkLiAqLwo+ID4gIAlpbnRlbF9kaXNwbGF5X3Nl dF9pbml0X3Bvd2VyKGRldl9wcml2LCB0cnVlKTsKPiA+ICsKPiA+ICsJaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gOSAmJiByZXN1bWUgJiYgZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiA+ ICsJCWludGVsX2Nzcl9sb2FkX3Byb2dyYW0oZGV2X3ByaXYpOwo+ID4gKwo+ID4gIAkvKiBEaXNh YmxlIHBvd2VyIHN1cHBvcnQgaWYgdGhlIHVzZXIgYXNrZWQgc28uICovCj4gPiAgCWlmICghaTkx NV9tb2RwYXJhbXMuZGlzYWJsZV9wb3dlcl93ZWxsKQo+ID4gIAkJaW50ZWxfZGlzcGxheV9wb3dl cl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9JTklUKTsKPiA+IC0tIAo+ID4gMi4xOC4wCj4g PiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK