From: Huang Rui Subject: Re: [PATCH] drm/amdgpu: add proper error handling to amdgpu_bo_list_get Date: Sun, 29 Jul 2018 19:58:40 +0800 Message-ID: <20180729115838.GA20939@hr-amur2> References: <20180727133902.1902-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180727133902.1902-1-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgMDM6Mzk6MDFQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBPdGhlcndpc2Ugd2Ugc2lsZW50bHkgZG9uJ3QgdXNlIGEgQk8gbGlzdCB3aGVu IHRoZSBoYW5kbGUgaXMgaW52YWxpZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2 bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogSHVhbmcgUnVpIDxy YXkuaHVhbmdAYW1kLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdS5oICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9ib19saXN0LmMgfCAyOCArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jICAgICAgfCAxMSArKysrKysrKy0tLQo+ ICAzIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaCBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gaW5kZXggMTNhYWExMThhY2E0Li40Y2Qy MGU3MjJkNzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IEBAIC03MTMs OCArNzEzLDggQEAgc3RydWN0IGFtZGdwdV9ib19saXN0IHsKPiAgCXN0cnVjdCBhbWRncHVfYm9f bGlzdF9lbnRyeSAqYXJyYXk7Cj4gIH07Cj4gIAo+IC1zdHJ1Y3QgYW1kZ3B1X2JvX2xpc3QgKgo+ IC1hbWRncHVfYm9fbGlzdF9nZXQoc3RydWN0IGFtZGdwdV9mcHJpdiAqZnByaXYsIGludCBpZCk7 Cj4gK2ludCBhbWRncHVfYm9fbGlzdF9nZXQoc3RydWN0IGFtZGdwdV9mcHJpdiAqZnByaXYsIGlu dCBpZCwKPiArCQkgICAgICAgc3RydWN0IGFtZGdwdV9ib19saXN0ICoqcmVzdWx0KTsKPiAgdm9p ZCBhbWRncHVfYm9fbGlzdF9nZXRfbGlzdChzdHJ1Y3QgYW1kZ3B1X2JvX2xpc3QgKmxpc3QsCj4g IAkJCSAgICAgc3RydWN0IGxpc3RfaGVhZCAqdmFsaWRhdGVkKTsKPiAgdm9pZCBhbWRncHVfYm9f bGlzdF9wdXQoc3RydWN0IGFtZGdwdV9ib19saXN0ICpsaXN0KTsKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JvX2xpc3QuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9ib19saXN0LmMKPiBpbmRleCA3Njc5YzA2OGM4OWEuLjk0NDg2 OGU0NzExOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf Ym9fbGlzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JvX2xp c3QuYwo+IEBAIC0xODAsMjcgKzE4MCwyMCBAQCBzdGF0aWMgaW50IGFtZGdwdV9ib19saXN0X3Nl dChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCXJldHVybiByOwo+ICB9Cj4gIAo+IC1z dHJ1Y3QgYW1kZ3B1X2JvX2xpc3QgKgo+IC1hbWRncHVfYm9fbGlzdF9nZXQoc3RydWN0IGFtZGdw dV9mcHJpdiAqZnByaXYsIGludCBpZCkKPiAraW50IGFtZGdwdV9ib19saXN0X2dldChzdHJ1Y3Qg YW1kZ3B1X2Zwcml2ICpmcHJpdiwgaW50IGlkLAo+ICsJCSAgICAgICBzdHJ1Y3QgYW1kZ3B1X2Jv X2xpc3QgKipyZXN1bHQpCj4gIHsKPiAtCXN0cnVjdCBhbWRncHVfYm9fbGlzdCAqcmVzdWx0Owo+ IC0KPiAgCXJjdV9yZWFkX2xvY2soKTsKPiAtCXJlc3VsdCA9IGlkcl9maW5kKCZmcHJpdi0+Ym9f bGlzdF9oYW5kbGVzLCBpZCk7Cj4gKwkqcmVzdWx0ID0gaWRyX2ZpbmQoJmZwcml2LT5ib19saXN0 X2hhbmRsZXMsIGlkKTsKPiAgCj4gLQlpZiAocmVzdWx0KSB7Cj4gLQkJaWYgKGtyZWZfZ2V0X3Vu bGVzc196ZXJvKCZyZXN1bHQtPnJlZmNvdW50KSkgewo+IC0JCQlyY3VfcmVhZF91bmxvY2soKTsK PiAtCQkJbXV0ZXhfbG9jaygmcmVzdWx0LT5sb2NrKTsKPiAtCQl9IGVsc2Ugewo+IC0JCQlyY3Vf cmVhZF91bmxvY2soKTsKPiAtCQkJcmVzdWx0ID0gTlVMTDsKPiAtCQl9Cj4gLQl9IGVsc2Ugewo+ ICsJaWYgKCpyZXN1bHQgJiYga3JlZl9nZXRfdW5sZXNzX3plcm8oJigqcmVzdWx0KS0+cmVmY291 bnQpKSB7Cj4gIAkJcmN1X3JlYWRfdW5sb2NrKCk7Cj4gKwkJbXV0ZXhfbG9jaygmKCpyZXN1bHQp LT5sb2NrKTsKPiArCQlyZXR1cm4gMDsKPiAgCX0KPiAgCj4gLQlyZXR1cm4gcmVzdWx0Owo+ICsJ cmN1X3JlYWRfdW5sb2NrKCk7Cj4gKwlyZXR1cm4gLUVOT0VOVDsKPiAgfQo+ICAKPiAgdm9pZCBh bWRncHVfYm9fbGlzdF9nZXRfbGlzdChzdHJ1Y3QgYW1kZ3B1X2JvX2xpc3QgKmxpc3QsCj4gQEAg LTMzNSw5ICszMjgsOCBAQCBpbnQgYW1kZ3B1X2JvX2xpc3RfaW9jdGwoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQlicmVhazsKPiAgCj4gIAljYXNlIEFNREdQVV9CT19M SVNUX09QX1VQREFURToKPiAtCQlyID0gLUVOT0VOVDsKPiAtCQlsaXN0ID0gYW1kZ3B1X2JvX2xp c3RfZ2V0KGZwcml2LCBoYW5kbGUpOwo+IC0JCWlmICghbGlzdCkKPiArCQlyID0gYW1kZ3B1X2Jv X2xpc3RfZ2V0KGZwcml2LCBoYW5kbGUsICZsaXN0KTsKPiArCQlpZiAocikKPiAgCQkJZ290byBl cnJvcl9mcmVlOwo+ICAKPiAgCQlyID0gYW1kZ3B1X2JvX2xpc3Rfc2V0KGFkZXYsIGZpbHAsIGxp c3QsIGluZm8sCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiBpbmRleCA1 MzNiMmU3NjU2YzAuLjhhNDljM2I5N2JkNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9jcy5jCj4gQEAgLTU3MiwxMSArNTcyLDE2IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2Nz X3BhcnNlcl9ib3Moc3RydWN0IGFtZGdwdV9jc19wYXJzZXIgKnAsCj4gIAlJTklUX0xJU1RfSEVB RCgmcC0+dmFsaWRhdGVkKTsKPiAgCj4gIAkvKiBwLT5ib19saXN0IGNvdWxkIGFscmVhZHkgYmUg YXNzaWduZWQgaWYgQU1ER1BVX0NIVU5LX0lEX0JPX0hBTkRMRVMgaXMgcHJlc2VudCAqLwo+IC0J aWYgKCFwLT5ib19saXN0KQo+IC0JCXAtPmJvX2xpc3QgPSBhbWRncHVfYm9fbGlzdF9nZXQoZnBy aXYsIGNzLT5pbi5ib19saXN0X2hhbmRsZSk7Cj4gLQllbHNlCj4gKwlpZiAocC0+Ym9fbGlzdCkg ewo+ICAJCW11dGV4X2xvY2soJnAtPmJvX2xpc3QtPmxvY2spOwo+ICAKPiArCX0gZWxzZSBpZiAo Y3MtPmluLmJvX2xpc3RfaGFuZGxlKSB7Cj4gKwkJciA9IGFtZGdwdV9ib19saXN0X2dldChmcHJp diwgY3MtPmluLmJvX2xpc3RfaGFuZGxlLAo+ICsJCQkJICAgICAgICZwLT5ib19saXN0KTsKPiAr CQlpZiAocikKPiArCQkJcmV0dXJuIHI7Cj4gKwl9Cj4gKwo+ICAJaWYgKHAtPmJvX2xpc3QpIHsK PiAgCQlhbWRncHVfYm9fbGlzdF9nZXRfbGlzdChwLT5ib19saXN0LCAmcC0+dmFsaWRhdGVkKTsK PiAgCQlpZiAocC0+Ym9fbGlzdC0+Zmlyc3RfdXNlcnB0ciAhPSBwLT5ib19saXN0LT5udW1fZW50 cmllcykKPiAtLSAKPiAyLjE0LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==