From: Imre Deak Subject: Re: [PATCH 1/3] drm/i915/cnl+: Reload CSR firmware when coming back from low power states Date: Mon, 30 Jul 2018 21:44:19 +0300 Message-ID: <20180730184419.GA28892@ideak-desk.fi.intel.com> References: <20180727233626.9216-1-jose.souza@intel.com> <20180728051940.GB14046@intel.com> <20180728084042.GA9131@ideak-desk.fi.intel.com> <1d7a15af6378319a100cf1d558788c22505b2f4f.camel@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D17B6E19E for ; Mon, 30 Jul 2018 18:45:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1d7a15af6378319a100cf1d558788c22505b2f4f.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMzAsIDIwMTggYXQgMDg6MjM6MDhQTSArMDMwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gT24gU2F0LCAyMDE4LTA3LTI4IGF0IDExOjQwICswMzAwLCBJbXJlIERlYWsgd3JvdGU6 Cj4gPiBPbiBGcmksIEp1bCAyNywgMjAxOCBhdCAxMDoxOTo0MlBNIC0wNzAwLCBSb2RyaWdvIFZp dmkgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgSnVsIDI3LCAyMDE4IGF0IDA0OjM2OjI0UE0gLTA3MDAs IEpvc8OpIFJvYmVydG8gZGUgU291emEKPiA+ID4gd3JvdGU6Cj4gPiA+ID4gV2hlbiByZXR1cm5p bmcgZnJvbSBsb3cgcG93ZXIgc3RhdGVzIHRoZSBDU1IgZmlybXdhcmUgd2FzIG5vdAo+ID4gPiA+ IGJlaW5nCj4gPiA+ID4gbG9hZGVkIGFnYWluIGluIENOTCBhbmQgSUNMLgo+ID4gCj4gPiBXaGlj aCBwb3dlciBzdGF0ZXMgYXJlIHlvdSByZWZlcnJpbmcgdG8/IFdlIHNob3VsZCBhbHJlYWR5IHJl c3RvcmUKPiA+IHRoZQo+ID4gZmlybXdhcmUgZnJvbSBhbGwgcmVsZXZhbnQgc3RhdGVzIGluIGk5 MTVfZHJtX3Jlc3VtZV9lYXJseSgpLiBUaGUKPiA+IHBhdGNoCj4gPiB0byBsb2FkIHRoZSBmaXJt d2FyZSBvbiBJQ0wgaXMgbm90IHlldCBtZXJnZWQgdG8gZHJtLXRpcC4KPiAKPiBFeGFjdGx5IHRo aXMgb25lLCBpOTE1X2RybV9yZXN1bWVfZWFybHkoKSBjYWxscwo+IGludGVsX3Bvd2VyX2RvbWFp bnNfaW5pdF9odygpLgo+IFllcyBpdCBpcyBzdGlsbCBub3QgbG9hZGluZyBiZWNhc3VlIHRoZSBm aXJtd2FyZSBuYW1lIGlzIG1pc3NpbmcgZm9yCj4gSUNMIGJ1dCBldmVyeXRoaW5nIGVsc2UgaXMg dGhlcmUuCgpJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMgZml4ZXMgdGhpbmdzLiBD TkwgYWxyZWFkeSByZWxvYWRzIHRoZQpmaXJtd2FyZSB2aWEgaTkxNV9kcm1fcmVzdW1lX2Vhcmx5 KCkgLT4gY25sX2Rpc3BsYXlfY29yZV9pbml0KCkuIE9uCklDTCB0aGUgc2FtZSB3aWxsIGhhcHBl biBvbmNlIHN1cHBvcnQgZm9yIGxvYWRpbmcgdGhlIGZpcm13YXJlIGlzIGFkZGVkLgpUaGF0IHNh bWUgcGF0Y2ggc2hvdWxkIGFsc28gYWRkIHRoZSBjYWxsIHRvIGludGVsX2Nzcl9sb2FkX3Byb2dy YW0oKSBmcm9tCmljbF9kaXNwbGF5X2NvcmVfaW5pdCgpLgoKSSB3b3VsZCBwcmVmZXIgdG8ga2Vl cCB0aGUgY2FsbCB0byBpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKCkgaW4KKl9kaXNwbGF5X2NvcmVf aW5pdCgpIGZ1bmN0aW9ucyB0byBrZWVwIHRoZSBydW50aW1lIGFuZCBzeXN0ZW0gc3VzcGVuZApw YXRocyBzaW1pbGFyLgoKPiAKPiA+IAo+ID4gPiA+IEFsc28gdGFraW5nIHRoZSBvcHBvcnR1bml0 eSB0byBzaGFyZSB0aGUgbG9hZCBjYWxsIGZvciBnZW4gPj0gOSwKPiA+ID4gPiBpbnN0ZWFkIG9m IGNhbGxpbmcgaXQgZnJvbSBlYWNoIGRpc3BsYXlfY29yZV9pbml0KCkgZnVuY3Rpb24uCj4gPiA+ ID4gCj4gPiA+ID4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+ ID4gPiA+IENjOiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+Cj4g PiA+IAo+ID4gPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gPiAKPiA+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGlu dGVsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYyAgICAgICAgIHwgIDkgKysrKysrLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3J1bnRpbWVfcG0uYyB8IDEzICsrKystLS0tLS0tLS0KPiA+ID4gPiAgMiBmaWxlcyBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gPiA+IGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gPiA+IGluZGV4IDE4YTQ1ZTdhM2Q3 Yy4uYTQyZjBkZmUxOWRhIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j Cj4gPiA+ID4gQEAgLTI2OTksOSArMjY5OSwxMiBAQCBzdGF0aWMgaW50IGludGVsX3J1bnRpbWVf cmVzdW1lKHN0cnVjdAo+ID4gPiA+IGRldmljZSAqa2RldikKPiA+ID4gPiAgCWlmIChJU19HRU45 X0xQKGRldl9wcml2KSkgewo+ID4gPiA+ICAJCWJ4dF9kaXNhYmxlX2RjOShkZXZfcHJpdik7Cj4g PiA+ID4gIAkJYnh0X2Rpc3BsYXlfY29yZV9pbml0KGRldl9wcml2LCB0cnVlKTsKPiA+ID4gPiAt CQlpZiAoZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCAmJgo+ID4gPiA+IC0JCSAgICAoZGV2X3By aXYtPmNzci5hbGxvd2VkX2RjX21hc2sgJgo+ID4gPiA+IERDX1NUQVRFX0VOX1VQVE9fREM1KSkK PiA+ID4gPiAtCQkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiA+ID4gPiArCQlpZiAoZGV2 X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkgewo+ID4gPiA+ICsJCQlpbnRlbF9jc3JfbG9hZF9wcm9n cmFtKGRldl9wcml2KTsKPiA+ID4gPiArCQkJaWYgKGRldl9wcml2LT5jc3IuYWxsb3dlZF9kY19t YXNrICYKPiA+ID4gPiArCQkJICAgIERDX1NUQVRFX0VOX1VQVE9fREM1KQo+ID4gPiA+ICsJCQkJ Z2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiA+ID4gPiArCQl9Cj4gPiA+ID4gIAl9IGVsc2Ug aWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiA+ ID4gPiAgCQloc3dfZGlzYWJsZV9wYzgoZGV2X3ByaXYpOwo+ID4gPiA+ICAJfSBlbHNlIGlmIChJ U19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+ID4g PiB7Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRp bWVfcG0uYwo+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5j Cj4gPiA+ID4gaW5kZXggY2Y4OTE0MWIyMjgxLi44ZmRjZmZlMDIzZmUgMTAwNjQ0Cj4gPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gPiA+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gPiA+ID4gQEAgLTMw NzUsOSArMzA3NSw2IEBAIHN0YXRpYyB2b2lkIHNrbF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QK PiA+ID4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gPiAgCXNrbF9pbml0X2Nk Y2xrKGRldl9wcml2KTsKPiA+ID4gPiAgCj4gPiA+ID4gIAlnZW45X2RidWZfZW5hYmxlKGRldl9w cml2KTsKPiA+ID4gPiAtCj4gPiA+ID4gLQlpZiAocmVzdW1lICYmIGRldl9wcml2LT5jc3IuZG1j X3BheWxvYWQpCj4gPiA+ID4gLQkJaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShkZXZfcHJpdik7Cj4g PiA+IAo+ID4gPiBhbmQgcmVzdW1lIGJlY29tZXMgdW5zZWQsIHNvIHBsZWFzZSBraWxsIGl0Lgo+ ID4gPiAKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiAgc3RhdGljIHZvaWQgc2tsX2Rpc3Bs YXlfY29yZV91bmluaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ID4gPiAqZGV2X3ByaXYp Cj4gPiA+ID4gQEAgLTMxNDAsOSArMzEzNyw2IEBAIHZvaWQgYnh0X2Rpc3BsYXlfY29yZV9pbml0 KHN0cnVjdAo+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiA+ICAJYnh0 X2luaXRfY2RjbGsoZGV2X3ByaXYpOwo+ID4gPiA+ICAKPiA+ID4gPiAgCWdlbjlfZGJ1Zl9lbmFi bGUoZGV2X3ByaXYpOwo+ID4gPiA+IC0KPiA+ID4gPiAtCWlmIChyZXN1bWUgJiYgZGV2X3ByaXYt PmNzci5kbWNfcGF5bG9hZCkKPiA+ID4gPiAtCQlpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldl9w cml2KTsKPiA+ID4gCj4gPiA+IHNhbWUKPiA+ID4gCj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ ID4gIHZvaWQgYnh0X2Rpc3BsYXlfY29yZV91bmluaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ID4gPiA+IEBAIC0zMjgzLDkgKzMyNzcsNiBAQCBzdGF0aWMgdm9pZCBjbmxf ZGlzcGxheV9jb3JlX2luaXQoc3RydWN0Cj4gPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsIGJvb2wgcmVzdW1lCj4gPiA+ID4gIAo+ID4gPiA+ICAJLyogNi4gRW5hYmxlIERCVUYgKi8K PiA+ID4gPiAgCWdlbjlfZGJ1Zl9lbmFibGUoZGV2X3ByaXYpOwo+ID4gPiA+IC0KPiA+ID4gPiAt CWlmIChyZXN1bWUgJiYgZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiA+ID4gPiAtCQlpbnRl bF9jc3JfbG9hZF9wcm9ncmFtKGRldl9wcml2KTsKPiA+ID4gCj4gPiA+IHNhbWUKPiA+ID4gCj4g PiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4gIHN0YXRpYyB2b2lkIGNubF9kaXNwbGF5X2NvcmVf dW5pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiA+ID4gKmRldl9wcml2KQo+ID4gPiA+ IEBAIC0zNTYxLDYgKzM1NTIsMTAgQEAgdm9pZCBpbnRlbF9wb3dlcl9kb21haW5zX2luaXRfaHco c3RydWN0Cj4gPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgcmVzdW1lKQo+ ID4gPiA+ICAKPiA+ID4gPiAgCS8qIEZvciBub3csIHdlIG5lZWQgdGhlIHBvd2VyIHdlbGwgdG8g YmUgYWx3YXlzIGVuYWJsZWQuICovCj4gPiA+ID4gIAlpbnRlbF9kaXNwbGF5X3NldF9pbml0X3Bv d2VyKGRldl9wcml2LCB0cnVlKTsKPiA+ID4gPiArCj4gPiA+ID4gKwlpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA+PSA5ICYmIHJlc3VtZSAmJiBkZXZfcHJpdi0KPiA+ID4gPiA+Y3NyLmRtY19wYXls b2FkKQo+ID4gPiA+ICsJCWludGVsX2Nzcl9sb2FkX3Byb2dyYW0oZGV2X3ByaXYpOwo+ID4gPiA+ ICsKPiA+ID4gPiAgCS8qIERpc2FibGUgcG93ZXIgc3VwcG9ydCBpZiB0aGUgdXNlciBhc2tlZCBz by4gKi8KPiA+ID4gPiAgCWlmICghaTkxNV9tb2RwYXJhbXMuZGlzYWJsZV9wb3dlcl93ZWxsKQo+ ID4gPiA+ICAJCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBQT1dFUl9ET01BSU5f SU5JVCk7Cj4gPiA+ID4gLS0gCj4gPiA+ID4gMi4xOC4wCj4gPiA+ID4gCj4gPiA+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=