From: Andrew Lunn Subject: Re: [RFC PATCH net-next v2 10/17] ethtool: implement GET_SETTINGS message Date: Mon, 30 Jul 2018 20:54:55 +0200 Message-ID: <20180730185455.GJ2983@lunn.ch> References: <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Pirko , David Miller , Florian Fainelli , Roopa Prabhu , Jakub Kicinski , "John W. Linville" To: Michal Kubecek Return-path: Content-Disposition: inline In-Reply-To: <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > +/* Internal kernel helper to query a device ethtool_link_settings. > + * > + * Backward compatibility note: for compatibility with legacy drivers > + * that implement only the ethtool_cmd API, this has to work with both > + * drivers implementing get_link_ksettings API and drivers > + * implementing get_settings API. When drivers implement get_settings > + * and report ethtool_cmd deprecated fields > + * (transceiver/maxrxpkt/maxtxpkt), these fields are silently ignored > + * because the resulting struct ethtool_link_settings does not report them. ~/linux/drivers$ grep -r [.]get_settings * net/ethernet/8390/etherh.c: .get_settings = etherh_get_settings, I don't think it is worth adding support for .get_settings for just one driver. It is better to just convert that driver to the new API. Andrew