From: Andrew Lunn Subject: Re: [RFC PATCH net-next v2 10/17] ethtool: implement GET_SETTINGS message Date: Mon, 30 Jul 2018 21:09:41 +0200 Message-ID: <20180730190941.GL2983@lunn.ch> References: <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Pirko , David Miller , Florian Fainelli , Roopa Prabhu , Jakub Kicinski , "John W. Linville" To: Michal Kubecek Return-path: Content-Disposition: inline In-Reply-To: <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > +Response contents: > + > + ETHA_SETTINGS_LINK (u32) link state > + [ETHA_SETTINGS_LINK] = { .type = NLA_FLAG }, Is this correct? The link is either up or down. So a u32 seems a bit big. Andrew