Return-Path: Received: from mail.kernel.org ([198.145.29.99]:59820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727069AbeHHTYi (ORCPT ); Wed, 8 Aug 2018 15:24:38 -0400 From: Jeff Layton To: linux-fsdevel@vger.kernel.org Cc: bfields@fieldses.org, neilb@suse.com Subject: [PATCH] locks: remove misleading obsolete comment Date: Wed, 8 Aug 2018 13:04:01 -0400 Message-Id: <20180808170401.19859-1-jlayton@kernel.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The spinlock handling in this file has changed significantly since this comment was written, and the file_lock_lock is no more. In addition, this overall comment no longer applies. Deleting an entry now requires both locks. Signed-off-by: Jeff Layton --- fs/locks.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 6138a9bcd924..11a4d698aba8 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -202,10 +202,6 @@ static DEFINE_HASHTABLE(blocked_hash, BLOCKED_HASH_BITS); * we often hold the flc_lock as well. In certain cases, when reading the fields * protected by this lock, we can skip acquiring it iff we already hold the * flc_lock. - * - * In particular, adding an entry to the fl_block list requires that you hold - * both the flc_lock and the blocked_lock_lock (acquired in that order). - * Deleting an entry from the list however only requires the file_lock_lock. */ static DEFINE_SPINLOCK(blocked_lock_lock); -- 2.17.1