From: Tarun Vyas Subject: Re: [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2 Date: Mon, 13 Aug 2018 11:17:57 -0700 Message-ID: <20180813181757.GA62468@otc-chromeosbuild-5> References: <20180810004135.11569-1-dhinakaran.pandiyan@intel.com> <20180810004135.11569-2-dhinakaran.pandiyan@intel.com> <20180813165729.GF24245@intel.com> <7b65a70857d4510251a5fcb4cac325813084b417.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id E313C6E1D3 for ; Mon, 13 Aug 2018 18:17:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7b65a70857d4510251a5fcb4cac325813084b417.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBdWcgMTMsIDIwMTggYXQgMTE6MTA6MDBBTSAtMDcwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gT24gTW9uLCAyMDE4LTA4LTEzIGF0IDA5OjU3IC0wNzAwLCBSb2RyaWdv IFZpdmkgd3JvdGU6Cj4gPiBPbiBUaHUsIEF1ZyAwOSwgMjAxOCBhdCAwNTo0MTozNVBNIC0wNzAw LCBEaGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOgo+ID4gPiBDSSBydW5zIHNob3cgUFNSMiBkb2Vz IG5vdCBnbyB0byBJRExFIHdpdGggc2VsZWN0aXZlIHVwZGF0ZSBlbmFibGVkCj4gPiA+IG9uCj4g PiA+IGFsbCBQU1IgZXhpdCB0cmlnZ2Vycy4gU3BlY2lmaWNhbGx5LCBsb2dzIGluZGljYXRlIHRo ZSBoYXJkd2FyZQo+ID4gPiBlbnRlcnMKPiA+ID4gIlNMRUVQIFNlbGVjdGl2ZSBVcGRhdGUiIGFu ZCBub3QgIklETEUgUmVzZXQgc3RhdGUnIGxpa2UgdGhlIGtlcm5lbAo+ID4gPiBleHBlY3RzLiBU aGlzIGNoZWNrIHdhcyBhZGRlZCBmb3IgUFNSMSBidXQgaW5jb3JyZWN0bHkgZXh0ZW5kZWQgdG8K PiA+ID4gUFNSMiwKPiA+ID4gcmVtb3ZlIHRoaXMgY2hlY2sgZm9yIFBTUjIgYXMgdGhlcmUgaXMg YSBwbGFuIHRvIHRlc3Qgb25seSBQU1IxIG9uCj4gPiA+IFBTUjIKPiA+ID4gcGFuZWxzLgo+ID4g PiAKPiA+ID4gQWxzbyBhZGQgYnNwZWMgcmVmZXJlbmNlIHRvIHRoZSBjb21tZW50IGFib3V0IGlk bGUgdGltZW91dC4KPiA+ID4gCj4gPiA+IENjOiBUYXJ1biBWeWFzIDx0YXJ1bi52eWFzQGludGVs LmNvbT4KPiA+ID4gQ2M6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwu Y29tPgo+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFu QGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w c3IuYyB8IDM5ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gPiA+IC0tLS0tLQo+ID4gPiAg MSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+ID4gPiAK PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+ IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gaW5kZXggNTY4NmRkYWE2 YTcyLi4wOWJlOWJmZWUyYmUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Bzci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5j Cj4gPiA+IEBAIC03MjIsMzcgKzcyMiwyNiBAQCBpbnQgaW50ZWxfcHNyX3dhaXRfZm9yX2lkbGUo Y29uc3Qgc3RydWN0Cj4gPiA+IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlLAo+ID4g PiAgewo+ID4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhuZXdf Y3J0Y19zdGF0ZS0KPiA+ID4gPmJhc2UuY3J0Yyk7Cj4gPiA+ICAJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLQo+ID4gPiA+YmFzZS5kZXYpOwo+ID4gPiAt CWk5MTVfcmVnX3QgcmVnOwo+ID4gPiAtCXUzMiBtYXNrOwo+ID4gPiAtCj4gPiA+IC0JaWYgKCFu ZXdfY3J0Y19zdGF0ZS0+aGFzX3BzcikKPiA+ID4gLQkJcmV0dXJuIDA7Cj4gPiA+ICAKPiA+ID4g IAkvKgo+ID4gPiAtCSAqIFRoZSBzb2xlIHVzZXIgcmlnaHQgbm93IGlzIGludGVsX3BpcGVfdXBk YXRlX3N0YXJ0KCksCj4gPiA+IC0JICogd2hpY2ggd29uJ3QgcmFjZSB3aXRoIHBzcl9lbmFibGUv ZGlzYWJsZSwgd2hpY2ggaXMKPiA+ID4gLQkgKiB3aGVyZSBwc3IyX2VuYWJsZWQgaXMgd3JpdHRl biB0by4gU28sIHdlIGRvbid0IG5lZWQKPiA+ID4gLQkgKiB0byBhY3F1aXJlIHRoZSBwc3IubG9j ay4gTW9yZSBpbXBvcnRhbnRseSwgd2Ugd2FudCB0aGUKPiA+ID4gLQkgKiBsYXRlbmN5IGluc2lk ZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCgpIHRvIGJlIGFzIGxvdwo+ID4gPiAtCSAqIGFzIHBv c3NpYmxlLCBzbyBubyBuZWVkIHRvIGFjcXVpcmUgcHNyLmxvY2sgd2hlbiBpdCBpcwo+ID4gPiAt CSAqIG5vdCBuZWVkZWQgYW5kIHdpbGwgaW5kdWNlIGxhdGVuY2llcyBpbiB0aGUgYXRvbWljCj4g PiA+IC0JICogdXBkYXRlIHBhdGguCj4gPiA+ICsJICogVGhlIHNvbGUgdXNlciByaWdodCBub3cg aXMgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoKSwKPiA+ID4gd2hpY2ggd29uJ3QKPiA+ID4gKwkg KiByYWNlIHdpdGggcHNyX2VuYWJsZS9kaXNhYmxlIHdoZXJlIHBzcjJfZW5hYmxlZCBpcwo+ID4g PiB3cml0dGVuIHRvLiBTbywgd2UKPiA+ID4gKwkgKiBkb24ndCBuZWVkIHRvIGFjcXVpcmUgdGhl IHBzci5sb2NrLiBNb3JlIGltcG9ydGFudGx5LAo+ID4gPiB3ZSB3YW50IHRoZQo+ID4gPiArCSAq IGxhdGVuY3kgaW5zaWRlIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KCkgdG8gYmUgYXMgbG93Cj4g PiA+IGFzIHBvc3NpYmxlLCBzbwo+ID4gPiArCSAqIG5vIG5lZWQgdG8gYWNxdWlyZSBwc3IubG9j ayB3aGVuIGl0IGlzIG5vdCBuZWVkZWQgYW5kCj4gPiA+IHdpbGwgaW5kdWNlCj4gPiA+ICsJICog bGF0ZW5jaWVzIGluIHRoZSBhdG9taWMgdXBkYXRlIHBhdGguCj4gPiA+ICAJICovCj4gPiAKPiA+ IEkgdGhpbmsgd2Ugc2hvdWxkbid0IGNoYW5nZSB0aGlzIGZvcm1hdCBoZXJlIHRvIGtlZXAgcGF0 Y2ggY2xlYW5lci4uLgo+ID4gaWYgdGhlcmUgaXMgYW55IGNoYW5nZSBoZXJlIEkgY291bGRuJ3Qg c2VlIGJlY2F1c2UgaXQgaXMgY2hhbmdpbmcgYWxsCj4gPiBsaW5lcyBhbmQgaWYgdGhlcmUgaXMg bm8gY2hhbmdlIEkgdGhpbmsgaXQgaXMgYmV0dGVyIG5vdCB0byB0b3VjaAo+ID4gYmVjYXVzZQo+ ID4gaXQgcmVtb3ZlcyB0aGUgZm9jdXMgb2YgdGhlIHJlYWwgY2hhbmdlcy4KPiAKPiBPa2F5Lgo+ ID4gCj4gPiA+IC0JaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gPiA+IC0JCXJl ZyA9IEVEUF9QU1IyX1NUQVRVUzsKPiA+ID4gLQkJbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFU RV9NQVNLOwo+ID4gPiAtCX0gZWxzZSB7Cj4gPiA+IC0JCXJlZyA9IEVEUF9QU1JfU1RBVFVTOwo+ ID4gPiAtCQltYXNrID0gRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsKPiA+ID4gLQl9Cj4gPiA+ ICsJaWYgKCFuZXdfY3J0Y19zdGF0ZS0+aGFzX3BzciB8fCBSRUFEX09OQ0UoZGV2X3ByaXYtCj4g PiA+ID5wc3IucHNyMl9lbmFibGVkKSkKPiA+IAo+ID4gSSBub3cgc2VlIHRoYXQgd2UgYXJlIHJl bW92aW5nIHBzcjIgb2YgdGhlIHBpY3R1cmUsIGJ1dCBJIGRvbid0IHNlZQo+ID4gaG93IHdlIGFy ZQo+ID4gaW1wcm92aW5nIHBzcjIgc2l0dWF0aW9uIGhlcmUuCj4gPiB3aGF0IGFtIEkgbWlzc2lu Zz8KPiA+IAo+IFdoZW4gdGhlIHBhdGNoIHdhcyB3cml0dGVuLCB3ZSBkaWQgbm90IGhhdmUgc3Vm ZmljaWVudCB0ZXN0cyB0byB0ZWxsIHVzCj4gdGhlIHdhaXRfZm9yX2lkbGUgY29uZGl0aW9uIHdh cyB3cm9uZyBmb3IgUFNSMi4gSXQgd2FzIG5vdCBrbm93bgo+IHdoZXRoZXIgdGhlIHdhaXQgd2Fz ICpuZWNlc3NhcnkqIGZvciBQU1IyLCB0aGluayBvZiB0aGlzIGFzIGEgcGFydGlhbAo+IHJldmVy dC4gTm93IHRoYXQgQ0kgaGFzIHBvaW50ZWQgb3V0LCAoYW5kIEkgY2hlY2tlZCB3aXRoIGEgUFNS MiBwYW5lbCkKPiB0aGF0IHRoZSBjb25kaXRpb24gaXMgd3JvbmcsIHdlIHNob3VsZCBiZSByZW1v dmluZyBpdCBmb3IgUFNSMi4gSWYgeW91Cj4gdGhpbmsgYWJvdXQgaXQsIGl0IGRvZXMgaW1wcm92 ZSBQU1IyIG15IHJlbW92aW5nIGlycmVsZXZhbnQgY29kZS4KRG8gd2UgaGF2ZSBhbm90aGVyIHdh eSB0byBlbnN1cmUgdGhhdCB3ZSBkb250IHRyeSB0byBkbyBhIHBpcGUgdXBkYXRlIG9yIHJhdGhl cgpjaGVjayBmb3IgdGhlIFBJUEUgRFNMIHdoZW4gc3RpbGwgaW4gYSBQU1IyIHNsZWVwIHN0YXRl ID8KPiAKPiAKPiA+ID4gKwkJcmV0dXJuIDA7Cj4gPiA+ICAKPiA+ID4gIAkvKgo+ID4gPiAtCSAq IE1heCB0aW1lIGZvciBQU1IgdG8gaWRsZSA9IEludmVyc2Ugb2YgdGhlIHJlZnJlc2ggcmF0ZQo+ ID4gPiArCj4gPiA+IC0JICogNiBtcyBvZiBleGl0IHRyYWluaW5nIHRpbWUgKyAxLjUgbXMgb2Yg YXV4IGNoYW5uZWwKPiA+ID4gLQkgKiBoYW5kc2hha2UuIDUwIG1zZWMgaXMgZGVmZXNpdmUgZW5v dWdoIHRvIGNvdmVyCj4gPiA+IGV2ZXJ5dGhpbmcuCj4gPiA+ICsJICogRnJvbSBCc3BlYyBQYW5l bCBTZWxmIFJlZnJlc2ggKEJEVyspOgo+ID4gCj4gPiBUaGlzIGlzIGFub3RoZXIgY2FzZSwgaWYg d2UgZGlkbid0IGNoYW5nZSB0aGUgZm9ybWF0IG9ubHkgdGhpcyBsaW5lIF4KPiA+IHdvdWxkIGJl IGluIHRoZSBwYXRjaCBhbmQgaXQgd291bGQgYmUgY2xlYW5lciBhbmQgZWFzaWVyIHRvIHJldmll dwo+ID4gdGhlCj4gPiBjaGFuZ2VzLgo+ID4gCj4gPiBidXQgbXkgYmlnZ2VzdCBjb25jZXJuIHdp dGggdGhpcyBwYXRjaCBpcyBob3cgZG8gd2UgY2hlY2sgbm93Cj4gPiB3YWl0X3BzcjIgaWRsZQo+ ID4gCj4gPiA+ICsJICogTWF4LiB0aW1lIGZvciBQU1IgdG8gaWRsZSA9IGludmVyc2Ugb2YgdGhl IHJlZnJlc2ggcmF0ZQo+ID4gPiArIDYgbXMgb2YKPiA+ID4gKwkgKiBleGl0IHRyYWluaW5nIHRp bWUgKyAxLjUgbXMgb2YgYXV4IGNoYW5uZWwgaGFuZHNoYWtlLgo+ID4gPiA1MCBtcyBpcwo+ID4g PiArCSAqIGRlZmVuc2l2ZSBlbm91Z2ggdG8gY292ZXIgZXZlcnl0aGluZy4KPiA+ID4gIAkgKi8K PiA+ID4gLQo+ID4gPiAtCXJldHVybiBfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2 LCByZWcsIG1hc2ssCj4gPiA+ICsJcmV0dXJuIF9faW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2 X3ByaXYsIEVEUF9QU1JfU1RBVFVTLAo+ID4gPiArCQkJCQkgRURQX1BTUl9TVEFUVVNfU1RBVEVf TUFTSwo+ID4gPiAsCj4gPiA+ICAJCQkJCSBFRFBfUFNSX1NUQVRVU19TVEFURV9JRExFCj4gPiA+ ICwgMiwgNTAsCj4gPiA+ICAJCQkJCSBvdXRfdmFsdWUpOwo+ID4gPiAgfQo+ID4gPiAtLSAKPiA+ ID4gMi4xNy4xCj4gPiA+IAo+ID4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiA+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==