Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id EF91AE00A54; Mon, 13 Aug 2018 18:38:20 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [147.11.146.13 listed in list.dnswl.org] Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E008BE009E7 for ; Mon, 13 Aug 2018 18:38:19 -0700 (PDT) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id w7E1cJDf008490 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL) for ; Mon, 13 Aug 2018 18:38:19 -0700 (PDT) Received: from pek-lpggp6.wrs.com (128.224.153.40) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.399.0; Mon, 13 Aug 2018 18:38:18 -0700 From: Kevin Hao To: Date: Tue, 14 Aug 2018 09:31:21 +0800 Message-ID: <20180814013126.191534-2-kexin.hao@windriver.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180814013126.191534-1-kexin.hao@windriver.com> References: <20180814013126.191534-1-kexin.hao@windriver.com> MIME-Version: 1.0 Subject: [PATCH 1/6] wic: Remove the unused variable Partition.sourceparams_dict X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion & patch submission for meta-yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 01:38:21 -0000 Content-Type: text/plain We choose to pass the source parameters to the source plugins' hooks via a local variable srcparams_dict. So the Partition.sourceparams_dict is not used by anyone and seems pretty confused. So drop it. Signed-off-by: Kevin Hao --- scripts/lib/wic/partition.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py index c73af9d4275e..5054779b1b6b 100644 --- a/scripts/lib/wic/partition.py +++ b/scripts/lib/wic/partition.py @@ -66,7 +66,6 @@ class Partition(): self.lineno = lineno self.source_file = "" - self.sourceparams_dict = {} def get_extra_block_count(self, current_blocks): """ -- 2.14.4