From: Daniel Vetter Subject: Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation Date: Tue, 21 Aug 2018 10:44:24 +0200 Message-ID: <20180821084424.GF21634@phenom.ffwll.local> References: <20180703160354.59955-1-noralf@tronnes.org> <20180703160354.59955-5-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Stultz Cc: David Lechner , Intel Graphics Development , dri-devel , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjAsIDIwMTggYXQgMTE6NDQ6NTZQTSAtMDcwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gVHVlLCBKdWwgMywgMjAxOCBhdCA5OjAzIEFNLCBOb3JhbGYgVHLDuG5uZXMgPG5v cmFsZkB0cm9ubmVzLm9yZz4gd3JvdGU6Cj4gPiBUaGlzIHN3aXRjaGVzIHRoZSBDTUEgaGVscGVy IGRyaXZlcnMgdGhhdCB1c2UgaXRzIGZiZGV2IGVtdWxhdGlvbiBvdmVyCj4gPiB0byB0aGUgZ2Vu ZXJpYyBmYmRldiBlbXVsYXRpb24uIEl0J3MgdGhlIGZpcnN0IHBoYXNlIG9mIHVzaW5nIGdlbmVy aWMKPiA+IGZiZGV2LiBBIGxhdGVyIHBoYXNlIHdpbGwgdXNlIERSTSBjbGllbnQgY2FsbGJhY2tz IGZvciB0aGUKPiA+IGxhc3RjbG9zZS9ob3RwbHVnL3JlbW92ZSBjYWxsYmFja3MuCj4gPgo+ID4g VGhlcmUgYXJlIGN1cnJlbnRseSAyIGZiZGV2IGluaXQvZmluaSBmdW5jdGlvbnM6Cj4gPiAtIGRy bV9mYl9jbWFfZmJkZXZfaW5pdC9kcm1fZmJfY21hX2ZiZGV2X2ZpbmkKPiA+IC0gZHJtX2ZiZGV2 X2NtYV9pbml0L2RybV9mYmRldl9jbWFfZmluaQo+ID4KPiA+IFRoaXMgaXMgYmVjYXVzZSB0aGUg d29yayBvbiBnZW5lcmljIGZiZGV2IGNhbWUgdXAgZHVyaW5nIGEgZmJkZXYKPiA+IHJlZmFjdG9y aW5nIGFuZCB0aHVzIHdhc24ndCBjb21wbGV0ZWQuIE5vIHBvaW50IGluIGNvbXBsZXRpbmcgdGhh dAo+ID4gcmVmYWN0b3Jpbmcgd2hlbiBkcml2ZXJzIHdpbGwgc29vbiBtb3ZlIHRvIGRybV9mYl9o ZWxwZXJfZ2VuZXJpY19wcm9iZSgpLgo+ID4KPiA+IHRpbnlkcm0gdXNlcyBkcm1fZmJfY21hX2Zi ZGV2X2luaXRfd2l0aF9mdW5jcygpLgo+ID4KPiA+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYg VHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiA+IEFja2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9mYl9jbWFfaGVscGVyLmMgfCAzNjAgKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPiAgaW5jbHVkZS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuaCAgICAgfCAgIDMgLQo+ID4g IDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMzIxIGRlbGV0aW9ucygtKQo+IC4u Lgo+ID4gLXN0YXRpYyBpbnQgZHJtX2ZiZGV2X2NtYV9kZWZpb19pbml0KHN0cnVjdCBmYl9pbmZv ICpmYmksCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJt X2dlbV9jbWFfb2JqZWN0ICpjbWFfb2JqKQo+ID4gLXsKPiA+IC0gICAgICAgc3RydWN0IGZiX2Rl ZmVycmVkX2lvICpmYmRlZmlvOwo+ID4gLSAgICAgICBzdHJ1Y3QgZmJfb3BzICpmYm9wczsKPiA+ IC0KPiA+IC0gICAgICAgLyoKPiA+IC0gICAgICAgICogUGVyIGRldmljZSBzdHJ1Y3R1cmVzIGFy ZSBuZWVkZWQgYmVjYXVzZToKPiA+IC0gICAgICAgICogZmJvcHM6IGZiX2RlZmVycmVkX2lvX2Ns ZWFudXAoKSBjbGVhcnMgZmJvcHMuZmJfbW1hcAo+ID4gLSAgICAgICAgKiBmYmRlZmlvOiBpbmRp dmlkdWFsIGRlbGF5cwo+ID4gLSAgICAgICAgKi8KPiA+IC0gICAgICAgZmJkZWZpbyA9IGt6YWxs b2Moc2l6ZW9mKCpmYmRlZmlvKSwgR0ZQX0tFUk5FTCk7Cj4gPiAtICAgICAgIGZib3BzID0ga3ph bGxvYyhzaXplb2YoKmZib3BzKSwgR0ZQX0tFUk5FTCk7Cj4gPiAtICAgICAgIGlmICghZmJkZWZp byB8fCAhZmJvcHMpIHsKPiA+IC0gICAgICAgICAgICAgICBrZnJlZShmYmRlZmlvKTsKPiA+IC0g ICAgICAgICAgICAgICBrZnJlZShmYm9wcyk7Cj4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIC1F Tk9NRU07Cj4gPiAtICAgICAgIH0KPiA+IC0KPiA+IC0gICAgICAgLyogY2FuJ3QgYmUgb2Zmc2V0 IGZyb20gdmFkZHIgc2luY2UgZGlydHkoKSB1c2VzIGNtYV9vYmogKi8KPiA+IC0gICAgICAgZmJp LT5zY3JlZW5fYnVmZmVyID0gY21hX29iai0+dmFkZHI7Cj4gPiAtICAgICAgIC8qIGZiX2RlZmVy cmVkX2lvX2ZhdWx0KCkgbmVlZHMgYSBwaHlzaWNhbCBhZGRyZXNzICovCj4gPiAtICAgICAgIGZi aS0+Zml4LnNtZW1fc3RhcnQgPSBwYWdlX3RvX3BoeXModmlydF90b19wYWdlKGZiaS0+c2NyZWVu X2J1ZmZlcikpOwo+ID4gLQo+ID4gLSAgICAgICAqZmJvcHMgPSAqZmJpLT5mYm9wczsKPiA+IC0g ICAgICAgZmJpLT5mYm9wcyA9IGZib3BzOwo+ID4gLQo+ID4gLSAgICAgICBmYmRlZmlvLT5kZWxh eSA9IG1zZWNzX3RvX2ppZmZpZXMoREVGQVVMVF9GQkRFRklPX0RFTEFZX01TKTsKPiA+IC0gICAg ICAgZmJkZWZpby0+ZGVmZXJyZWRfaW8gPSBkcm1fZmJfaGVscGVyX2RlZmVycmVkX2lvOwo+ID4g LSAgICAgICBmYmktPmZiZGVmaW8gPSBmYmRlZmlvOwo+ID4gLSAgICAgICBmYl9kZWZlcnJlZF9p b19pbml0KGZiaSk7Cj4gPiAtICAgICAgIGZiaS0+ZmJvcHMtPmZiX21tYXAgPSBkcm1fZmJkZXZf Y21hX2RlZmVycmVkX2lvX21tYXA7Cj4gPiAtCj4gPiAtICAgICAgIHJldHVybiAwOwo+ID4gLX0K PiA+IC0KPiA+IC1zdGF0aWMgdm9pZCBkcm1fZmJkZXZfY21hX2RlZmlvX2Zpbmkoc3RydWN0IGZi X2luZm8gKmZiaSkKPiA+IC17Cj4gPiAtICAgICAgIGlmICghZmJpLT5mYmRlZmlvKQo+ID4gLSAg ICAgICAgICAgICAgIHJldHVybjsKPiA+IC0KPiA+IC0gICAgICAgZmJfZGVmZXJyZWRfaW9fY2xl YW51cChmYmkpOwo+ID4gLSAgICAgICBrZnJlZShmYmktPmZiZGVmaW8pOwo+ID4gLSAgICAgICBr ZnJlZShmYmktPmZib3BzKTsKPiA+IC19Cj4gPiAtCj4gPiAtc3RhdGljIGludAo+ID4gLWRybV9m YmRldl9jbWFfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gPiAtICAgICAg IHN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZhY2Vfc2l6ZSAqc2l6ZXMpCj4gPiAtewo+ID4gLSAg ICAgICBzdHJ1Y3QgZHJtX2ZiZGV2X2NtYSAqZmJkZXZfY21hID0gdG9fZmJkZXZfY21hKGhlbHBl cik7Cj4gPiAtICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBoZWxwZXItPmRldjsKPiA+ IC0gICAgICAgc3RydWN0IGRybV9nZW1fY21hX29iamVjdCAqb2JqOwo+ID4gLSAgICAgICBzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYjsKPiA+IC0gICAgICAgdW5zaWduZWQgaW50IGJ5dGVzX3Bl cl9waXhlbDsKPiA+IC0gICAgICAgdW5zaWduZWQgbG9uZyBvZmZzZXQ7Cj4gPiAtICAgICAgIHN0 cnVjdCBmYl9pbmZvICpmYmk7Cj4gPiAtICAgICAgIHNpemVfdCBzaXplOwo+ID4gLSAgICAgICBp bnQgcmV0Owo+ID4gLQo+ID4gLSAgICAgICBEUk1fREVCVUdfS01TKCJzdXJmYWNlIHdpZHRoKCVk KSwgaGVpZ2h0KCVkKSBhbmQgYnBwKCVkKVxuIiwKPiA+IC0gICAgICAgICAgICAgICAgICAgICAg IHNpemVzLT5zdXJmYWNlX3dpZHRoLCBzaXplcy0+c3VyZmFjZV9oZWlnaHQsCj4gPiAtICAgICAg ICAgICAgICAgICAgICAgICBzaXplcy0+c3VyZmFjZV9icHApOwo+ID4gLQo+ID4gLSAgICAgICBi eXRlc19wZXJfcGl4ZWwgPSBESVZfUk9VTkRfVVAoc2l6ZXMtPnN1cmZhY2VfYnBwLCA4KTsKPiA+ IC0gICAgICAgc2l6ZSA9IHNpemVzLT5zdXJmYWNlX3dpZHRoICogc2l6ZXMtPnN1cmZhY2VfaGVp Z2h0ICogYnl0ZXNfcGVyX3BpeGVsOwo+ID4gLSAgICAgICBvYmogPSBkcm1fZ2VtX2NtYV9jcmVh dGUoZGV2LCBzaXplKTsKPiA+IC0gICAgICAgaWYgKElTX0VSUihvYmopKQo+ID4gLSAgICAgICAg ICAgICAgIHJldHVybiAtRU5PTUVNOwo+ID4gLQo+ID4gLSAgICAgICBmYmkgPSBkcm1fZmJfaGVs cGVyX2FsbG9jX2ZiaShoZWxwZXIpOwo+ID4gLSAgICAgICBpZiAoSVNfRVJSKGZiaSkpIHsKPiA+ IC0gICAgICAgICAgICAgICByZXQgPSBQVFJfRVJSKGZiaSk7Cj4gPiAtICAgICAgICAgICAgICAg Z290byBlcnJfZ2VtX2ZyZWVfb2JqZWN0Owo+ID4gLSAgICAgICB9Cj4gPiAtCj4gPiAtICAgICAg IGZiID0gZHJtX2dlbV9mYmRldl9mYl9jcmVhdGUoZGV2LCBzaXplcywgMCwgJm9iai0+YmFzZSwK PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYmRldl9jbWEtPmZiX2Z1 bmNzKTsKPiA+IC0gICAgICAgaWYgKElTX0VSUihmYikpIHsKPiA+IC0gICAgICAgICAgICAgICBk ZXZfZXJyKGRldi0+ZGV2LCAiRmFpbGVkIHRvIGFsbG9jYXRlIERSTSBmcmFtZWJ1ZmZlci5cbiIp Owo+ID4gLSAgICAgICAgICAgICAgIHJldCA9IFBUUl9FUlIoZmIpOwo+ID4gLSAgICAgICAgICAg ICAgIGdvdG8gZXJyX2ZiX2luZm9fZGVzdHJveTsKPiA+IC0gICAgICAgfQo+ID4gLQo+ID4gLSAg ICAgICBoZWxwZXItPmZiID0gZmI7Cj4gPiAtCj4gPiAtICAgICAgIGZiaS0+cGFyID0gaGVscGVy Owo+ID4gLSAgICAgICBmYmktPmZsYWdzID0gRkJJTkZPX0ZMQUdfREVGQVVMVDsKPiA+IC0gICAg ICAgZmJpLT5mYm9wcyA9ICZkcm1fZmJkZXZfY21hX29wczsKPiA+IC0KPiA+IC0gICAgICAgZHJt X2ZiX2hlbHBlcl9maWxsX2ZpeChmYmksIGZiLT5waXRjaGVzWzBdLCBmYi0+Zm9ybWF0LT5kZXB0 aCk7Cj4gPiAtICAgICAgIGRybV9mYl9oZWxwZXJfZmlsbF92YXIoZmJpLCBoZWxwZXIsIHNpemVz LT5mYl93aWR0aCwgc2l6ZXMtPmZiX2hlaWdodCk7Cj4gPiAtCj4gPiAtICAgICAgIG9mZnNldCA9 IGZiaS0+dmFyLnhvZmZzZXQgKiBieXRlc19wZXJfcGl4ZWw7Cj4gPiAtICAgICAgIG9mZnNldCAr PSBmYmktPnZhci55b2Zmc2V0ICogZmItPnBpdGNoZXNbMF07Cj4gPiAtCj4gPiAtICAgICAgIGRl di0+bW9kZV9jb25maWcuZmJfYmFzZSA9IChyZXNvdXJjZV9zaXplX3Qpb2JqLT5wYWRkcjsKPiA+ IC0gICAgICAgZmJpLT5zY3JlZW5fYmFzZSA9IG9iai0+dmFkZHIgKyBvZmZzZXQ7Cj4gPiAtICAg ICAgIGZiaS0+Zml4LnNtZW1fc3RhcnQgPSAodW5zaWduZWQgbG9uZykob2JqLT5wYWRkciArIG9m ZnNldCk7Cj4gCj4gSGV5IE5vcmFsZiwgYWxsLAo+ICAgSSd2ZSBiZWVuIGRpZ2dpbmcgZm9yIGEg Yml0IG9uIHRoZSByZWdyZXNzaW9uIHRoYXQgdGhpcyBwYXRjaCBoYXMKPiB0cmlwcGVkIG9uIHRo ZSBIaUtleSBib2FyZCBhcyByZXBvcnRlZCBoZXJlOgo+IGh0dHBzOi8vbGttbC5vcmcvbGttbC8y MDE4LzgvMTYvODEKPiAKPiBUaGUgZmlyc3QgaXNzdWUgd2FzIHRoYXQgdGhlIGtpcmluIGRyaXZl ciB3YXMgc2V0dGluZwo+IG1vZGVfY29uZmlnLm1heF93aWR0aC9oZWlnaHQgPSAyMDQ4LCB3aGlj aCB3YXMgY2F1c2luZyBlcnJvcnMgYXMgdGhlCj4gdGhlIHJlcXVlc3RlZCByZXNvbHV0aW9uIHdh cyAxOTIweDIxNjAgKGR1ZSB0byBzdXJmYWNlZmxpbmdlcgo+IHJlcXVlc3RpbmcgeSoyIGZvciBw YWdlIGZsaXBwaW5nKS4gIFRoaXMgd2FzIHJlbGF0aXZlbHkgc2ltcGxlIGVub3VnaAo+IHRvIGZp Z3VyZSBvdXQgYW5kIGZpeCwgYnV0IGJ1bXBpbmcgdGhlIHZhbHVlcyB1cCBvbiBpdHMgb3duIGRp ZG4ndAo+IHNlZW0gdG8gcmVzb2x2ZSB0aGUgaXNzdWUgZW50aXJlbHksIGFzIEkgc3RhcnRlZCB0 byBzZWUgaGFyZCBoYW5ncyBvbgo+IGJvb3R1cCB3aGVuIHVzZXJzcGFjZSBzdGFydGVkIHVzaW5n IHRoZSBlbXVsYXRlZCBmYmRldiBkZXZpY2UuCj4gCj4gQWZ0ZXIgY29uZmlybWluZyByZXZlcnRp bmcgdGhlIHBhdGNoIGhlcmUgd29ya2VkIGFyb3VuZCBpdCwgSSBzdGFydGVkCj4gZGlnZ2luZyB0 aHJvdWdoIHdoYXQgbWlnaHQgYmUgZGlmZmVyZW50LCBhbmQgSSB0aGluayBJJ3ZlIGZvdW5kIGl0 Lgo+IEluIHRoZSBkcm1fZmJkZXZfY21hX2NyZWF0ZSgpIGZ1bmN0aW9uIGFib3ZlLCB3ZSBzZXQg dGhlCj4gZmJpLT5maXguc21lbV9zdGFydCB2YWx1ZSwgd2hlcmUgYXMgaW4gZHJtX2ZiX2hlbHBl cl9nZW5lcmljX3Byb2JlKCksCj4gd2hpY2ggbm93IHJlcGxhY2VzIHRoYXQsIHdlIGRvbid0IHNl dCBzbWVtX3N0YXJ0IHZhbHVlIGF0IGFsbC4KPiAKPiBTaW5jZSB3ZSBkb24ndCBoYXZlIGEgZHJt X2dlbV9jbWFfb2JqZWN0IHJlZmVyZW5jZSBpbgo+IGRybV9mYl9oZWxwZXJfZ2VuZXJpY19wcm9i ZSgpLCBJIGluc3RlYWQgYWRkZWQ6Cj4gICAgZmJpLT5maXguc21lbV9zdGFydCA9IHBhZ2VfdG9f cGh5cyh2aXJ0X3RvX3BhZ2UoZmJpLT5zY3JlZW5fYnVmZmVyKSk7Cj4gCj4gQW5kIHRoYXQgZ290 IHRoaW5ncyB3b3JraW5nIQo+IAo+IFNvIHllYSwgSSB3YW50ZWQgdG8gZmlndXJlIG91dCBpZiB3 ZSBhcmUganVzdCBtaXNzaW5nIHRoZSBsaW5lIGFib3ZlCj4gaW4gZHJtX2ZiX2hlbHBlcl9nZW5l cmljX3Byb2JlKCk/IE9yIGlmIHRoZSBraXJpbiBkcml2ZXIgc2hvdWxkIGJlCj4gc2V0dGluZyB0 aGUgZml4LnNtZW1fc3RhcnQgaW4gc29tZSBvdGhlciBmYXNoaW9uPwoKV2l0aCB0aGUgZ2VuZXJp YyBoZWxwZXJzIHdlIGNhbid0IHVzZSB0aGUgZ2VuZXJpYyBmYl9tbWFwKCkgaW1wbGVtZW50YXRp b24KaW4gZmJkZXYvY29yZS9mYm1lbS5jIGFueW1vcmUuIEluc3RlYWQgTm9yYWxmIGFkZGVkIGEg Z2VuZXJpYyBmYl9tbWFwCmZiX29wcyBjYWxsYmFjayBpbiBkcm1fZmJkZXZfZmJfbW1hcCwgd2hp Y2ggeW91J3JlIHN1cHBvc2VkIHRvIHVzZS4gQ2FuCnlvdSBwbHMgZG91YmxlLWNoZWNrIHRoYXQg dGhpcyBpcyB3aXJlZCB1cCBjb3JyZWN0bHkgZm9yIGtpcmluPwoKQXQgbGVhc3QgSSBkb24ndCBz ZWUgYW55IG90aGVyIHBsYWNlIHdoZXJlIHdlIHVzZSBzbWVtX3N0YXJ0IGluIHRoZSBmYmRldgpj b2RlLiBJdCBkb2VzIGdldCBjb3BpZWQgdG8gdXNlcnNwYWNlLCBidXQgdXNlcnNwYWNlIHNob3Vs ZCBuZXZlciB1c2UKdGhhdC4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==