From: Sean Paul Subject: Re: [PATCH v4 1/2] drm: Add per-plane pixel blend mode property Date: Wed, 22 Aug 2018 08:39:49 -0400 Message-ID: <20180822123949.GU164269@art_vandelay> References: <1534314933-23182-1-git-send-email-lowry.li@arm.com> <1534314933-23182-2-git-send-email-lowry.li@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw1-xc43.google.com (mail-yw1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F46D89C9C for ; Wed, 22 Aug 2018 12:39:51 +0000 (UTC) Received: by mail-yw1-xc43.google.com with SMTP id q129-v6so573580ywg.8 for ; Wed, 22 Aug 2018 05:39:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1534314933-23182-2-git-send-email-lowry.li@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lowry Li Cc: airlied@linux.ie, liviu.dudau@arm.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, daniel.vetter@intel.com, malidp@foss.arm.com, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMTUsIDIwMTggYXQgMDI6MzU6MzJQTSArMDgwMCwgTG93cnkgTGkgd3JvdGU6 Cj4gUGl4ZWwgYmxlbmQgbW9kZXMgcmVwcmVzZW50IHRoZSBhbHBoYSBibGVuZGluZyBlcXVhdGlv bgo+IHNlbGVjdGlvbiwgZGVzY3JpYmluZyBob3cgdGhlIHBpeGVscyBmcm9tIHRoZSBjdXJyZW50 Cj4gcGxhbmUgYXJlIGNvbXBvc2l0ZWQgd2l0aCB0aGUgYmFja2dyb3VuZC4KPiAKPiBBZGRzIGEg cGl4ZWxfYmxlbmRfbW9kZSB0byBkcm1fcGxhbmVfc3RhdGUgYW5kIGEKPiBibGVuZF9tb2RlX3By b3BlcnR5IHRvIGRybV9wbGFuZSwgYW5kIHJlbGF0ZWQgc3VwcG9ydAo+IGZ1bmN0aW9ucy4KPiAK PiBEZWZpbmVzIHRocmVlIGJsZW5kIG1vZGVzIGluIGRybV9ibGVuZC5oLgo+IAo+IENoYW5nZXMg c2luY2UgdjE6Cj4gIC0gTW92ZXMgdGhlIGJsZW5kaW5nIGVxdWF0aW9uIGludG8gdGhlIERPQyBj b21tZW50Cj4gIC0gUmVmaW5lcyB0aGUgY29tbWVudHMgb2YgZHJtX3BsYW5lX2NyZWF0ZV9ibGVu ZF9tb2RlX3Byb3BlcnR5IHRvIG5vdAo+ICAgIGVudW1lcmF0ZSB0aGUgI2RlZmluZXMsIGJ1dCBp bnN0ZWFkIHRoZSBzdHJpbmcgdmFsdWVzCj4gIC0gVXNlcyBmZy4qIGluc3RlYWQgb2YgcGl4ZWwu KiBhbmQgcGxhbmVfYWxwaGEgaW5zdGVhZCBvZiBwbGFuZS5hbHBoYQo+IENoYW5nZXMgc2luY2Ug djI6Cj4gIC0gUmVmaW5lcyB0aGUgY29tbWVudHMgb2YgZHJtX3BsYW5lX2NyZWF0ZV9ibGVuZF9t b2RlX3Byb3BlcnR5Ogo+ICAgICAgIDEpIFB1dHMgdGhlIGRlc2NyaXB0aW9ucyAoYWZ0ZXIgdGhl ICI6Iikgb24gYSBuZXcgbGluZQo+ICAgICAgIDIpIEFkZHMgZXhwbGFpbmluZyB3aHkgQHN1cHBv cnRlZF9tb2RlcyBuZWVkIFBSRU1VTCBhcyBkZWZhdWx0Cj4gQ2hhbmdlcyBzaW5jZSB2MzoKPiAg LSBSZWZpbmVzIGRybV9wbGFuZV9jcmVhdGVfYmxlbmRfbW9kZV9wcm9wZXJ0eSgpLiBkcm1fcHJv cGVydHlfYWRkX2VudW0oKQo+ICAgIGNhbiBjYWxjdWxhdGUgdGhlIGluZGV4IGl0c2VsZiBqdXN0 IGZpbmUsIHNvIG5vIHBvaW50IGluIGhhdmluZyB0aGUKPiAgICBjYWxsZXIgcGFzcyBpdCBpbi4K PiAgLSBTaW5jZSB0aGUgY3VycmVudCBEUk0gYXNzdW1wdGlvbiBpcyB0aGF0IGFscGhhIGlzIHBy ZW11bHRpcGxpZWQKPiAgICBhcyBkZWZhdWx0LCBkZWZpbmUgRFJNX01PREVfQkxFTkRfUFJFTVVM VEkgYXMgMCB3aWxsIGJlIGJldHRlci4KPiAgLSBSZWZpbmVzIHNvbWUgY29tbWVudHMuCj4gCj4g U2lnbmVkLW9mZi1ieTogTG93cnkgTGkgPGxvd3J5LmxpQGFybS5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgICAgICAgIHwgICA0ICsrCj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jIHwgICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9ibGVu ZC5jICAgICAgICAgfCAxMjYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g IGluY2x1ZGUvZHJtL2RybV9ibGVuZC5oICAgICAgICAgICAgIHwgICA2ICsrCj4gIGluY2x1ZGUv ZHJtL2RybV9wbGFuZS5oICAgICAgICAgICAgIHwgICAyICsKPiAgNSBmaWxlcyBjaGFuZ2VkLCAx MzkgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDNlYjA2MWUuLmQw NDc4YWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBAQCAtODk1LDYgKzg5NSw4IEBAIHN0YXRp YyBpbnQgZHJtX2F0b21pY19wbGFuZV9zZXRfcHJvcGVydHkoc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gIAkJc3RhdGUtPnNyY19oID0gdmFsOwo+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBw bGFuZS0+YWxwaGFfcHJvcGVydHkpIHsKPiAgCQlzdGF0ZS0+YWxwaGEgPSB2YWw7Cj4gKwl9IGVs c2UgaWYgKHByb3BlcnR5ID09IHBsYW5lLT5ibGVuZF9tb2RlX3Byb3BlcnR5KSB7Cj4gKwkJc3Rh dGUtPnBpeGVsX2JsZW5kX21vZGUgPSB2YWw7Cj4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IHBs YW5lLT5yb3RhdGlvbl9wcm9wZXJ0eSkgewo+ICAJCWlmICghaXNfcG93ZXJfb2ZfMih2YWwgJiBE Uk1fTU9ERV9ST1RBVEVfTUFTSykpIHsKPiAgCQkJRFJNX0RFQlVHX0FUT01JQygiW1BMQU5FOiVk OiVzXSBiYWQgcm90YXRpb24gYml0bWFzazogMHglbGx4XG4iLAo+IEBAIC05NjgsNiArOTcwLDgg QEAgc3RhdGljIGludCBkcm1fYXRvbWljX3BsYW5lX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPiAgCQkqdmFsID0gc3RhdGUtPnNyY19oOwo+ICAJfSBlbHNlIGlmIChwcm9w ZXJ0eSA9PSBwbGFuZS0+YWxwaGFfcHJvcGVydHkpIHsKPiAgCQkqdmFsID0gc3RhdGUtPmFscGhh Owo+ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBwbGFuZS0+YmxlbmRfbW9kZV9wcm9wZXJ0eSkg ewo+ICsJCSp2YWwgPSBzdGF0ZS0+cGl4ZWxfYmxlbmRfbW9kZTsKPiAgCX0gZWxzZSBpZiAocHJv cGVydHkgPT0gcGxhbmUtPnJvdGF0aW9uX3Byb3BlcnR5KSB7Cj4gIAkJKnZhbCA9IHN0YXRlLT5y b3RhdGlvbjsKPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gcGxhbmUtPnpwb3NfcHJvcGVydHkp IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDZkZDUwMzYuLjU2M2Fm MDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0zNTY5LDYgKzM1 NjksNyBAQCB2b2lkIF9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVzZXQoc3RydWN0IGRybV9w bGFuZSAqcGxhbmUsCj4gIAkvKiBSZXNldCB0aGUgYWxwaGEgdmFsdWUgdG8gZnVsbHkgb3BhcXVl IGlmIGl0IG1hdHRlcnMgKi8KPiAgCWlmIChwbGFuZS0+YWxwaGFfcHJvcGVydHkpCj4gIAkJc3Rh dGUtPmFscGhhID0gcGxhbmUtPmFscGhhX3Byb3BlcnR5LT52YWx1ZXNbMV07Cj4gKwlwbGFuZS0+ c3RhdGUtPnBpeGVsX2JsZW5kX21vZGUgPSBEUk1fTU9ERV9CTEVORF9QUkVNVUxUSTsKClNob3Vs ZG4ndCB0aGlzIGJlIHN0YXRlLT5waXhlbF9ibGVuZF9tb2RlIGluc3RlYWQgb2YKcGxhbmUtPnN0 YXRlLT5waXhlbF9ibGVuZF9tb2RlPwoKPiAgCj4gIAlwbGFuZS0+c3RhdGUgPSBzdGF0ZTsKPiAg fQoKL3NuaXAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJv bWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK