From: Daniel Vetter Subject: Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation Date: Thu, 23 Aug 2018 09:37:51 +0200 Message-ID: <20180823073751.GX21634@phenom.ffwll.local> References: <20180703160354.59955-1-noralf@tronnes.org> <20180703160354.59955-5-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Stultz Cc: David Lechner , Xinliang Liu , Intel Graphics Development , dri-devel , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjIsIDIwMTggYXQgMTE6MjE6MTFQTSAtMDcwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gV2VkLCBBdWcgMjIsIDIwMTggYXQgMTA6NTEgUE0sIERhbmllbCBWZXR0ZXIgPGRh bmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiBPbiBUaHUsIEF1ZyAyMywgMjAxOCBhdCA2OjE0IEFN LCBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPj4gT24gTW9u LCBBdWcgMjAsIDIwMTggYXQgMTE6NDQgUE0sIEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5h cm8ub3JnPiB3cm90ZToKPiA+Pj4gSGV5IE5vcmFsZiwgYWxsLAo+ID4+PiAgIEkndmUgYmVlbiBk aWdnaW5nIGZvciBhIGJpdCBvbiB0aGUgcmVncmVzc2lvbiB0aGF0IHRoaXMgcGF0Y2ggaGFzCj4g Pj4+IHRyaXBwZWQgb24gdGhlIEhpS2V5IGJvYXJkIGFzIHJlcG9ydGVkIGhlcmU6Cj4gPj4+IGh0 dHBzOi8vbGttbC5vcmcvbGttbC8yMDE4LzgvMTYvODEKPiA+Pj4KPiA+Pj4gVGhlIGZpcnN0IGlz c3VlIHdhcyB0aGF0IHRoZSBraXJpbiBkcml2ZXIgd2FzIHNldHRpbmcKPiA+Pj4gbW9kZV9jb25m aWcubWF4X3dpZHRoL2hlaWdodCA9IDIwNDgsIHdoaWNoIHdhcyBjYXVzaW5nIGVycm9ycyBhcyB0 aGUKPiA+Pj4gdGhlIHJlcXVlc3RlZCByZXNvbHV0aW9uIHdhcyAxOTIweDIxNjAgKGR1ZSB0byBz dXJmYWNlZmxpbmdlcgo+ID4+PiByZXF1ZXN0aW5nIHkqMiBmb3IgcGFnZSBmbGlwcGluZykuCj4g Pj4KPiA+PiBIZXkgTm9yYWxmLAo+ID4+ICAgU29ycnksIEkga25vdyB5b3VyIHByb2JhYmx5IHNp Y2sgb2YgbWUuIEJ1dCBJIGp1c3Qgd2FudGVkIHRvIGNpcmNsZQo+ID4+IGFyb3VuZCBvbiB0aGlz IGxpdHRsZSBiaXQuIFNvIHBhcnQgb2YgdGhlIGlzc3VlIEkgZm91bmQgZWFybGllciwgd2FzCj4g Pj4gdGhhdCBJJ20gcnVubmluZyB3LyBDT05GSUdfRFJNX0ZCREVWX09WRVJBTExPQz0yMDAsIHRv IHN1cHBvcnQKPiA+PiBTdXJmYWNlZmxpbmdlcidzIHJlcXVlc3QgZm9yIHBhZ2UgZmxpcHBpbmcu IFRoaXMgaXMgd2hhdCBtYWtlcyB0aGUgWQo+ID4+IHJlc29sdXRpb24gMjE2MCwgd2hpY2ggcnVu cyBhZm91bCBvZiB0aGUgbmV3IG1heF9oZWlnaHQgY2hlY2sgb2YgMjA0OAo+ID4+IGluIHRoZSBn ZW5lcmljIGNvZGUuCj4gPj4KPiA+PiBJIHdhcyBjaGVja2luZyB3aXRoIFhpbmxpYW5nLCB3aG8g a25vdyB0aGUga2lyaW4gZGlzcGxheSBoYXJkd2FyZSwKPiA+PiBhYm91dCB0aGUgbWF4X2hlaWdo dCBiZWluZyBzZXQgdG8gMjA0OCB0byBlbnN1cmUgYnVtcGluZyBpdCB1cCB3YXNuJ3QKPiA+PiBh IHByb2JsZW0sIGJ1dCBoZSBzYWlkIDIwNDh4MjA0OCAgd2FzIHVuZm9ydHVuYXRlbHkgbm90IGFy Yml0cmFyeSwgYW5kCj4gPj4gdGhhdCB3YXMgdGhlIGhhcmQgbGltaXQgb2YgdGhlIGRpc3BsYXkg aGFyZHdhcmUuIEhvd2V2ZXIsIHdpdGgKPiA+PiBvdmVyYWxsb2MsIHRoZSAxOTIweDIxNjAgcmVz IGZiZGV2IHNob3VsZCBzdGlsbCBiZSBvaywgYXMgb25seQo+ID4+IDE5MjB4MTA4MCBpcyBhY3R1 YWxseSBkaXNwbGF5ZWQgYXQgb25lIHRpbWUuCj4gPj4KPiA+PiBTbyBpdCBzZWVtcyBsaWtlIHdl IG1pZ2h0IG5lZWQgdG8gbXVsdGlwbHkgdGhlIG1heF9oZWlnaHQgYnkgdGhlCj4gPj4gb3ZlcmFs bG9jIGZhY3RvciB3aGVuIHdlIGFyZSBjaGVja2luZyBpdCBpbgo+ID4+IGRybV9pbnRlcm5hbF9m cmFtZWJ1ZmZlcl9jcmVhdGU/Cj4gPj4KPiA+PiBEb2VzIHRoYXQgYXBwcm9hY2ggc291bmQgc2Fu ZSwgb3Igd291bGQgZm9sa3MgcHJlZmVyIHNvbWV0aGluZyBkaWZmZXJlbnQ/Cj4gPgo+ID4gSSBn dWVzcyB3ZSBjb3VsZCBzaW1wbHkgbm90IGNoZWNrIGFnYWluc3QgdGhlIGhlaWdodCBsaW1pdCB3 aGVuCj4gPiBhbGxvY2F0aW5nIGZyYW1lYnVmZmVycy4gQnV0IHdlJ3ZlIGRvbmUgdGhhdCBmb3Ig dXNlcnNwYWNlIGJ1ZmZlcnMKPiA+IHNpbmNlIGZvcmV2ZXIgKHRoZXkganVzdCBhbGxvY2F0ZSAy IGJ1ZmZlcnMgZm9yIHBhZ2UtZmxpcHBpbmcpLCBzbyBJCj4gPiBoYXZlIG5vIGlkZWEgd2hhdCB3 b3VsZCBhbGwgYnJlYWsgaWYgd2UnZCBzdWRkZW5seSBsaWZ0IHRoaXMKPiA+IHJlc3RyaWN0aW9u LiBBbmQgd2hldGhlciB3ZSdkIGxpZnQgaXQgZm9yIGZiZGV2IG9ubHkgb3IgZm9yIGV2ZXJ5b25l Cj4gPiBkb2Vzbid0IHJlYWxseSBtYWtlIG11Y2ggb2YgYSBkaWZmZXJlbmNlLCBzaW5jZSBlaXRo ZXIgdGhpcyB3b3Jrcywgb3IKPiA+IGl0IGRvZXNuJ3QgKGFjcm9zcyBhbGwgY2hpcHMpLgo+IAo+ IFRoYXQgZmVlbHMgYSBiaXQgbW9yZSByaXNreSB0aGVuIHdoYXQgSSB3YXMgdGhpbmtpbmcuICBX aGF0IGFib3V0Cj4gc29tZXRoaW5nIGxpa2UgKGFwb2xvZ2llcywgd2hpdGVzcGFjZSBjb3JydXB0 ZWQpCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gaW5kZXggZmU3ZTU0NS4uMDQyNGE3MSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IEBAIC0xODEwLDYgKzE4MTAsNyBAQCBzdGF0 aWMgaW50IGRybV9mYl9oZWxwZXJfc2luZ2xlX2ZiX3Byb2JlKHN0cnVjdAo+IGRybV9mYl9oZWxw ZXIgKmZiX2hlbHBlciwKPiAgICAgICAgIGludCBpOwo+ICAgICAgICAgc3RydWN0IGRybV9mYl9o ZWxwZXJfc3VyZmFjZV9zaXplIHNpemVzOwo+ICAgICAgICAgaW50IGdhbW1hX3NpemUgPSAwOwo+ ICsgICAgICAgc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnOwo+IAo+ICAgICAgICAgbWVt c2V0KCZzaXplcywgMCwgc2l6ZW9mKHN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZhY2Vfc2l6ZSkp Owo+ICAgICAgICAgc2l6ZXMuc3VyZmFjZV9kZXB0aCA9IDI0Owo+IEBAIC0xOTEwLDYgKzE5MTEs MTEgQEAgc3RhdGljIGludCBkcm1fZmJfaGVscGVyX3NpbmdsZV9mYl9wcm9iZShzdHJ1Y3QKPiBk cm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gICAgICAgICBzaXplcy5zdXJmYWNlX2hlaWdodCAq PSBkcm1fZmJkZXZfb3ZlcmFsbG9jOwo+ICAgICAgICAgc2l6ZXMuc3VyZmFjZV9oZWlnaHQgLz0g MTAwOwo+IAo+ICsgICAgICAgY29uZmlnID0gJmZiX2hlbHBlci0+Y2xpZW50LmRldi0+bW9kZV9j b25maWc7Cj4gKyAgICAgICBjb25maWctPm1heF9oZWlnaHQgKj0gZHJtX2ZiZGV2X292ZXJhbGxv YzsKPiArICAgICAgIGNvbmZpZy0+bWF4X2hlaWdodCAvPSAxMDA7Cj4gKwo+ICsKPiAgICAgICAg IC8qIHB1c2ggZG93biBpbnRvIGRyaXZlcnMgKi8KPiAgICAgICAgIHJldCA9ICgqZmJfaGVscGVy LT5mdW5jcy0+ZmJfcHJvYmUpKGZiX2hlbHBlciwgJnNpemVzKTsKPiAgICAgICAgIGlmIChyZXQg PCAwKQo+IAo+IAo+IFRoYXQgd2F5IGl0IG9ubHkgZWZmZWN0cyB0aGUgZmJkZXYgKyBvdmVyYWxs b2MgY2FzZT8KClN0aWxsIGNoYW5nZXMgaXQgZm9yIGV2ZXJ5b25lLCBub3QganVzdCBmYmRldiwg aWYgeW91IGVuYWJsZSBvdmVyYWxsb2MuCllvdSdkIG5lZWQgdG8gcmVzZXQuCgpBbm90aGVyLCBj bGVhbmVyIHdheSB0byBmaXggdGhpcyB3b3VsZCBiZSB0byBvdmVyYWxsb2NhdGUgdGhlIGJ1ZmZl ciwgYnV0CmhhdmUgdGhlIGRybV9mcmFtZWJ1ZmZlciBsaW1pdGVkLiBCdXQgdGhhdCBtZWFucyB3 ZSBuZWVkIHRvIGNoYW5nZSB0aGUKZmJkZXYgc2Nyb2xsaW5nIGxvZ2ljLiBBbmQgdGhlIGVudGly ZSBpbnRlcmZhY2UgYmV0d2VlbiBmYmRldiBoZWxwZXJzIGFuZApkcml2ZXJzIG5lZWRzIGEgcmV3 b3JrLCBzaW5jZSBhdG0gdGhlIGRyaXZlciBhbGxvY2F0ZXMgdGhlIGRybV9mcmFtZWJ1ZmZlcgpm b3IgeW91LiBUaGF0J3Mgd2hhdCB1c2Vyc3BhY2UgY2FuL3dpbGwgZG8gaW4gdGhpcyBjYXNlIEkg Z3Vlc3MuIEhhcyBhbGwKdGhlIGlzc3VlcyBvZiBzY3JvbGxpbmcgYnkgbW92aW5nIHRoZSBkcm1f ZmIgd2l0aG91dCBodyBrbm93bGVkZ2UuCgpJIGd1ZXNzIG1heWJlIGp1c3QgZHJvcHBpbmcgdGhl IG1heF9oZWlnaHQgY2hlY2sgaW4gZmJkZXYgaXMgb2ssIGlmIHdlIHB1dAphIHJlYWxseSBiaWcg Y29tbWVudC9GSVhNRSB0aGVyZS4gT3IgbWF5YmUgbWFrZSBpdCBjb25kaXRpb25hbCBvbgpmYmRl dl9vdmVyYWxsb2MgYmVpbmcgYXQgdGhlIGRlZmF1bHQgdmFsdWUsIHRoYXQnZCBwcm9iYWJseSBi ZSBiZXR0ZXIKZXZlbi4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==