From: Huang Rui Subject: Re: [PATCH 10/11] drm/amdgpu: add helper for VM PD/PT allocation parameters Date: Thu, 23 Aug 2018 20:46:10 +0800 Message-ID: <20180823124609.GB5167@hr-amur2> References: <20180822150517.2330-1-christian.koenig@amd.com> <20180822150517.2330-10-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180822150517.2330-10-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gV2VkLCBBdWcgMjIsIDIwMTggYXQgMDU6MDU6MTZQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBZGQgYSBoZWxwZXIgZnVuY3Rpb24gdG8gZmlndXJlIHRoZW0gb3V0IG9ubHkg b25jZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29l bmlnQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogSHVhbmcgUnVpIDxyYXkuaHVhbmdAYW1kLmNvbT4K Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIHwgNjEgKysr KysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMo KyksIDMzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92 bS5jCj4gaW5kZXggODdlM2Q0NGIwYTNmLi45MjhmZGFlMGRhYjQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IEBAIC00NDYsNiArNDQ2LDMxIEBAIHN0YXRpYyBp bnQgYW1kZ3B1X3ZtX2NsZWFyX2JvKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAJcmV0 dXJuIHI7Cj4gIH0KPiAgCj4gKy8qKgo+ICsgKiBhbWRncHVfdm1fYm9fcGFyYW0gLSBmaWxsIGlu IHBhcmFtZXRlcnMgZm9yIFBEL1BUIGFsbG9jYXRpb24KPiArICoKPiArICogQGFkZXY6IGFtZGdw dV9kZXZpY2UgcG9pbnRlcgo+ICsgKiBAdm06IHJlcXVlc3Rpbmcgdm0KPiArICogQGJwOiByZXN1 bHRpbmcgQk8gYWxsb2NhdGlvbiBwYXJhbWV0ZXJzCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCBhbWRn cHVfdm1fYm9fcGFyYW0oc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCBhbWRncHVf dm0gKnZtLAo+ICsJCQkgICAgICAgaW50IGxldmVsLCBzdHJ1Y3QgYW1kZ3B1X2JvX3BhcmFtICpi cCkKPiArewo+ICsJbWVtc2V0KCZicCwgMCwgc2l6ZW9mKGJwKSk7Cj4gKwo+ICsJYnAtPnNpemUg PSBhbWRncHVfdm1fYm9fc2l6ZShhZGV2LCBsZXZlbCk7Cj4gKwlicC0+Ynl0ZV9hbGlnbiA9IEFN REdQVV9HUFVfUEFHRV9TSVpFOwo+ICsJYnAtPmRvbWFpbiA9IEFNREdQVV9HRU1fRE9NQUlOX1ZS QU07Cj4gKwlicC0+ZmxhZ3MgPSBBTURHUFVfR0VNX0NSRUFURV9WUkFNX0NPTlRJR1VPVVM7Cj4g KwlpZiAodm0tPnVzZV9jcHVfZm9yX3VwZGF0ZSkKPiArCQlicC0+ZmxhZ3MgfD0gQU1ER1BVX0dF TV9DUkVBVEVfQ1BVX0FDQ0VTU19SRVFVSVJFRDsKPiArCWVsc2UKPiArCQlicC0+ZmxhZ3MgfD0g QU1ER1BVX0dFTV9DUkVBVEVfU0hBRE9XOwo+ICsJYnAtPnR5cGUgPSB0dG1fYm9fdHlwZV9rZXJu ZWw7Cj4gKwlpZiAodm0tPnJvb3QuYmFzZS5ibykKPiArCQlicC0+cmVzdiA9IHZtLT5yb290LmJh c2UuYm8tPnRiby5yZXN2Owo+ICt9Cj4gKwo+ICAvKioKPiAgICogYW1kZ3B1X3ZtX2FsbG9jX2xl dmVscyAtIGFsbG9jYXRlIHRoZSBQRC9QVCBsZXZlbHMKPiAgICoKPiBAQCAtNDY5LDggKzQ5NCw4 IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqYWRldiwKPiAgCQkJCSAgdW5zaWduZWQgbGV2ZWwsIGJvb2wgYXRzKQo+ICB7Cj4gIAl1bnNp Z25lZCBzaGlmdCA9IGFtZGdwdV92bV9sZXZlbF9zaGlmdChhZGV2LCBsZXZlbCk7Cj4gKwlzdHJ1 Y3QgYW1kZ3B1X2JvX3BhcmFtIGJwOwo+ICAJdW5zaWduZWQgcHRfaWR4LCBmcm9tLCB0bzsKPiAt CXU2NCBmbGFnczsKPiAgCWludCByOwo+ICAKPiAgCWlmICghcGFyZW50LT5lbnRyaWVzKSB7Cj4g QEAgLTQ5NCwyOSArNTE5LDE0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCXNhZGRyID0gc2FkZHIgJiAoKDEgPDwgc2hp ZnQpIC0gMSk7Cj4gIAllYWRkciA9IGVhZGRyICYgKCgxIDw8IHNoaWZ0KSAtIDEpOwo+ICAKPiAt CWZsYWdzID0gQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DT05USUdVT1VTOwo+IC0JaWYgKHZtLT51 c2VfY3B1X2Zvcl91cGRhdGUpCj4gLQkJZmxhZ3MgfD0gQU1ER1BVX0dFTV9DUkVBVEVfQ1BVX0FD Q0VTU19SRVFVSVJFRDsKPiAtCWVsc2UKPiAtCQlmbGFncyB8PSAoQU1ER1BVX0dFTV9DUkVBVEVf Tk9fQ1BVX0FDQ0VTUyB8Cj4gLQkJCQlBTURHUFVfR0VNX0NSRUFURV9TSEFET1cpOwo+ICsJYW1k Z3B1X3ZtX2JvX3BhcmFtKGFkZXYsIHZtLCBsZXZlbCwgJmJwKTsKPiAgCj4gIAkvKiB3YWxrIG92 ZXIgdGhlIGFkZHJlc3Mgc3BhY2UgYW5kIGFsbG9jYXRlIHRoZSBwYWdlIHRhYmxlcyAqLwo+ICAJ Zm9yIChwdF9pZHggPSBmcm9tOyBwdF9pZHggPD0gdG87ICsrcHRfaWR4KSB7Cj4gLQkJc3RydWN0 IHJlc2VydmF0aW9uX29iamVjdCAqcmVzdiA9IHZtLT5yb290LmJhc2UuYm8tPnRiby5yZXN2Owo+ ICAJCXN0cnVjdCBhbWRncHVfdm1fcHQgKmVudHJ5ID0gJnBhcmVudC0+ZW50cmllc1twdF9pZHhd Owo+ICAJCXN0cnVjdCBhbWRncHVfYm8gKnB0Owo+ICAKPiAgCQlpZiAoIWVudHJ5LT5iYXNlLmJv KSB7Cj4gLQkJCXN0cnVjdCBhbWRncHVfYm9fcGFyYW0gYnA7Cj4gLQo+IC0JCQltZW1zZXQoJmJw LCAwLCBzaXplb2YoYnApKTsKPiAtCQkJYnAuc2l6ZSA9IGFtZGdwdV92bV9ib19zaXplKGFkZXYs IGxldmVsKTsKPiAtCQkJYnAuYnl0ZV9hbGlnbiA9IEFNREdQVV9HUFVfUEFHRV9TSVpFOwo+IC0J CQlicC5kb21haW4gPSBBTURHUFVfR0VNX0RPTUFJTl9WUkFNOwo+IC0JCQlicC5mbGFncyA9IGZs YWdzOwo+IC0JCQlicC50eXBlID0gdHRtX2JvX3R5cGVfa2VybmVsOwo+IC0JCQlicC5yZXN2ID0g cmVzdjsKPiAgCQkJciA9IGFtZGdwdV9ib19jcmVhdGUoYWRldiwgJmJwLCAmcHQpOwo+ICAJCQlp ZiAocikKPiAgCQkJCXJldHVybiByOwo+IEBAIC0yNTY0LDggKzI1NzQsNiBAQCBpbnQgYW1kZ3B1 X3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfdm0gKnZt LAo+ICB7Cj4gIAlzdHJ1Y3QgYW1kZ3B1X2JvX3BhcmFtIGJwOwo+ICAJc3RydWN0IGFtZGdwdV9i byAqcm9vdDsKPiAtCXVuc2lnbmVkIGxvbmcgc2l6ZTsKPiAtCXVpbnQ2NF90IGZsYWdzOwo+ICAJ aW50IHIsIGk7Cj4gIAo+ICAJdm0tPnZhID0gUkJfUk9PVF9DQUNIRUQ7Cj4gQEAgLTI2MDIsMjAg KzI2MTAsNyBAQCBpbnQgYW1kZ3B1X3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYs IHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ICAJCSAgIkNQVSB1cGRhdGUgb2YgVk0gcmVjb21tZW5k ZWQgb25seSBmb3IgbGFyZ2UgQkFSIHN5c3RlbVxuIik7Cj4gIAl2bS0+bGFzdF91cGRhdGUgPSBO VUxMOwo+ICAKPiAtCWZsYWdzID0gQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DT05USUdVT1VTOwo+ IC0JaWYgKHZtLT51c2VfY3B1X2Zvcl91cGRhdGUpCj4gLQkJZmxhZ3MgfD0gQU1ER1BVX0dFTV9D UkVBVEVfQ1BVX0FDQ0VTU19SRVFVSVJFRDsKPiAtCWVsc2UKPiAtCQlmbGFncyB8PSBBTURHUFVf R0VNX0NSRUFURV9TSEFET1c7Cj4gLQo+IC0Jc2l6ZSA9IGFtZGdwdV92bV9ib19zaXplKGFkZXYs IGFkZXYtPnZtX21hbmFnZXIucm9vdF9sZXZlbCk7Cj4gLQltZW1zZXQoJmJwLCAwLCBzaXplb2Yo YnApKTsKPiAtCWJwLnNpemUgPSBzaXplOwo+IC0JYnAuYnl0ZV9hbGlnbiA9IEFNREdQVV9HUFVf UEFHRV9TSVpFOwo+IC0JYnAuZG9tYWluID0gQU1ER1BVX0dFTV9ET01BSU5fVlJBTTsKPiAtCWJw LmZsYWdzID0gZmxhZ3M7Cj4gLQlicC50eXBlID0gdHRtX2JvX3R5cGVfa2VybmVsOwo+IC0JYnAu cmVzdiA9IE5VTEw7Cj4gKwlhbWRncHVfdm1fYm9fcGFyYW0oYWRldiwgdm0sIGFkZXYtPnZtX21h bmFnZXIucm9vdF9sZXZlbCwgJmJwKTsKPiAgCXIgPSBhbWRncHVfYm9fY3JlYXRlKGFkZXYsICZi cCwgJnJvb3QpOwo+ICAJaWYgKHIpCj4gIAkJZ290byBlcnJvcl9mcmVlX3NjaGVkX2VudGl0eTsK PiAtLSAKPiAyLjE3LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K YW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==