Return-Path: Received: from mx2.suse.de ([195.135.220.15]:41136 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725991AbeICRlB (ORCPT ); Mon, 3 Sep 2018 13:41:01 -0400 Date: Mon, 3 Sep 2018 15:20:51 +0200 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , Marko Rauhamaa , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 0/3] fanotify super block marks Message-ID: <20180903132051.GI10027@quack2.suse.cz> References: <20180901074113.32296-1-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180901074113.32296-1-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Amir! On Sat 01-09-18 10:41:10, Amir Goldstein wrote: > The following patches implement the new mark type FAN_MARK_FILESYSTEM > to enable monitoring of filesystem events on all filesystem objects > regardless of the mount where event was generated. > > These patches are available on my github [1] along with LTP tests [2] > and man-pages update [3]. Thanks for the patches! I've queued them up to my tree for the next merge window (will publish them as soon as LTP tests are finished). I've just fixed a typo in comment in patch 3 and added comments into holes in flags space in fanotify.h header. Honza > [1] https://github.com/amir73il/linux/commits/fanotify_sb > [2] https://github.com/amir73il/ltp/commits/fanotify_sb > [3] https://github.com/amir73il/man-pages/commits/fanotify_sb > > Changes since v3: > - Rebase on top of ignore mask fix patch > - Address "semantic" review comments on FAN_MARK_FILESYSTEM flag > > Changes since v2: > - Rebased on top of merged cleanup patches > - Show super block marks in fanotify_fdinfo() > - Add man pages patch [3] > > Amir Goldstein (3): > fsnotify: add super block object type > fsnotify: send path type events to group with super block marks > fanotify: add API to attach/detach super block mark > > fs/notify/fanotify/fanotify_user.c | 37 ++++++++++++++++++++++++++---- > fs/notify/fdinfo.c | 5 ++++ > fs/notify/fsnotify.c | 32 +++++++++++++++++--------- > fs/notify/fsnotify.h | 11 +++++++++ > fs/notify/mark.c | 4 ++++ > fs/super.c | 2 +- > include/linux/fs.h | 5 ++++ > include/linux/fsnotify_backend.h | 17 +++++++++++--- > include/uapi/linux/fanotify.h | 7 +++++- > 9 files changed, 99 insertions(+), 21 deletions(-) > > -- > 2.17.1 > -- Jan Kara SUSE Labs, CR