From: Andrew Lunn Subject: Re: [PATCH net-next] net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES Date: Thu, 6 Sep 2018 21:55:47 +0200 Message-ID: <20180906195547.GC26997@lunn.ch> References: <20180906184245.31442-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Vivien Didelot , "David S. Miller" , open list To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: <20180906184245.31442-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Sep 06, 2018 at 11:42:45AM -0700, Florian Fainelli wrote: > In case B53_SRAB is enabled, but not B53_SERDES, we can get the > following linking error: > > ERROR: "b53_serdes_init" [drivers/net/dsa/b53/b53_srab.ko] undefined! > > We also need to ifdef the body of b53_srab_serdes_map_lane() since it > would not be used when B53_SERDES is disabled and that would produce a > warning. > > Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support") > Reported-by: kbuild test robot > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew