From: Peter Wu Subject: [PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings Date: Fri, 7 Sep 2018 00:18:10 +0200 Message-ID: <20180906221810.20170-5-peter@lekensteyn.nl> References: <20180906221810.20170-1-peter@lekensteyn.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.lekensteyn.nl (mail.lekensteyn.nl [IPv6:2a02:2308::360:1:25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D20F6E781 for ; Thu, 6 Sep 2018 22:18:18 +0000 (UTC) In-Reply-To: <20180906221810.20170-1-peter@lekensteyn.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Q2xhcmlmeSB0aGUgcmVsYXRpb24gYmV0d2VlbiBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwL3Rl YXJkb3duLiBDbGFyaWZ5CnJlcXVpcmVtZW50cyBmb3IgdGhlIG5ldyBnZW5lcmljIGZiZGV2IGVt dWxhdGlvbiBBUEkgYW5kIGxvZyBzb21lIG1vcmUKZGV0YWlscyBpbiBjYXNlIHRoZSBkcml2ZXIg ZG9lcyBzb21ldGhpbmcgd3JvbmcuIEZpeCByZWxhdGVkIHR5cG9zLgoKQ2M6IE5vcmFsZiBUcsO4 bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgpTaWduZWQtb2ZmLWJ5OiBQZXRlciBXdSA8cGV0ZXJA bGVrZW5zdGV5bi5ubD4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgMjUg KysrKysrKysrKysrKysrKysrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMo KyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9o ZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKaW5kZXggNGIwZGQyMGJj Y2I4Li43ZjkyZmYxNzM5ODYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVs cGVyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwpAQCAtMjgyMSw3ICsy ODIxLDkgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQpOwogICog VGhlIGNhbGxlciBtdXN0IHRvIHByb3ZpZGUgYSAmZHJtX2ZiX2hlbHBlcl9mdW5jcy0+ZmJfcHJv YmUgY2FsbGJhY2sKICAqIGZ1bmN0aW9uLgogICoKLSAqIFNlZSBhbHNvOiBkcm1fZmJfaGVscGVy X2luaXRpYWxfY29uZmlnKCkKKyAqIFVzZSBkcm1fZmJfaGVscGVyX2ZiZGV2X3RlYXJkb3duKCkg dG8gZGVzdHJveSB0aGUgZmJkZXYuCisgKgorICogU2VlIGFsc286IGRybV9mYl9oZWxwZXJfaW5p dGlhbF9jb25maWcoKSwgZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoKS4KICAqCiAgKiBSZXR1cm5z OgogICogWmVybyBvbiBzdWNjZXNzIG9yIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4K QEAgLTMwMzcsNyArMzAzOSw3IEBAIHN0YXRpYyBzdHJ1Y3QgZmJfZGVmZXJyZWRfaW8gZHJtX2Zi ZGV2X2RlZmlvID0gewogICogQGZiX2hlbHBlcjogZmJkZXYgaGVscGVyIHN0cnVjdHVyZQogICog QHNpemVzOiBkZXNjcmliZXMgZmJkZXYgc2l6ZSBhbmQgc2Nhbm91dCBzdXJmYWNlIHNpemUKICAq Ci0gKiBUaGlzIGZ1bmN0aW9uIHVzZXMgdGhlIGNsaWVudCBBUEkgdG8gY3JhdGUgYSBmcmFtZWJ1 ZmZlciBiYWNrZWQgYnkgYSBkdW1iIGJ1ZmZlci4KKyAqIFRoaXMgZnVuY3Rpb24gdXNlcyB0aGUg Y2xpZW50IEFQSSB0byBjcmVhdGUgYSBmcmFtZWJ1ZmZlciBiYWNrZWQgYnkgYSBkdW1iIGJ1ZmZl ci4KICAqCiAgKiBUaGUgX3N5c18gdmVyc2lvbnMgYXJlIHVzZWQgZm9yICZmYl9vcHMuZmJfcmVh ZCwgZmJfd3JpdGUsIGZiX2ZpbGxyZWN0LAogICogZmJfY29weWFyZWEsIGZiX2ltYWdlYmxpdC4K QEAgLTMxNjUsOCArMzE2NywxMCBAQCBzdGF0aWMgaW50IGRybV9mYmRldl9jbGllbnRfaG90cGx1 ZyhzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCkKIAlpZiAoZGV2LT5mYl9oZWxwZXIpCiAJ CXJldHVybiBkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQoZGV2LT5mYl9oZWxwZXIpOwogCi0J aWYgKCFkZXYtPm1vZGVfY29uZmlnLm51bV9jb25uZWN0b3IpCisJaWYgKCFkZXYtPm1vZGVfY29u ZmlnLm51bV9jb25uZWN0b3IpIHsKKwkJRFJNX0RFVl9ERUJVRyhkZXYtPmRldiwgIk5vIGNvbm5l Y3RvcnMgZm91bmQsIHdpbGwgbm90IGNyZWF0ZSBmcmFtZWJ1ZmZlciFcbiIpOwogCQlyZXR1cm4g MDsKKwl9CiAKIAlyZXQgPSBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwKGRldiwgZmJfaGVscGVy LCAmZHJtX2ZiX2hlbHBlcl9nZW5lcmljX2Z1bmNzLAogCQkJCQlmYl9oZWxwZXItPnByZWZlcnJl ZF9icHAsIDApOwpAQCAtMzE4NywxMyArMzE5MSwxNSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRy bV9jbGllbnRfZnVuY3MgZHJtX2ZiZGV2X2NsaWVudF9mdW5jcyA9IHsKIH07CiAKIC8qKgotICog ZHJtX2ZiX2hlbHBlcl9nZW5lcmljX2ZiZGV2X3NldHVwKCkgLSBTZXR1cCBnZW5lcmljIGZiZGV2 IGVtdWxhdGlvbgorICogZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoKSAtIFNldHVwIGdlbmVyaWMg ZmJkZXYgZW11bGF0aW9uCiAgKiBAZGV2OiBEUk0gZGV2aWNlCiAgKiBAcHJlZmVycmVkX2JwcDog UHJlZmVycmVkIGJpdHMgcGVyIHBpeGVsIGZvciB0aGUgZGV2aWNlLgogICogICAgICAgICAgICAg ICAgIEBkZXYtPm1vZGVfY29uZmlnLnByZWZlcnJlZF9kZXB0aCBpcyB1c2VkIGlmIHRoaXMgaXMg emVyby4KICAqCiAgKiBUaGlzIGZ1bmN0aW9uIHNldHMgdXAgZ2VuZXJpYyBmYmRldiBlbXVsYXRp b24gZm9yIGRyaXZlcnMgdGhhdCBzdXBwb3J0cwotICogZHVtYiBidWZmZXJzIHdpdGggYSB2aXJ0 dWFsIGFkZHJlc3MgYW5kIHRoYXQgY2FuIGJlIG1tYXAnZWQuCisgKiBkdW1iIGJ1ZmZlcnMgd2l0 aCBhIHZpcnR1YWwgYWRkcmVzcyBhbmQgdGhhdCBjYW4gYmUgbW1hcCdlZC4gSWYgdGhlIGRyaXZl cgorICogZG9lcyBub3Qgc3VwcG9ydCB0aGVzZSBmdW5jdGlvbnMsIGl0IGNvdWxkIHVzZSBkcm1f ZmJfaGVscGVyX2ZiZGV2X3NldHVwKCkuCisgKiBUaGlzIGZ1bmN0aW9uIGNhbiBvbmx5IGJlIHVz ZWQgd2l0aCBkZXZpY2VzIGNyZWF0ZWQgdXNpbmcgZHJtX2Rldl9yZWdpc3RlcigpLgogICoKICAq IFJlc3RvcmUsIGhvdHBsdWcgZXZlbnRzIGFuZCB0ZWFyZG93biBhcmUgYWxsIHRha2VuIGNhcmUg b2YuIERyaXZlcnMgdGhhdCBkbwogICogc3VzcGVuZC9yZXN1bWUgbmVlZCB0byBjYWxsIGRybV9m Yl9oZWxwZXJfc2V0X3N1c3BlbmRfdW5sb2NrZWQoKSB0aGVtc2VsdmVzLgpAQCAtMzIwNiw2ICsz MjEyLDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY2xpZW50X2Z1bmNzIGRybV9mYmRldl9j bGllbnRfZnVuY3MgPSB7CiAgKiBUaGlzIGZ1bmN0aW9uIGlzIHNhZmUgdG8gY2FsbCBldmVuIHdo ZW4gdGhlcmUgYXJlIG5vIGNvbm5lY3RvcnMgcHJlc2VudC4KICAqIFNldHVwIHdpbGwgYmUgcmV0 cmllZCBvbiB0aGUgbmV4dCBob3RwbHVnIGV2ZW50LgogICoKKyAqIFRoZSBmYmRldiBpcyBkZXN0 cm95ZWQgYnkgZHJtX2Rldl91bnJlZ2lzdGVyKCkuCisgKgogICogUmV0dXJuczoKICAqIFplcm8g b24gc3VjY2VzcyBvciBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCiAgKi8KQEAgLTMy MTQsNiArMzIyMiw4IEBAIGludCBkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcHJlZmVycmVkX2JwcCkKIAlzdHJ1Y3QgZHJtX2ZiX2hl bHBlciAqZmJfaGVscGVyOwogCWludCByZXQ7CiAKKwlXQVJOKGRldi0+ZmJfaGVscGVyLCAiZmJf aGVscGVyIGlzIGFscmVhZHkgc2V0IVxuIik7CisKIAlpZiAoIWRybV9mYmRldl9lbXVsYXRpb24p CiAJCXJldHVybiAwOwogCkBAIC0zMjI0LDEyICszMjM0LDE1IEBAIGludCBkcm1fZmJkZXZfZ2Vu ZXJpY19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcHJlZmVycmVk X2JwcCkKIAlyZXQgPSBkcm1fY2xpZW50X25ldyhkZXYsICZmYl9oZWxwZXItPmNsaWVudCwgImZi ZGV2IiwgJmRybV9mYmRldl9jbGllbnRfZnVuY3MpOwogCWlmIChyZXQpIHsKIAkJa2ZyZWUoZmJf aGVscGVyKTsKKwkJRFJNX0RFVl9FUlJPUihkZXYtPmRldiwgIkZhaWxlZCB0byByZWdpc3RlciBj bGllbnQ6ICVkXG4iLCByZXQpOwogCQlyZXR1cm4gcmV0OwogCX0KIAogCWZiX2hlbHBlci0+cHJl ZmVycmVkX2JwcCA9IHByZWZlcnJlZF9icHA7CiAKLQlkcm1fZmJkZXZfY2xpZW50X2hvdHBsdWco JmZiX2hlbHBlci0+Y2xpZW50KTsKKwlyZXQgPSBkcm1fZmJkZXZfY2xpZW50X2hvdHBsdWcoJmZi X2hlbHBlci0+Y2xpZW50KTsKKwlpZiAocmV0KQorCQlEUk1fREVWX0RFQlVHKGRldi0+ZGV2LCAi Y2xpZW50IGhvdHBsdWcgcmV0PSVkXG4iLCByZXQpOwogCiAJcmV0dXJuIDA7CiB9Ci0tIAoyLjE4 LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=