From: Daniel Vetter Subject: Re: [PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings Date: Fri, 7 Sep 2018 21:46:59 +0200 Message-ID: <20180907194659.GC7176@phenom.ffwll.local> References: <20180906221810.20170-1-peter@lekensteyn.nl> <20180906221810.20170-5-peter@lekensteyn.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79BEC6E191 for ; Fri, 7 Sep 2018 19:47:03 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id z27-v6so12316883edb.10 for ; Fri, 07 Sep 2018 12:47:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180906221810.20170-5-peter@lekensteyn.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Wu Cc: Gerd Hoffmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBTZXAgMDcsIDIwMTggYXQgMTI6MTg6MTBBTSArMDIwMCwgUGV0ZXIgV3Ugd3JvdGU6 Cj4gQ2xhcmlmeSB0aGUgcmVsYXRpb24gYmV0d2VlbiBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVw L3RlYXJkb3duLiBDbGFyaWZ5Cj4gcmVxdWlyZW1lbnRzIGZvciB0aGUgbmV3IGdlbmVyaWMgZmJk ZXYgZW11bGF0aW9uIEFQSSBhbmQgbG9nIHNvbWUgbW9yZQo+IGRldGFpbHMgaW4gY2FzZSB0aGUg ZHJpdmVyIGRvZXMgc29tZXRoaW5nIHdyb25nLiBGaXggcmVsYXRlZCB0eXBvcy4KPiAKPiBDYzog Tm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogUGV0 ZXIgV3UgPHBldGVyQGxla2Vuc3RleW4ubmw+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfaGVscGVyLmMgfCAyNSArKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAxOSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9o ZWxwZXIuYwo+IGluZGV4IDRiMGRkMjBiY2NiOC4uN2Y5MmZmMTczOTg2IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTI4MjEsNyArMjgyMSw5IEBAIEVYUE9SVF9TWU1CT0woZHJt X2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KTsKPiAgICogVGhlIGNhbGxlciBtdXN0IHRvIHByb3Zp ZGUgYSAmZHJtX2ZiX2hlbHBlcl9mdW5jcy0+ZmJfcHJvYmUgY2FsbGJhY2sKPiAgICogZnVuY3Rp b24uCj4gICAqCj4gLSAqIFNlZSBhbHNvOiBkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKCkK PiArICogVXNlIGRybV9mYl9oZWxwZXJfZmJkZXZfdGVhcmRvd24oKSB0byBkZXN0cm95IHRoZSBm YmRldi4KPiArICoKPiArICogU2VlIGFsc286IGRybV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWco KSwgZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoKS4KPiAgICoKPiAgICogUmV0dXJuczoKPiAgICog WmVybyBvbiBzdWNjZXNzIG9yIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiBAQCAt MzAzNyw3ICszMDM5LDcgQEAgc3RhdGljIHN0cnVjdCBmYl9kZWZlcnJlZF9pbyBkcm1fZmJkZXZf ZGVmaW8gPSB7Cj4gICAqIEBmYl9oZWxwZXI6IGZiZGV2IGhlbHBlciBzdHJ1Y3R1cmUKPiAgICog QHNpemVzOiBkZXNjcmliZXMgZmJkZXYgc2l6ZSBhbmQgc2Nhbm91dCBzdXJmYWNlIHNpemUKPiAg ICoKPiAtICogVGhpcyBmdW5jdGlvbiB1c2VzIHRoZSBjbGllbnQgQVBJIHRvIGNyYXRlIGEgZnJh bWVidWZmZXIgYmFja2VkIGJ5IGEgZHVtYiBidWZmZXIuCj4gKyAqIFRoaXMgZnVuY3Rpb24gdXNl cyB0aGUgY2xpZW50IEFQSSB0byBjcmVhdGUgYSBmcmFtZWJ1ZmZlciBiYWNrZWQgYnkgYSBkdW1i IGJ1ZmZlci4KPiAgICoKPiAgICogVGhlIF9zeXNfIHZlcnNpb25zIGFyZSB1c2VkIGZvciAmZmJf b3BzLmZiX3JlYWQsIGZiX3dyaXRlLCBmYl9maWxscmVjdCwKPiAgICogZmJfY29weWFyZWEsIGZi X2ltYWdlYmxpdC4KPiBAQCAtMzE2NSw4ICszMTY3LDEwIEBAIHN0YXRpYyBpbnQgZHJtX2ZiZGV2 X2NsaWVudF9ob3RwbHVnKHN0cnVjdCBkcm1fY2xpZW50X2RldiAqY2xpZW50KQo+ICAJaWYgKGRl di0+ZmJfaGVscGVyKQo+ICAJCXJldHVybiBkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQoZGV2 LT5mYl9oZWxwZXIpOwo+ICAKPiAtCWlmICghZGV2LT5tb2RlX2NvbmZpZy5udW1fY29ubmVjdG9y KQo+ICsJaWYgKCFkZXYtPm1vZGVfY29uZmlnLm51bV9jb25uZWN0b3IpIHsKPiArCQlEUk1fREVW X0RFQlVHKGRldi0+ZGV2LCAiTm8gY29ubmVjdG9ycyBmb3VuZCwgd2lsbCBub3QgY3JlYXRlIGZy YW1lYnVmZmVyIVxuIik7Cj4gIAkJcmV0dXJuIDA7Cj4gKwl9Cj4gIAo+ICAJcmV0ID0gZHJtX2Zi X2hlbHBlcl9mYmRldl9zZXR1cChkZXYsIGZiX2hlbHBlciwgJmRybV9mYl9oZWxwZXJfZ2VuZXJp Y19mdW5jcywKPiAgCQkJCQlmYl9oZWxwZXItPnByZWZlcnJlZF9icHAsIDApOwo+IEBAIC0zMTg3 LDEzICszMTkxLDE1IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2NsaWVudF9mdW5jcyBkcm1f ZmJkZXZfY2xpZW50X2Z1bmNzID0gewo+ICB9Owo+ICAKPiAgLyoqCj4gLSAqIGRybV9mYl9oZWxw ZXJfZ2VuZXJpY19mYmRldl9zZXR1cCgpIC0gU2V0dXAgZ2VuZXJpYyBmYmRldiBlbXVsYXRpb24K PiArICogZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoKSAtIFNldHVwIGdlbmVyaWMgZmJkZXYgZW11 bGF0aW9uCgpIbSwgZHJtX2ZiX2hlbHBlcl8gd291bGQgYmUgdGhlIE9DRCBwcmVmaXggd2UgdXNl IGV2ZXJ5d2hlcmUsIGJ1dCBiZXR0ZXIKdG8gbWFrZSB0aGUgZG9jcyBtYXRjaCB0aGUgY29kZS4g RmVlbCBmcmVlIHRvIHRocm93IGEgcmVuYW1lIHBhdGNoIG9uIHRvcC4KCj4gICAqIEBkZXY6IERS TSBkZXZpY2UKPiAgICogQHByZWZlcnJlZF9icHA6IFByZWZlcnJlZCBiaXRzIHBlciBwaXhlbCBm b3IgdGhlIGRldmljZS4KPiAgICogICAgICAgICAgICAgICAgIEBkZXYtPm1vZGVfY29uZmlnLnBy ZWZlcnJlZF9kZXB0aCBpcyB1c2VkIGlmIHRoaXMgaXMgemVyby4KPiAgICoKPiAgICogVGhpcyBm dW5jdGlvbiBzZXRzIHVwIGdlbmVyaWMgZmJkZXYgZW11bGF0aW9uIGZvciBkcml2ZXJzIHRoYXQg c3VwcG9ydHMKPiAtICogZHVtYiBidWZmZXJzIHdpdGggYSB2aXJ0dWFsIGFkZHJlc3MgYW5kIHRo YXQgY2FuIGJlIG1tYXAnZWQuCj4gKyAqIGR1bWIgYnVmZmVycyB3aXRoIGEgdmlydHVhbCBhZGRy ZXNzIGFuZCB0aGF0IGNhbiBiZSBtbWFwJ2VkLiBJZiB0aGUgZHJpdmVyCj4gKyAqIGRvZXMgbm90 IHN1cHBvcnQgdGhlc2UgZnVuY3Rpb25zLCBpdCBjb3VsZCB1c2UgZHJtX2ZiX2hlbHBlcl9mYmRl dl9zZXR1cCgpLgo+ICsgKiBUaGlzIGZ1bmN0aW9uIGNhbiBvbmx5IGJlIHVzZWQgd2l0aCBkZXZp Y2VzIGNyZWF0ZWQgdXNpbmcgZHJtX2Rldl9yZWdpc3RlcigpLgoKVGhpcyBsYXN0IGxpbmUgaXMg bWlzbGVhZGluZywgc2luY2UgZXZlcnkgZHJtIGRldmljZSBpcyBjYWxsZWQgd2l0aApkcm1fZGV2 X3JlZ2lzdGVyKCkuIEl0J3MganVzdCBub3QgYWxsIGNhbGxlZCBieSBkcml2ZXIgY29kZSBkaXJl Y3RseS4KV2l0aCB0aGlzIGxpbmUgcmVtb3ZlZDoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKSSdsbCBsZWF2ZSBpdCB0byBHZXJkIHRvIGFwcGx5 IHRoaXMgYWxsLgotRGFuaWVsCgoKPiAgICoKPiAgICogUmVzdG9yZSwgaG90cGx1ZyBldmVudHMg YW5kIHRlYXJkb3duIGFyZSBhbGwgdGFrZW4gY2FyZSBvZi4gRHJpdmVycyB0aGF0IGRvCj4gICAq IHN1c3BlbmQvcmVzdW1lIG5lZWQgdG8gY2FsbCBkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kX3Vu bG9ja2VkKCkgdGhlbXNlbHZlcy4KPiBAQCAtMzIwNiw2ICszMjEyLDggQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fY2xpZW50X2Z1bmNzIGRybV9mYmRldl9jbGllbnRfZnVuY3MgPSB7Cj4gICAq IFRoaXMgZnVuY3Rpb24gaXMgc2FmZSB0byBjYWxsIGV2ZW4gd2hlbiB0aGVyZSBhcmUgbm8gY29u bmVjdG9ycyBwcmVzZW50Lgo+ICAgKiBTZXR1cCB3aWxsIGJlIHJldHJpZWQgb24gdGhlIG5leHQg aG90cGx1ZyBldmVudC4KPiAgICoKPiArICogVGhlIGZiZGV2IGlzIGRlc3Ryb3llZCBieSBkcm1f ZGV2X3VucmVnaXN0ZXIoKS4KPiArICoKPiAgICogUmV0dXJuczoKPiAgICogWmVybyBvbiBzdWNj ZXNzIG9yIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiAgICovCj4gQEAgLTMyMTQs NiArMzIyMiw4IEBAIGludCBkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB1bnNpZ25lZCBpbnQgcHJlZmVycmVkX2JwcCkKPiAgCXN0cnVjdCBkcm1fZmJfaGVs cGVyICpmYl9oZWxwZXI7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCVdBUk4oZGV2LT5mYl9oZWxwZXIs ICJmYl9oZWxwZXIgaXMgYWxyZWFkeSBzZXQhXG4iKTsKPiArCj4gIAlpZiAoIWRybV9mYmRldl9l bXVsYXRpb24pCj4gIAkJcmV0dXJuIDA7Cj4gIAo+IEBAIC0zMjI0LDEyICszMjM0LDE1IEBAIGlu dCBkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25l ZCBpbnQgcHJlZmVycmVkX2JwcCkKPiAgCXJldCA9IGRybV9jbGllbnRfbmV3KGRldiwgJmZiX2hl bHBlci0+Y2xpZW50LCAiZmJkZXYiLCAmZHJtX2ZiZGV2X2NsaWVudF9mdW5jcyk7Cj4gIAlpZiAo cmV0KSB7Cj4gIAkJa2ZyZWUoZmJfaGVscGVyKTsKPiArCQlEUk1fREVWX0VSUk9SKGRldi0+ZGV2 LCAiRmFpbGVkIHRvIHJlZ2lzdGVyIGNsaWVudDogJWRcbiIsIHJldCk7Cj4gIAkJcmV0dXJuIHJl dDsKPiAgCX0KPiAgCj4gIAlmYl9oZWxwZXItPnByZWZlcnJlZF9icHAgPSBwcmVmZXJyZWRfYnBw Owo+ICAKPiAtCWRybV9mYmRldl9jbGllbnRfaG90cGx1ZygmZmJfaGVscGVyLT5jbGllbnQpOwo+ ICsJcmV0ID0gZHJtX2ZiZGV2X2NsaWVudF9ob3RwbHVnKCZmYl9oZWxwZXItPmNsaWVudCk7Cj4g KwlpZiAocmV0KQo+ICsJCURSTV9ERVZfREVCVUcoZGV2LT5kZXYsICJjbGllbnQgaG90cGx1ZyBy ZXQ9JWRcbiIsIHJldCk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAtLSAKPiAyLjE4LjAKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK