Return-Path: Received: from mail-lf1-f68.google.com ([209.85.167.68]:38798 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbeIMLgP (ORCPT ); Thu, 13 Sep 2018 07:36:15 -0400 Received: by mail-lf1-f68.google.com with SMTP id i7-v6so3802183lfh.5 for ; Wed, 12 Sep 2018 23:28:11 -0700 (PDT) From: Maxim Zhukov To: Masahiro Yamada Cc: Greg Kroah-Hartman , Randy Dunlap , stable@vger.kernel.org, Lucas De Marchi , Lucas De Marchi , Michal Marek , Jessica Yu , Chih-Wei Huang , Maxim Zhukov Subject: [PATCH v4.14] kbuild: make missing $DEPMOD a Warning instead of an Error Date: Thu, 13 Sep 2018 09:28:02 +0300 Message-Id: <20180913062802.17386-1-mussitantesmortem@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: From: Randy Dunlap [ Upstream commit 914b087ff9e0e9a399a4927fa30793064afc0178 ] When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status: Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Change the Error to a Warning because "not all build hosts for cross compiling Linux are Linux systems and are able to provide a working port of depmod, especially at the file patch /sbin/depmod." I.e., "make modules_install" may be used to copy/install the loadable modules files to a target directory on a build system and then transferred to an embedded device where /sbin/depmod is run instead of it being run on the build system. Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed") Signed-off-by: Randy Dunlap Reported-by: H. Nikolaus Schaller Cc: stable@vger.kernel.org Cc: Lucas De Marchi Cc: Lucas De Marchi Cc: Michal Marek Cc: Jessica Yu Cc: Chih-Wei Huang Signed-off-by: Masahiro Yamada Signed-off-by: Maxim Zhukov --- scripts/depmod.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/depmod.sh b/scripts/depmod.sh index f41b0a4b575c..cf5b2b24b3cf 100755 --- a/scripts/depmod.sh +++ b/scripts/depmod.sh @@ -16,9 +16,9 @@ if ! test -r System.map ; then fi if [ -z $(command -v $DEPMOD) ]; then - echo "'make modules_install' requires $DEPMOD. Please install it." >&2 + echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2 echo "This is probably in the kmod package." >&2 - exit 1 + exit 0 fi # older versions of depmod don't support -P -- 2.19.0