From: Huang Rui Subject: Re: [PATCH] drm/amdgpu/display: return proper error codes in dm Date: Fri, 14 Sep 2018 13:45:09 +0800 Message-ID: <20180914034505.GA25456@hr-amur2> References: <20180913162928.2504-1-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180913162928.2504-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gVGh1LCBTZXAgMTMsIDIwMTggYXQgMTE6Mjk6MjhBTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IFJlcGxhY2UgLTEgd2l0aCBwcm9wZXIgZXJyb3IgY29kZXMuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgoKQWNrZWQtYnk6 IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v YW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIHwgOCArKysrLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+IGluZGV4IGVj Y2FlNjNkM2VmMS4uNTQxZjMzNzQ5OTYxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4gQEAgLTQ5Myw3ICs0OTMsNyBAQCBz dGF0aWMgaW50IGFtZGdwdV9kbV9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICBl cnJvcjoKPiAgCWFtZGdwdV9kbV9maW5pKGFkZXYpOwo+ICAKPiAtCXJldHVybiAtMTsKPiArCXJl dHVybiAtRUlOVkFMOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBhbWRncHVfZG1fZmluaShzdHJ1 Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiBAQCAtNTQ4LDcgKzU0OCw3IEBAIHN0YXRpYyBpbnQg bG9hZF9kbWN1X2Z3KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAJCWJyZWFrOwo+ICAJ ZGVmYXVsdDoKPiAgCQlEUk1fRVJST1IoIlVuc3VwcG9ydGVkIEFTSUMgdHlwZTogMHglWFxuIiwg YWRldi0+YXNpY190eXBlKTsKPiAtCQlyZXR1cm4gLTE7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g IAl9Cj4gIAo+ICAJaWYgKGFkZXYtPmZpcm13YXJlLmxvYWRfdHlwZSAhPSBBTURHUFVfRldfTE9B RF9QU1ApIHsKPiBAQCAtMTUzNyw3ICsxNTM3LDcgQEAgc3RhdGljIGludCBhbWRncHVfZG1faW5p dGlhbGl6ZV9kcm1fZGV2aWNlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAJbGlua19j bnQgPSBkbS0+ZGMtPmNhcHMubWF4X2xpbmtzOwo+ICAJaWYgKGFtZGdwdV9kbV9tb2RlX2NvbmZp Z19pbml0KGRtLT5hZGV2KSkgewo+ICAJCURSTV9FUlJPUigiRE06IEZhaWxlZCB0byBpbml0aWFs aXplIG1vZGUgY29uZmlnXG4iKTsKPiAtCQlyZXR1cm4gLTE7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gIAl9Cj4gIAo+ICAJLyogSWRlbnRpZnkgdGhlIG51bWJlciBvZiBwbGFuZXMgdG8gYmUgaW5p dGlhbGl6ZWQgKi8KPiBAQCAtMTY1Miw3ICsxNjUyLDcgQEAgc3RhdGljIGludCBhbWRncHVfZG1f aW5pdGlhbGl6ZV9kcm1fZGV2aWNlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAJa2Zy ZWUoYWNvbm5lY3Rvcik7Cj4gIAlmb3IgKGkgPSAwOyBpIDwgZG0tPmRjLT5jYXBzLm1heF9wbGFu ZXM7IGkrKykKPiAgCQlrZnJlZShtb2RlX2luZm8tPnBsYW5lc1tpXSk7Cj4gLQlyZXR1cm4gLTE7 Cj4gKwlyZXR1cm4gLUVJTlZBTDsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgYW1kZ3B1X2RtX2Rl c3Ryb3lfZHJtX2RldmljZShzdHJ1Y3QgYW1kZ3B1X2Rpc3BsYXlfbWFuYWdlciAqZG0pCj4gLS0g Cj4gMi4xMy42Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1n ZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=