Received: from eggs.gnu.org ([2001:4830:134:3::10]:35961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0rWI-0001Cp-3f for qemu-devel@nongnu.org; Fri, 14 Sep 2018 13:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0rWF-0007GV-Tc for qemu-devel@nongnu.org; Fri, 14 Sep 2018 13:04:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54998) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g0rWF-0007F1-MH for qemu-devel@nongnu.org; Fri, 14 Sep 2018 13:04:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02DFE1B75 for ; Fri, 14 Sep 2018 17:04:35 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" Date: Fri, 14 Sep 2018 18:04:29 +0100 Message-Id: <20180914170430.54271-2-dgilbert@redhat.com> In-Reply-To: <20180914170430.54271-1-dgilbert@redhat.com> References: <20180914170430.54271-1-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] migration/postcopy: Clear have_listen_thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peterx@redhat.com Cc: quintela@redhat.com From: "Dr. David Alan Gilbert" Clear have_listen_thread when we exit the thread. The fallout from this was that various things thought there was an ongoing postcopy after the postcopy had finished. The case that failed was postcopy->savevm->loadvm. This corresponds to RH bug https://bugzilla.redhat.com/show_bug.cgi?id=1608765 Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/savevm.c b/migration/savevm.c index 13e51f0e34..6384cf676d 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1679,6 +1679,7 @@ static void *postcopy_ram_listen_thread(void *opaque) qemu_loadvm_state_cleanup(); rcu_unregister_thread(); + mis->have_listen_thread = false; return NULL; } -- 2.17.1