From: Jordan Crouse Subject: Re: [PATCH v3 4/7] drm/msm/dpu: Change _dpu_crtc_power_enable to void Date: Mon, 24 Sep 2018 10:46:26 -0600 Message-ID: <20180924164626.GD10761@jcrouse-lnx.qualcomm.com> References: <20180924162228.180689-1-bzwang@chromium.org> <20180924162228.180689-5-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180924162228.180689-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMTI6MjI6MjVQTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBBbGwgY2hlY2tzIGZvciBfZHB1X2NydGNfcG93ZXJfZW5hYmxlIGFyZSBub3QgdHJ1ZSwg c28gdGhlIGZ1bmN0aW9uCj4gY2FuIG5ldmVyIHJldHVybiBhbiBlcnJvciBjb2RlLiBBbGwgY2Fs bHMgb2YgdGhlIGZ1bmN0aW9uIGhhdmUgYWxzbwo+IGJlZW4gY2hhbmdlZCBzbyB0aGF0IHRoZXkg ZG9uJ3QgZXhwZWN0IGEgcmV0dXJuIHZhbHVlLgo+IAo+IHYzOiBTZXBhcmF0ZWQgX2RwdV9jcnRj X3Bvd2VyX2VuYWJsZSBpbnRvIF9kcHVfY3J0Y19wb3dlcl9lbmFibGUgYW5kCj4gX2RwdV9jcnRj X3Bvd2VyX2Rpc2FibGUgZm9yIGNsYXJpdHkuCj4gCgpSZXZpZXdlZC1ieTogSm9yZGFuIENyb3Vz ZSA8amNyb3VzZUBjb2RlYXVyb3JhLm9yZz4KCj4gU2lnbmVkLW9mZi1ieTogQnJ1Y2UgV2FuZyA8 Ynp3YW5nQGNocm9taXVtLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2NydGMuYyB8IDQ0ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gaW5kZXggZTMxZTcwZjVkYmFjLi5jYjcxZTJh MmUwMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2Ny dGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMKPiBA QCAtNjAsMzcgKzYwLDE5IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRwdV9rbXMgKl9kcHVfY3J0 Y19nZXRfa21zKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCXJldHVybiB0b19kcHVfa21zKHBy aXYtPmttcyk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgaW50IF9kcHVfY3J0Y19wb3dlcl9l bmFibGUoc3RydWN0IGRwdV9jcnRjICpkcHVfY3J0YywgYm9vbCBlbmFibGUpCj4gLXsKPiAtCXN0 cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAtCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXY7Cj4g LQlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttczsKPiAtCj4gLQlpZiAoIWRwdV9jcnRjKSB7Cj4gLQkJ RFBVX0VSUk9SKCJpbnZhbGlkIGRwdSBjcnRjXG4iKTsKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiAt CX0KPiAtCj4gLQljcnRjID0gJmRwdV9jcnRjLT5iYXNlOwo+IC0JaWYgKCFjcnRjLT5kZXYgfHwg IWNydGMtPmRldi0+ZGV2X3ByaXZhdGUpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQgZHJtIGRl dmljZVxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gIAo+IC0JcHJpdiA9IGNydGMt PmRldi0+ZGV2X3ByaXZhdGU7Cj4gLQlpZiAoIXByaXYtPmttcykgewo+IC0JCURQVV9FUlJPUigi aW52YWxpZCBrbXNcbiIpOwo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JfQo+ICtzdGF0aWMgaW5s aW5lIHZvaWQgX2RwdV9jcnRjX3Bvd2VyX2VuYWJsZShzdHJ1Y3QgZHB1X2NydGMgKmRwdV9jcnRj KQo+ICt7Cj4gKwlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IF9kcHVfY3J0Y19nZXRfa21zKCZk cHVfY3J0Yy0+YmFzZSk7Cj4gIAo+IC0JZHB1X2ttcyA9IHRvX2RwdV9rbXMocHJpdi0+a21zKTsK PiArCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4gK30KPiAgCj4g LQlpZiAoZW5hYmxlKQo+IC0JCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRl dik7Cj4gLQllbHNlCj4gLQkJcG1fcnVudGltZV9wdXRfc3luYygmZHB1X2ttcy0+cGRldi0+ZGV2 KTsKPiArc3RhdGljIGlubGluZSB2b2lkIF9kcHVfY3J0Y19wb3dlcl9kaXNhYmxlKHN0cnVjdCBk cHVfY3J0YyAqZHB1X2NydGMpCj4gK3sKPiArCXN0cnVjdCBkcHVfa21zICpkcHVfa21zID0gX2Rw dV9jcnRjX2dldF9rbXMoJmRwdV9jcnRjLT5iYXNlKTsKPiAgCj4gLQlyZXR1cm4gMDsKPiArCXBt X3J1bnRpbWVfcHV0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4gIH0KPiAgCj4gIHN0YXRp YyB2b2lkIGRwdV9jcnRjX2Rlc3Ryb3koc3RydWN0IGRybV9jcnRjICpjcnRjKQo+IEBAIC04MjMs MTQgKzgwNSwxMCBAQCBzdGF0aWMgaW50IF9kcHVfY3J0Y192YmxhbmtfZW5hYmxlX25vX2xvY2so Cj4gIAlkZXYgPSBjcnRjLT5kZXY7Cj4gIAo+ICAJaWYgKGVuYWJsZSkgewo+IC0JCWludCByZXQ7 Cj4gLQo+ICAJCS8qIGRyb3AgbG9jayBzaW5jZSBwb3dlciBjcnRjIGNiIG1heSB0cnkgdG8gcmUt YWNxdWlyZSBsb2NrICovCj4gIAkJbXV0ZXhfdW5sb2NrKCZkcHVfY3J0Yy0+Y3J0Y19sb2NrKTsK PiAtCQlyZXQgPSBfZHB1X2NydGNfcG93ZXJfZW5hYmxlKGRwdV9jcnRjLCB0cnVlKTsKPiArCQlf ZHB1X2NydGNfcG93ZXJfZW5hYmxlKGRwdV9jcnRjKTsKPiAgCQltdXRleF9sb2NrKCZkcHVfY3J0 Yy0+Y3J0Y19sb2NrKTsKPiAtCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+ICAKPiAgCQls aXN0X2Zvcl9lYWNoX2VudHJ5KGVuYywgJmRldi0+bW9kZV9jb25maWcuZW5jb2Rlcl9saXN0LCBo ZWFkKSB7Cj4gIAkJCWlmIChlbmMtPmNydGMgIT0gY3J0YykKPiBAQCAtODU3LDcgKzgzNSw3IEBA IHN0YXRpYyBpbnQgX2RwdV9jcnRjX3ZibGFua19lbmFibGVfbm9fbG9jaygKPiAgCj4gIAkJLyog ZHJvcCBsb2NrIHNpbmNlIHBvd2VyIGNydGMgY2IgbWF5IHRyeSB0byByZS1hY3F1aXJlIGxvY2sg Ki8KPiAgCQltdXRleF91bmxvY2soJmRwdV9jcnRjLT5jcnRjX2xvY2spOwo+IC0JCV9kcHVfY3J0 Y19wb3dlcl9lbmFibGUoZHB1X2NydGMsIGZhbHNlKTsKPiArCQlfZHB1X2NydGNfcG93ZXJfZGlz YWJsZShkcHVfY3J0Yyk7Cj4gIAkJbXV0ZXhfbG9jaygmZHB1X2NydGMtPmNydGNfbG9jayk7Cj4g IAl9Cj4gIAo+IC0tIAo+IDIuMTkuMC40NDQuZzE4MjQyZGE3ZWYtZ29vZwo+IAoKLS0gClRoZSBR dWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9y YSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGlu ZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K