From: Michal Kubecek Subject: Re: [PATCH net v2 1/2] net: core: add member wol_enabled to struct net_device Date: Tue, 25 Sep 2018 10:28:30 +0200 Message-ID: <20180925082830.GC30601@unicorn.suse.cz> References: <43386295-806b-ff32-4c7c-56aaeb87b4db@gmail.com> <6a574380-06f6-4bce-9705-e2b554359337@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , Florian Fainelli , David Miller , Realtek linux nic maintainers , "netdev@vger.kernel.org" To: Heiner Kallweit Return-path: Received: from mx2.suse.de ([195.135.220.15]:49988 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726031AbeIYOe6 (ORCPT ); Tue, 25 Sep 2018 10:34:58 -0400 Content-Disposition: inline In-Reply-To: <6a574380-06f6-4bce-9705-e2b554359337@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: (I wrote my comment to v1 because I overlooked there is a v2 already; duplicating it here.) On Mon, Sep 24, 2018 at 09:58:59PM +0200, Heiner Kallweit wrote: > Add flag wol_enabled to struct net_device indicating whether > Wake-on-LAN is enabled. As first user phy_suspend() will use it to > decide whether PHY can be suspended or not. > > Fixes: f1e911d5d0df ("r8169: add basic phylib support") > Fixes: e8cfd9d6c772 ("net: phy: call state machine synchronously in phy_stop") > Signed-off-by: Heiner Kallweit > --- > include/linux/netdevice.h | 3 +++ > net/core/ethtool.c | 9 ++++++++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 1cbbf77a6..f5f1f1450 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1756,6 +1756,8 @@ enum netdev_priv_flags { > * switch driver and used to set the phys state of the > * switch port. > * > + * @wol_enabled: Wake-on-LAN is enabled > + * > * FIXME: cleanup struct net_device such that network protocol info > * moves out. > */ > @@ -2039,6 +2041,7 @@ struct net_device { > struct lock_class_key *qdisc_tx_busylock; > struct lock_class_key *qdisc_running_key; > bool proto_down; > + unsigned wol_enabled:1; > }; > #define to_net_dev(d) container_of(d, struct net_device, dev) > As there is no bitfield yet, this would add 4 bytes to struct net_device. How about using a bit in net_device::priv_flags like IFF_RXFH_CONFIGURED in ethtool_set_rxfh_indir() and ethtool_set_rxfh()? Michal Kubecek