Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F510C43382 for ; Tue, 25 Sep 2018 15:10:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFEB42098A for ; Tue, 25 Sep 2018 15:09:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFEB42098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729420AbeIYVRy (ORCPT ); Tue, 25 Sep 2018 17:17:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:36368 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729098AbeIYVRx (ORCPT ); Tue, 25 Sep 2018 17:17:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B38E9B016 for ; Tue, 25 Sep 2018 15:09:56 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id E48C7DAE2F; Tue, 25 Sep 2018 17:09:55 +0200 (CEST) Date: Tue, 25 Sep 2018 17:09:55 +0200 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: relocation: Add basic extent backref related comment for build_backref_tree() Message-ID: <20180925150955.GD3255@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20180925063746.14805-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925063746.14805-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Sep 25, 2018 at 02:37:46PM +0800, Qu Wenruo wrote: > fs/btrfs/relocation.c:build_backref_tree() is some code from 2009 era, > although it works pretty fine, it's not that easy to understand. > Especially combined with the complex btrfs backref format. > > This patch adds some basic comment for the backref build part of the > code, making it less hard to read, at least for backref searching part. > > Signed-off-by: Qu Wenruo Added to misc-next, thanks.