From: Sean Paul Subject: Re: [PATCH v3 4/7] drm/msm/dpu: Change _dpu_crtc_power_enable to void Date: Wed, 26 Sep 2018 04:10:42 -0400 Message-ID: <20180926081042.GN72545@art_vandelay> References: <20180924162228.180689-1-bzwang@chromium.org> <20180924162228.180689-5-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180924162228.180689-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMTI6MjI6MjVQTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBBbGwgY2hlY2tzIGZvciBfZHB1X2NydGNfcG93ZXJfZW5hYmxlIGFyZSBub3QgdHJ1ZSwg c28gdGhlIGZ1bmN0aW9uCj4gY2FuIG5ldmVyIHJldHVybiBhbiBlcnJvciBjb2RlLiBBbGwgY2Fs bHMgb2YgdGhlIGZ1bmN0aW9uIGhhdmUgYWxzbwo+IGJlZW4gY2hhbmdlZCBzbyB0aGF0IHRoZXkg ZG9uJ3QgZXhwZWN0IGEgcmV0dXJuIHZhbHVlLgo+IAo+IHYzOiBTZXBhcmF0ZWQgX2RwdV9jcnRj X3Bvd2VyX2VuYWJsZSBpbnRvIF9kcHVfY3J0Y19wb3dlcl9lbmFibGUgYW5kCj4gX2RwdV9jcnRj X3Bvd2VyX2Rpc2FibGUgZm9yIGNsYXJpdHkuCj4gCj4gU2lnbmVkLW9mZi1ieTogQnJ1Y2UgV2Fu ZyA8Ynp3YW5nQGNocm9taXVtLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X2NydGMuYyB8IDQ0ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gaW5kZXggZTMxZTcwZjVkYmFjLi5jYjcx ZTJhMmUwMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMK PiBAQCAtNjAsMzcgKzYwLDE5IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRwdV9rbXMgKl9kcHVf Y3J0Y19nZXRfa21zKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCXJldHVybiB0b19kcHVfa21z KHByaXYtPmttcyk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgaW50IF9kcHVfY3J0Y19wb3dl cl9lbmFibGUoc3RydWN0IGRwdV9jcnRjICpkcHVfY3J0YywgYm9vbCBlbmFibGUpCj4gLXsKPiAt CXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAtCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXY7 Cj4gLQlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttczsKPiAtCj4gLQlpZiAoIWRwdV9jcnRjKSB7Cj4g LQkJRFBVX0VSUk9SKCJpbnZhbGlkIGRwdSBjcnRjXG4iKTsKPiAtCQlyZXR1cm4gLUVJTlZBTDsK PiAtCX0KPiAtCj4gLQljcnRjID0gJmRwdV9jcnRjLT5iYXNlOwo+IC0JaWYgKCFjcnRjLT5kZXYg fHwgIWNydGMtPmRldi0+ZGV2X3ByaXZhdGUpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQgZHJt IGRldmljZVxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gIAo+IC0JcHJpdiA9IGNy dGMtPmRldi0+ZGV2X3ByaXZhdGU7Cj4gLQlpZiAoIXByaXYtPmttcykgewo+IC0JCURQVV9FUlJP UigiaW52YWxpZCBrbXNcbiIpOwo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JfQo+ICtzdGF0aWMg aW5saW5lIHZvaWQgX2RwdV9jcnRjX3Bvd2VyX2VuYWJsZShzdHJ1Y3QgZHB1X2NydGMgKmRwdV9j cnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IF9kcHVfY3J0Y19nZXRfa21z KCZkcHVfY3J0Yy0+YmFzZSk7Cj4gIAo+IC0JZHB1X2ttcyA9IHRvX2RwdV9rbXMocHJpdi0+a21z KTsKPiArCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4gK30KPiAg Cj4gLQlpZiAoZW5hYmxlKQo+IC0JCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYt PmRldik7Cj4gLQllbHNlCj4gLQkJcG1fcnVudGltZV9wdXRfc3luYygmZHB1X2ttcy0+cGRldi0+ ZGV2KTsKPiArc3RhdGljIGlubGluZSB2b2lkIF9kcHVfY3J0Y19wb3dlcl9kaXNhYmxlKHN0cnVj dCBkcHVfY3J0YyAqZHB1X2NydGMpCj4gK3sKPiArCXN0cnVjdCBkcHVfa21zICpkcHVfa21zID0g X2RwdV9jcnRjX2dldF9rbXMoJmRwdV9jcnRjLT5iYXNlKTsKPiAgCj4gLQlyZXR1cm4gMDsKPiAr CXBtX3J1bnRpbWVfcHV0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4gIH0KPiAgCj4gIHN0 YXRpYyB2b2lkIGRwdV9jcnRjX2Rlc3Ryb3koc3RydWN0IGRybV9jcnRjICpjcnRjKQo+IEBAIC04 MjMsMTQgKzgwNSwxMCBAQCBzdGF0aWMgaW50IF9kcHVfY3J0Y192YmxhbmtfZW5hYmxlX25vX2xv Y2soCj4gIAlkZXYgPSBjcnRjLT5kZXY7Cj4gIAo+ICAJaWYgKGVuYWJsZSkgewo+IC0JCWludCBy ZXQ7Cj4gLQo+ICAJCS8qIGRyb3AgbG9jayBzaW5jZSBwb3dlciBjcnRjIGNiIG1heSB0cnkgdG8g cmUtYWNxdWlyZSBsb2NrICovCj4gIAkJbXV0ZXhfdW5sb2NrKCZkcHVfY3J0Yy0+Y3J0Y19sb2Nr KTsKPiAtCQlyZXQgPSBfZHB1X2NydGNfcG93ZXJfZW5hYmxlKGRwdV9jcnRjLCB0cnVlKTsKPiAr CQlfZHB1X2NydGNfcG93ZXJfZW5hYmxlKGRwdV9jcnRjKTsKCkl0IHNlZW1zIHlvdSBjb3VsZCBq dXN0IGNhbGwgdGhlIHJ1bnRpbWUgZnVuYyBkaXJlY3RseT8gU29tZXRoaW5nIGxpa2U6CgogICAg ICAgIHBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRldi0+ZGV2KTsKCj4gIAkJbXV0ZXhfbG9jaygmZHB1 X2NydGMtPmNydGNfbG9jayk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJuIHJldDsKPiAgCj4g IAkJbGlzdF9mb3JfZWFjaF9lbnRyeShlbmMsICZkZXYtPm1vZGVfY29uZmlnLmVuY29kZXJfbGlz dCwgaGVhZCkgewo+ICAJCQlpZiAoZW5jLT5jcnRjICE9IGNydGMpCj4gQEAgLTg1Nyw3ICs4MzUs NyBAQCBzdGF0aWMgaW50IF9kcHVfY3J0Y192YmxhbmtfZW5hYmxlX25vX2xvY2soCj4gIAo+ICAJ CS8qIGRyb3AgbG9jayBzaW5jZSBwb3dlciBjcnRjIGNiIG1heSB0cnkgdG8gcmUtYWNxdWlyZSBs b2NrICovCj4gIAkJbXV0ZXhfdW5sb2NrKCZkcHVfY3J0Yy0+Y3J0Y19sb2NrKTsKPiAtCQlfZHB1 X2NydGNfcG93ZXJfZW5hYmxlKGRwdV9jcnRjLCBmYWxzZSk7Cj4gKwkJX2RwdV9jcnRjX3Bvd2Vy X2Rpc2FibGUoZHB1X2NydGMpOwoKICAgICAgICBwbV9ydW50aW1lX3B1dF9zeW5jKCZkZXYtPmRl dik7Cgo+ICAJCW11dGV4X2xvY2soJmRwdV9jcnRjLT5jcnRjX2xvY2spOwo+ICAJfQo+ICAKPiAt LSAKPiAyLjE5LjAuNDQ0LmcxODI0MmRhN2VmLWdvb2cKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3 YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVu b0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9mcmVlZHJlbm8K