From: Thomas Hellstrom Subject: [PATCH -next 17/18] drm/vmwgfx: Don't refcount cotable lookups during command buffer validation Date: Wed, 26 Sep 2018 18:18:38 +0200 Message-ID: <20180926161839.4549-17-thellstrom@vmware.com> References: <20180926161839.4549-1-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on061e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe49::61e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87DD56E4B7 for ; Wed, 26 Sep 2018 16:19:29 +0000 (UTC) In-Reply-To: <20180926161839.4549-1-thellstrom@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Thomas Hellstrom , linux-graphics-maintainer@vmware.com List-Id: dri-devel@lists.freedesktop.org VGhlIHR5cGljYWwgcGF0dGVybiBvZiB0aGVzZSBsb29rdXBzIGFyZQotTG9va3VwCi1QdXQgb24g dmFsaWRhdGUgbGlzdCBpZiBub3QgYWxyZWFkeSB0aGVyZS4KLVVucmVmZXJlbmNlCkFuZCBzaW5j ZSB3ZSBhcmUgdGhlIGV4Y2x1c2l2ZSB1c2VyIG9mIHRoZSBjb250ZXh0IGR1cmluZyBsb29rdXAg dGltZSwKd2UgY2FuIGJlIHN1cmUgdGhhdCB0aGUgcmVzb3VyY2Ugd2lsbCBzdGF5IGFsaXZlIGR1 cmluZyB0aGUgc2VxdWVuY2UuClNvIGF2b2lkIHRha2luZyBhIHJlZmVyZW5jZSBkdXJpbmcgbG9v a3VwLCBhbmQgYWxzbyBhdm9pZCB1bnJlZmVyZW5jaW5nCndoZW4gZG9uZS4gVGhlcmUgYXJlIHR3 byB1c2VycyBvdXRzaWRlIG9mIGNvbW1hbmQgYnVmZmVyIHZhbGlkYXRpb24gYW5kCnRob3NlIGFy ZSByZWZjb3VudGVkIGV4cGxpY2l0bHkuCgpTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSGVsbHN0cm9t IDx0aGVsbHN0cm9tQHZtd2FyZS5jb20+ClJldmlld2VkLWJ5OiBTaW5jbGFpciBZZWggPHN5ZWhA dm13YXJlLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9jb250ZXh0LmMg fCA1ICsrLS0tCiBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9leGVjYnVmLmMgfCA1IC0t LS0tCiBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9zaGFkZXIuYyAgfCAzICsrLQogZHJp dmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfc28uYyAgICAgIHwgMyArKy0KIDQgZmlsZXMgY2hh bmdlZCwgNiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9jb250ZXh0LmMgYi9kcml2ZXJzL2dwdS9kcm0vdm13 Z2Z4L3Ztd2dmeF9jb250ZXh0LmMKaW5kZXggMjRkN2M4MTA4MWFlLi4xNGJkNzYwYTYyZmQgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2NvbnRleHQuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9jb250ZXh0LmMKQEAgLTg2MSw5ICs4NjEsOCBA QCBzdHJ1Y3Qgdm13X3Jlc291cmNlICp2bXdfY29udGV4dF9jb3RhYmxlKHN0cnVjdCB2bXdfcmVz b3VyY2UgKmN0eCwKIAlpZiAoY290YWJsZV90eXBlID49IFNWR0FfQ09UQUJMRV9EWDEwX01BWCkK IAkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiAKLQlyZXR1cm4gdm13X3Jlc291cmNlX3JlZmVy ZW5jZQotCQkoY29udGFpbmVyX29mKGN0eCwgc3RydWN0IHZtd191c2VyX2NvbnRleHQsIHJlcykt PgotCQkgY290YWJsZXNbY290YWJsZV90eXBlXSk7CisJcmV0dXJuIGNvbnRhaW5lcl9vZihjdHgs IHN0cnVjdCB2bXdfdXNlcl9jb250ZXh0LCByZXMpLT4KKwkJY290YWJsZXNbY290YWJsZV90eXBl XTsKIH0KIAogLyoqCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9l eGVjYnVmLmMgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9leGVjYnVmLmMKaW5kZXgg MTNkYjdlZmNiODljLi5kZmEyZDE5Mjc0ZDUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS92 bXdnZngvdm13Z2Z4X2V4ZWNidWYuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dm eF9leGVjYnVmLmMKQEAgLTM3Miw3ICszNzIsNiBAQCBzdGF0aWMgaW50IHZtd19yZXNvdXJjZV9j b250ZXh0X3Jlc19hZGQoc3RydWN0IHZtd19wcml2YXRlICpkZXZfcHJpdiwKIAkJCQljb250aW51 ZTsKIAogCQkJcmV0ID0gdm13X3Jlc291cmNlX3ZhbF9hZGQoc3dfY29udGV4dCwgcmVzKTsKLQkJ CXZtd19yZXNvdXJjZV91bnJlZmVyZW5jZSgmcmVzKTsKIAkJCWlmICh1bmxpa2VseShyZXQgIT0g MCkpCiAJCQkJcmV0dXJuIHJldDsKIAkJfQpAQCAtMTI2Niw3ICsxMjY1LDYgQEAgc3RhdGljIGlu dCB2bXdfY21kX2R4X2RlZmluZV9xdWVyeShzdHJ1Y3Qgdm13X3ByaXZhdGUgKmRldl9wcml2LAog CiAJY290YWJsZV9yZXMgPSB2bXdfY29udGV4dF9jb3RhYmxlKGN0eF9ub2RlLT5jdHgsIFNWR0Ff Q09UQUJMRV9EWFFVRVJZKTsKIAlyZXQgPSB2bXdfY290YWJsZV9ub3RpZnkoY290YWJsZV9yZXMs IGNtZC0+cS5xdWVyeUlkKTsKLQl2bXdfcmVzb3VyY2VfdW5yZWZlcmVuY2UoJmNvdGFibGVfcmVz KTsKIAogCXJldHVybiByZXQ7CiB9CkBAIC0yNTc4LDcgKzI1NzYsNiBAQCBzdGF0aWMgaW50IHZt d19jbWRfZHhfdmlld19kZWZpbmUoc3RydWN0IHZtd19wcml2YXRlICpkZXZfcHJpdiwKIAogCXJl cyA9IHZtd19jb250ZXh0X2NvdGFibGUoY3R4X25vZGUtPmN0eCwgdm13X3ZpZXdfY290YWJsZXNb dmlld190eXBlXSk7CiAJcmV0ID0gdm13X2NvdGFibGVfbm90aWZ5KHJlcywgY21kLT5kZWZpbmVk X2lkKTsKLQl2bXdfcmVzb3VyY2VfdW5yZWZlcmVuY2UoJnJlcyk7CiAJaWYgKHVubGlrZWx5KHJl dCAhPSAwKSkKIAkJcmV0dXJuIHJldDsKIApAQCAtMjY3NSw3ICsyNjcyLDYgQEAgc3RhdGljIGlu dCB2bXdfY21kX2R4X3NvX2RlZmluZShzdHJ1Y3Qgdm13X3ByaXZhdGUgKmRldl9wcml2LAogCXJl cyA9IHZtd19jb250ZXh0X2NvdGFibGUoY3R4X25vZGUtPmN0eCwgdm13X3NvX2NvdGFibGVzW3Nv X3R5cGVdKTsKIAljbWQgPSBjb250YWluZXJfb2YoaGVhZGVyLCB0eXBlb2YoKmNtZCksIGhlYWRl cik7CiAJcmV0ID0gdm13X2NvdGFibGVfbm90aWZ5KHJlcywgY21kLT5kZWZpbmVkX2lkKTsKLQl2 bXdfcmVzb3VyY2VfdW5yZWZlcmVuY2UoJnJlcyk7CiAKIAlyZXR1cm4gcmV0OwogfQpAQCAtMjgw Niw3ICsyODAyLDYgQEAgc3RhdGljIGludCB2bXdfY21kX2R4X2RlZmluZV9zaGFkZXIoc3RydWN0 IHZtd19wcml2YXRlICpkZXZfcHJpdiwKIAogCXJlcyA9IHZtd19jb250ZXh0X2NvdGFibGUoY3R4 X25vZGUtPmN0eCwgU1ZHQV9DT1RBQkxFX0RYU0hBREVSKTsKIAlyZXQgPSB2bXdfY290YWJsZV9u b3RpZnkocmVzLCBjbWQtPmJvZHkuc2hhZGVySWQpOwotCXZtd19yZXNvdXJjZV91bnJlZmVyZW5j ZSgmcmVzKTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9zaGFkZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngv dm13Z2Z4X3NoYWRlci5jCmluZGV4IDY5MTVjODI1OGU2Yi4uYmYzMmZlNDQ2MjE5IDEwMDY0NAot LS0gYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9zaGFkZXIuYworKysgYi9kcml2ZXJz L2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9zaGFkZXIuYwpAQCAtNjM2LDcgKzYzNiw4IEBAIGludCB2 bXdfZHhfc2hhZGVyX2FkZChzdHJ1Y3Qgdm13X2NtZGJ1Zl9yZXNfbWFuYWdlciAqbWFuLAogCiAJ cmVzID0gJnNoYWRlci0+cmVzOwogCXNoYWRlci0+Y3R4ID0gY3R4OwotCXNoYWRlci0+Y290YWJs ZSA9IHZtd19jb250ZXh0X2NvdGFibGUoY3R4LCBTVkdBX0NPVEFCTEVfRFhTSEFERVIpOworCXNo YWRlci0+Y290YWJsZSA9IHZtd19yZXNvdXJjZV9yZWZlcmVuY2UKKwkJKHZtd19jb250ZXh0X2Nv dGFibGUoY3R4LCBTVkdBX0NPVEFCTEVfRFhTSEFERVIpKTsKIAlzaGFkZXItPmlkID0gdXNlcl9r ZXk7CiAJc2hhZGVyLT5jb21taXR0ZWQgPSBmYWxzZTsKIAlJTklUX0xJU1RfSEVBRCgmc2hhZGVy LT5jb3RhYmxlX2hlYWQpOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdn Znhfc28uYyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X3NvLmMKaW5kZXggYWFhYmI4 N2FjM2FmLi5iYzhiYjY5MGYxZWEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngv dm13Z2Z4X3NvLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfc28uYwpAQCAt MzY2LDcgKzM2Niw4IEBAIGludCB2bXdfdmlld19hZGQoc3RydWN0IHZtd19jbWRidWZfcmVzX21h bmFnZXIgKm1hbiwKIAlyZXMgPSAmdmlldy0+cmVzOwogCXZpZXctPmN0eCA9IGN0eDsKIAl2aWV3 LT5zcmYgPSB2bXdfcmVzb3VyY2VfcmVmZXJlbmNlKHNyZik7Ci0Jdmlldy0+Y290YWJsZSA9IHZt d19jb250ZXh0X2NvdGFibGUoY3R4LCB2bXdfdmlld19jb3RhYmxlc1t2aWV3X3R5cGVdKTsKKwl2 aWV3LT5jb3RhYmxlID0gdm13X3Jlc291cmNlX3JlZmVyZW5jZQorCQkodm13X2NvbnRleHRfY290 YWJsZShjdHgsIHZtd192aWV3X2NvdGFibGVzW3ZpZXdfdHlwZV0pKTsKIAl2aWV3LT52aWV3X3R5 cGUgPSB2aWV3X3R5cGU7CiAJdmlldy0+dmlld19pZCA9IHVzZXJfa2V5OwogCXZpZXctPmNtZF9z aXplID0gY21kX3NpemU7Ci0tIAoyLjE0LjQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=