Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:39948 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbeI0E6v (ORCPT ); Thu, 27 Sep 2018 00:58:51 -0400 From: Frank Sorenson To: linux-fsdevel@vger.kernel.org Cc: hirofumi@mail.parknet.co.jp Subject: [PATCH V4 4/4] fat: truncate inode timestamp updates in setattr Date: Wed, 26 Sep 2018 17:43:35 -0500 Message-Id: <20180926224335.5919-5-sorenson@redhat.com> In-Reply-To: <20180926224335.5919-1-sorenson@redhat.com> References: <20180926224335.5919-1-sorenson@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: setattr_copy can't truncate timestamps correctly for msdos/vfat, so truncate and copy them ourselves. Signed-off-by: Frank Sorenson --- fs/fat/file.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/fs/fat/file.c b/fs/fat/file.c index 4b5438405415..13935ee99e1e 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c @@ -542,6 +542,18 @@ int fat_setattr(struct dentry *dentry, struct iattr *attr) up_write(&MSDOS_I(inode)->truncate_lock); } + /* + * setattr_copy can't truncate these appropriately, so we'll + * copy them ourselves + */ + if (attr->ia_valid & ATTR_ATIME) + fat_truncate_time(inode, &attr->ia_atime, S_ATIME); + if (attr->ia_valid & ATTR_CTIME) + fat_truncate_time(inode, &attr->ia_ctime, S_CTIME); + if (attr->ia_valid & ATTR_MTIME) + fat_truncate_time(inode, &attr->ia_mtime, S_MTIME); + attr->ia_valid &= ~(ATTR_ATIME|ATTR_CTIME|ATTR_MTIME); + setattr_copy(inode, attr); mark_inode_dirty(inode); out: -- 2.14.4