Return-Path: Received: from mx2.suse.de ([195.135.220.15]:60586 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726953AbeI0T5p (ORCPT ); Thu, 27 Sep 2018 15:57:45 -0400 Date: Thu, 27 Sep 2018 15:39:24 +0200 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , nixiaoming@huawei.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/2] New fanotify event info API Message-ID: <20180927133924.GA8800@quack2.suse.cz> References: <20180921182031.3184-1-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180921182031.3184-1-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 21-09-18 21:20:29, Amir Goldstein wrote: > Jan, > > Reposting my slightly modified cleanup patch along with the patch > from nixiaoming that uses it to add a new fanotify_init() flag. > > After a few review cycles with nixiaoming, per his request, I took > his FAN_EVENT_INFO_TID patch to my tree, fixes a couple of issues > including commit message wording and tested it. > > For me, the new API seems very intuitive, not sure why thread id was > not reported to begin with, but if you like more concrete use cases, > you will need to ask them from nixiaoming. > > Thanks, > Amir. > > Amir Goldstein (1): > fanotify: store fanotify_init() flags in group's fanotify_data > > nixiaoming (1): > fanotify: support reporting thread id instead of process id Thanks. Both patches look good to me and I've queued them up to my tree. Honza > > fs/notify/fanotify/fanotify.c | 9 ++++++--- > fs/notify/fanotify/fanotify.h | 2 +- > fs/notify/fanotify/fanotify_user.c | 10 +++++----- > fs/notify/fdinfo.c | 24 +----------------------- > include/linux/fanotify.h | 4 ++++ > include/linux/fsnotify_backend.h | 4 ++-- > include/uapi/linux/fanotify.h | 9 +++++++-- > 7 files changed, 26 insertions(+), 36 deletions(-) > > -- > 2.17.1 > -- Jan Kara SUSE Labs, CR