From: Tom Rini Date: Sun, 30 Sep 2018 15:25:06 -0400 Subject: [U-Boot] [U-Boot, 1/2] Kbuild: fix # escaping in .cmd files for future Make In-Reply-To: <1537324557-27033-2-git-send-email-yamada.masahiro@socionext.com> References: <1537324557-27033-2-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20180930192506.GD15726@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Wed, Sep 19, 2018 at 11:35:56AM +0900, Masahiro Yamada wrote: > From: Rasmus Villemoes > > [ commit 9564a8cf422d7b58f6e857e3546d346fa970191e in Linux ] > > I tried building using a freshly built Make (4.2.1-69-g8a731d1), but > already the objtool build broke with > > orc_dump.c: In function ‘orc_dump’: > orc_dump.c:106:2: error: ‘elf_getshnum’ is deprecated [-Werror=deprecated-declarations] > if (elf_getshdrnum(elf, &nr_sections)) { > > Turns out that with that new Make, the backslash was not removed, so cpp > didn't see a #include directive, grep found nothing, and > -DLIBELF_USE_DEPRECATED was wrongly put in CFLAGS. > > Now, that new Make behaviour is documented in their NEWS file: > > * WARNING: Backward-incompatibility! > Number signs (#) appearing inside a macro reference or function invocation > no longer introduce comments and should not be escaped with backslashes: > thus a call such as: > foo := $(shell echo '#') > is legal. Previously the number sign needed to be escaped, for example: > foo := $(shell echo '\#') > Now this latter will resolve to "\#". If you want to write makefiles > portable to both versions, assign the number sign to a variable: > C := \# > foo := $(shell echo '$C') > This was claimed to be fixed in 3.81, but wasn't, for some reason. > To detect this change search for 'nocomment' in the .FEATURES variable. > > This also fixes up the two make-cmd instances to replace # with $(pound) > rather than with \#. There might very well be other places that need > similar fixup in preparation for whatever future Make release contains > the above change, but at least this builds an x86_64 defconfig with the > new make. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=197847 > Cc: Randy Dunlap > Signed-off-by: Rasmus Villemoes > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: