From: Maxime Ripard Date: Mon, 1 Oct 2018 12:01:56 +0200 Subject: [U-Boot] [PATCH 1/5] mmc: sunxi: add support for automatic delay calibration In-Reply-To: <20181001094837.0332d966@donnerap.Emea.Arm.com> References: <20180929234553.31019-1-vagrant@debian.org> <20180929234553.31019-2-vagrant@debian.org> <39395662-579e-5554-0b9a-3879e070a1d2@arm.com> <20181001080955.hgotqgkj7bcvczgq@flea> <20181001094837.0332d966@donnerap.Emea.Arm.com> Message-ID: <20181001100156.mt4copbpdxhaiwdn@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Mon, Oct 01, 2018 at 09:48:37AM +0100, Andre Przywara wrote: > On Mon, 1 Oct 2018 10:09:55 +0200 > Maxime Ripard wrote: >=20 > > On Sun, Sep 30, 2018 at 04:16:36PM +0100, Andr=C3=A9 Przywara wrote: > > > On 9/30/18 12:45 AM, Vagrant Cascadian wrote: =20 > > > > From: Vasily Khoruzhick > > > >=20 > > > > A64 supports automatic delay calibration and Linux driver uses it > > > > instead of hardcoded delays. Add support for it to u-boot > > > > driver. =20 > > >=20 > > > So technically that should be derived from the node's compatible > > > string, like we do in Linux. But I see that we are not there yet in > > > U-Boot. Meanwhile I don't think you should introduce a new Kconfig > > > option, you could keep the hacky U-Boot style and just add an > > > #if defined(CONFIG_MACH_SUN50I) || defined(CONFIG_MACH_SUN50I_H6) > > > to the two places instead. =20 > >=20 > > IIRC, the calibration is only needed for the eMMC though, so we'd need > > to check that against the MMC number too. >=20 > Is that so? I was looking at the Linux driver, and that one sets > can_calibrate for both the "normal" and eMMC A64 compatible strings. > Isn't the difference between the two the new timing mode, which the > eMMC doesn't have? This looks to be covered in U-Boot, though in a > similar hacky way. You're right, sorry for the noise... Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: