From: Daniel Vetter Subject: Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef Date: Wed, 3 Oct 2018 18:13:26 +0200 Message-ID: <20181003161326.GD31561@phenom.ffwll.local> References: <20181002205836.2323084-1-arnd@arndb.de> <123f7e1c-8f2b-5797-de16-650ec01d0b24@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <123f7e1c-8f2b-5797-de16-650ec01d0b24@tronnes.org> Sender: linux-kernel-owner@vger.kernel.org To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Arnd Bergmann , Philipp Zabel , David Airlie , Lucas Stach , Sam Ravnborg , Daniel Vetter , Souptick Joarder , Leonard Crestez , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, Oct 03, 2018 at 05:49:32PM +0200, Noralf Trønnes wrote: > > > Den 02.10.2018 22.58, skrev Arnd Bergmann: > > The variable is now referenced unconditionally, but still > > declared in an #ifdef: > > > > drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind': > > drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'? > > > > Remove the #ifdef so it can always be accessed. > > > > Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()") > > Signed-off-by: Arnd Bergmann > > --- > > I've already applied the previous one you sent: > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=064b06bbf117f8b5e64a5143e970d5a1cf602fd6 > > Not sure when it reaches linux-next now that we are past rc6. Only once we're past -rc1. -Daniel > > Noralf. > > > drivers/gpu/drm/imx/imx-drm-core.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > index a70f3131a377..0e6942f21a4e 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -35,10 +35,8 @@ > > #define MAX_CRTC 4 > > -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) > > static int legacyfb_depth = 16; > > module_param(legacyfb_depth, int, 0444); > > -#endif > > DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops); > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch