From: Lucas De Marchi Subject: Re: [PATCH 1/8] drm/i915/icl: create function to identify combophy port Date: Wed, 3 Oct 2018 11:03:31 -0700 Message-ID: <20181003180329.GA4011@ldmartin-desk.jf.intel.com> References: <20181003072203.12848-1-mahesh1.kumar@intel.com> <20181003072203.12848-2-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 907B66E252 for ; Wed, 3 Oct 2018 18:03:41 +0000 (UTC) Received: by mail-pf1-x430.google.com with SMTP id a23-v6so2035835pfi.12 for ; Wed, 03 Oct 2018 11:03:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181003072203.12848-2-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTI6NTE6NTZQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IFRoaXMgcGF0Y2ggY3JlYXRlcyBhIGZ1bmN0aW9uL3dyYXBwZXIgdG8gY2hlY2sgaWYg cG9ydCBpcyBjb21ib3BoeSBwb3J0Cj4gaW5zdGVhZCBvZiBleHBsaWNpdGx5IGNvbXBhcmluZyBw b3J0cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50 ZWwuY29tPgo+IENjOiBNYWRoYXYgQ2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29tPgo+ IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgfCAxNSArKysrKysrKy0tLS0tLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTEgKysrKysrKysrKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDEgKwo+ICAzIGZpbGVz IGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGRpLmMKPiBpbmRleCA3ZjM0ZDM5NTVjYTEuLmI1YjhkYWUwNmNkZSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTkxNiw3ICs5MTYsNyBAQCBzdGF0aWMgaW50 IGludGVsX2RkaV9oZG1pX2xldmVsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg ZW51bSBwb3J0IHBvcgo+ICAJbGV2ZWwgPSBkZXZfcHJpdi0+dmJ0LmRkaV9wb3J0X2luZm9bcG9y dF0uaGRtaV9sZXZlbF9zaGlmdDsKPiAgCj4gIAlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpIHsK PiAtCQlpZiAocG9ydCA9PSBQT1JUX0EgfHwgcG9ydCA9PSBQT1JUX0IpCj4gKwkJaWYgKGludGVs X3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKQo+ICAJCQlpY2xfZ2V0X2NvbWJvX2J1 Zl90cmFucyhkZXZfcHJpdiwgcG9ydCwKPiAgCQkJCQkJSU5URUxfT1VUUFVUX0hETUksICZuX2Vu dHJpZXMpOwo+ICAJCWVsc2UKPiBAQCAtMTUzNSw3ICsxNTM1LDcgQEAgc3RhdGljIHZvaWQgaWNs X2RkaV9jbG9ja19nZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAl1aW50MzJf dCBwbGxfaWQ7Cj4gIAo+ICAJcGxsX2lkID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsX2lkKGRldl9w cml2LCBwaXBlX2NvbmZpZy0+c2hhcmVkX2RwbGwpOwo+IC0JaWYgKHBvcnQgPT0gUE9SVF9BIHx8 IHBvcnQgPT0gUE9SVF9CKSB7Cj4gKwlpZiAoaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJp diwgcG9ydCkpIHsKPiAgCQlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShwaXBlX2NvbmZpZywgSU5U RUxfT1VUUFVUX0hETUkpKQo+ICAJCQlsaW5rX2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGluayhk ZXZfcHJpdiwgcGxsX2lkKTsKPiAgCQllbHNlCj4gQEAgLTIyMzUsNyArMjIzNSw3IEBAIHU4IGlu dGVsX2RkaV9kcF92b2x0YWdlX21heChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAg CWludCBuX2VudHJpZXM7Cj4gIAo+ICAJaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJ aWYgKHBvcnQgPT0gUE9SVF9BIHx8IHBvcnQgPT0gUE9SVF9CKQo+ICsJCWlmIChpbnRlbF9wb3J0 X2lzX2NvbWJvcGh5KGRldl9wcml2LCBwb3J0KSkKPiAgCQkJaWNsX2dldF9jb21ib19idWZfdHJh bnMoZGV2X3ByaXYsIHBvcnQsIGVuY29kZXItPnR5cGUsCj4gIAkJCQkJCSZuX2VudHJpZXMpOwo+ ICAJCWVsc2UKPiBAQCAtMjY2OSw5ICsyNjY5LDEwIEBAIHN0YXRpYyB2b2lkIGljbF9kZGlfdnN3 aW5nX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkJICAgIHUz MiBsZXZlbCwKPiAgCQkJCSAgICBlbnVtIGludGVsX291dHB1dF90eXBlIHR5cGUpCj4gIHsKPiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFz ZS5kZXYpOwo+ICAJZW51bSBwb3J0IHBvcnQgPSBlbmNvZGVyLT5wb3J0Owo+ICAKPiAtCWlmIChw b3J0ID09IFBPUlRfQSB8fCBwb3J0ID09IFBPUlRfQikKPiArCWlmIChpbnRlbF9wb3J0X2lzX2Nv bWJvcGh5KGRldl9wcml2LCBwb3J0KSkKPiAgCQlpY2xfY29tYm9fcGh5X2RkaV92c3dpbmdfc2Vx dWVuY2UoZW5jb2RlciwgbGV2ZWwsIHR5cGUpOwo+ICAJZWxzZQo+ICAJCWljbF9tZ19waHlfZGRp X3Zzd2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsaW5rX2Nsb2NrLCBsZXZlbCk7Cj4gQEAgLTI3NTcs NyArMjc1OCw3IEBAIHZvaWQgaWNsX21hcF9wbGxzX3RvX3BvcnRzKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywKPiAgCQl2YWwgPSBJOTE1X1JFQUQoRFBDTEtBX0NGR0NSMF9JQ0wpOwo+ICAJCVdBUk5f T04oKHZhbCAmIERQQ0xLQV9DRkdDUjBfRERJX0NMS19PRkYocG9ydCkpID09IDApOwo+ICAKPiAt CQlpZiAocG9ydCA9PSBQT1JUX0EgfHwgcG9ydCA9PSBQT1JUX0IpIHsKPiArCQlpZiAoaW50ZWxf cG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsKPiAgCQkJdmFsICY9IH5EUENMS0Ff Q0ZHQ1IwX0RESV9DTEtfU0VMX01BU0socG9ydCk7Cj4gIAkJCXZhbCB8PSBEUENMS0FfQ0ZHQ1Iw X0RESV9DTEtfU0VMKHBsbC0+aW5mby0+aWQsIHBvcnQpOwo+ICAJCQlJOTE1X1dSSVRFKERQQ0xL QV9DRkdDUjBfSUNMLCB2YWwpOwo+IEBAIC0yODEwLDcgKzI4MTEsNyBAQCBzdGF0aWMgdm9pZCBp bnRlbF9kZGlfY2xrX3NlbGVjdChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCW11 dGV4X2xvY2soJmRldl9wcml2LT5kcGxsX2xvY2spOwo+ICAKPiAgCWlmIChJU19JQ0VMQUtFKGRl dl9wcml2KSkgewo+IC0JCWlmIChwb3J0ID49IFBPUlRfQykKPiArCQlpZiAoIWludGVsX3BvcnRf aXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKQo+ICAJCQlJOTE1X1dSSVRFKERESV9DTEtfU0VM KHBvcnQpLAo+ICAJCQkJICAgaWNsX3BsbF90b19kZGlfcGxsX3NlbChlbmNvZGVyLCBwbGwpKTsK PiAgCX0gZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsKPiBAQCAtMjg1Miw3ICsy ODUzLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX2Nsa19kaXNhYmxlKHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyKQo+ICAJZW51bSBwb3J0IHBvcnQgPSBlbmNvZGVyLT5wb3J0Owo+ICAK PiAgCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+IC0JCWlmIChwb3J0ID49IFBPUlRfQykK PiArCQlpZiAoIWludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKQo+ICAJCQlJ OTE1X1dSSVRFKERESV9DTEtfU0VMKHBvcnQpLCBERElfQ0xLX1NFTF9OT05FKTsKPiAgCX0gZWxz ZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsKPiAgCQlJOTE1X1dSSVRFKERQQ0xLQV9D RkdDUjAsIEk5MTVfUkVBRChEUENMS0FfQ0ZHQ1IwKSB8Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IDRjNWMyYjM5ZTY1Yy4uOTE2ZWI3MWU3OGVkIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC01OTQ3LDYgKzU5NDcsMTcgQEAgZW51 bSB0Y19wb3J0IGludGVsX3BvcnRfdG9fdGMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCBlbnVtIHBvcnQgcG9ydCkKPiAgCXJldHVybiBwb3J0IC0gUE9SVF9DOwo+ICB9Cj4gIAo+ ICtib29sIGludGVsX3BvcnRfaXNfY29tYm9waHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiArewo+ICsJaWYgKHBvcnQgPT0gUE9SVF9OT05FKQo+ ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpCj4gKwkJ cmV0dXJuIChwb3J0IDw9IFBPUlRfQik7CgpwbGVhc2UgcmVtb3ZlIHBhcmVudGhlc2lzCgo+ICsK PiArCXJldHVybiBmYWxzZTsKPiArfQo+ICsKPiAgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2Rv bWFpbiBpbnRlbF9wb3J0X3RvX3Bvd2VyX2RvbWFpbihlbnVtIHBvcnQgcG9ydCkKPiAgewo+ICAJ c3dpdGNoIChwb3J0KSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBjYmNhZTI0 NmQ3NDIuLjg2NTY3ZjI2MTM4YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAg LTE0NDMsNiArMTQ0Myw3IEBAIHZvaWQgaWNsX21hcF9wbGxzX3RvX3BvcnRzKHN0cnVjdCBkcm1f Y3J0YyAqY3J0YywKPiAgdm9pZCBpY2xfdW5tYXBfcGxsc190b19wb3J0cyhzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gIAkJCSAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUs Cj4gIAkJCSAgICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSk7Cj4gK2Jvb2wg aW50ZWxfcG9ydF9pc19jb21ib3BoeShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGVudW0gcG9ydCBwb3J0KTsKCnRoaXMgc2hvdWxkIGJlIHRvZ2V0aGVyIHdpdGggdGhlIG90aGVy IGhlbHBlciB3aXRoIHRoZSBzYW1lIG5hbWVzcGFjZSwgaS5lLiBvbiB0b3AKb2YgaW50ZWxfcG9y dF9pc190YygpCgpMdWNhcyBEZSBNYXJjaGkKCj4gIAo+ICB1bnNpZ25lZCBpbnQgaW50ZWxfZmJf YWxpZ25faGVpZ2h0KGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJCQkJICAg aW50IGNvbG9yX3BsYW5lLCB1bnNpZ25lZCBpbnQgaGVpZ2h0KTsKPiAtLSAKPiAyLjE2LjIKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==