Received-SPF: pass (google.com: domain of code@wizofe.uk designates 31.186.226.248 as permitted sender) client-ip=31.186.226.248;
Date: Thu, 4 Oct 2018 13:35:56 +0100
From: Ioannis Valasakis <code@wizofe.uk>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] staging: axis-fifo: Remove
 parentheses in axis-fifo.c
Message-ID: <20181004123556.GA11888@kvasir.local>
References: <20181004101321.GA11491@kvasir.local>
 <20181004115612.GA24641@himanshu-Vostro-3559>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181004115612.GA24641@himanshu-Vostro-3559>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Thu, Oct 04, 2018 at 05:26:12PM +0530, Himanshu Jha wrote:
> On Thu, Oct 04, 2018 at 11:13:21AM +0100, Ioannis Valasakis wrote:
> > staging: axis-fifo: remove parentheses in axis-fifo.c
> 
> This line is not required. Subject already states it.
> 
> > Remove parentheses from the end of line and conform to
> > the coding style guidelines. Reported by checkpatch.
> > 
> > Add an extra space to the function arguments to fix
> > indentation.
> > 
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > ---
> 
> New version with changelog should be written here, just
> right below the `---`
> 
> v2: fixed ... ..
> 
> Also, subject should be:
> 
> [PATCH v2] staging: axis-fifo: Remove parentheses in axis-fifo.c

Thank you Himanshu, I wasn't sure how I need to note that this is 
a different patch.

> 
> I see patches being sent through Mutt and you can easily send
> using `git send-email` instead.
> 

Actually it was easier for me to configure mutt with my own mail 
domain than git send-email. If you reckon that's a best practice though 
I may consider it.

> Often times configuring Mutt to the right config is difficult
> for newbies.
> 

Would you have any recommendation on setting up the 
mutt as to be helpful for my patches?

> >  drivers/staging/axis-fifo/axis-fifo.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> > index 63c8efd1b8db..76907ac26300 100644
> > --- a/drivers/staging/axis-fifo/axis-fifo.c
> > +++ b/drivers/staging/axis-fifo/axis-fifo.c
> > @@ -364,11 +364,11 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> >  		 * if nothing is currently available
> >  		 */
> >  		spin_lock_irq(&fifo->read_queue_lock);
> > -		ret = wait_event_interruptible_lock_irq_timeout(
> > -			fifo->read_queue,
> > -			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> > -			fifo->read_queue_lock,
> > -			(read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :
> > +		ret = wait_event_interruptible_lock_irq_timeout
> > +			(fifo->read_queue,
> > +			 ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> > +			 fifo->read_queue_lock,
> > +			 (read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :
> 
> I don't really like this change.
> But anyway, wait for the maintainer to reply.
> 
> 
> -- 
> Himanshu Jha
> Undergraduate Student
> Department of Electronics & Communication
> Guru Tegh Bahadur Institute of Technology