From: Lucas De Marchi Subject: Re: [PATCH v2 1/8] drm/i915/icl: create function to identify combophy port Date: Thu, 4 Oct 2018 13:00:28 -0700 Message-ID: <20181004200026.GA3279@ldmartin-desk.jf.intel.com> References: <20181003180329.GA4011@ldmartin-desk.jf.intel.com> <20181004085043.10154-1-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82A936E65A for ; Thu, 4 Oct 2018 20:00:52 +0000 (UTC) Received: by mail-pl1-x635.google.com with SMTP id f18-v6so5684464plr.1 for ; Thu, 04 Oct 2018 13:00:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181004085043.10154-1-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDI6MjA6NDNQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IFRoaXMgcGF0Y2ggY3JlYXRlcyBhIGZ1bmN0aW9uL3dyYXBwZXIgdG8gY2hlY2sgaWYg cG9ydCBpcyBjb21ib3BoeSBwb3J0Cj4gaW5zdGVhZCBvZiBleHBsaWNpdGx5IGNvbXBhcmluZyBw b3J0cy4KPiAKPiBDaGFuZ2VzIHNpbmNlIFYxOgo+ICAtIGtlZXAgYWxsIGludGVsX3BvcnRfaXNf KiBoZWxwZXIgdG9nZXRoZXIgKEx1Y2FzKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1haGVzaCBLdW1h ciA8bWFoZXNoMS5rdW1hckBpbnRlbC5jb20+Cj4gQ2M6IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYu Y2hhdWhhbkBpbnRlbC5jb20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp bnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVs LmNvbT4KClJldmlld2VkLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVs LmNvbT4KCkx1Y2FzIERlIE1hcmNoaQoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMgICAgIHwgMTUgKysrKysrKystLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyB8IDExICsrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oICAgICB8ICAxICsKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXgg YjY1OTQ5NDhiNjE3Li42OWI3MzU1ODQ1YWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku Ywo+IEBAIC05MTYsNyArOTE2LDcgQEAgc3RhdGljIGludCBpbnRlbF9kZGlfaGRtaV9sZXZlbChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBwb3IKPiAgCWxldmVs ID0gZGV2X3ByaXYtPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRdLmhkbWlfbGV2ZWxfc2hpZnQ7Cj4g IAo+ICAJaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJaWYgKHBvcnQgPT0gUE9SVF9B IHx8IHBvcnQgPT0gUE9SVF9CKQo+ICsJCWlmIChpbnRlbF9wb3J0X2lzX2NvbWJvcGh5KGRldl9w cml2LCBwb3J0KSkKPiAgCQkJaWNsX2dldF9jb21ib19idWZfdHJhbnMoZGV2X3ByaXYsIHBvcnQs Cj4gIAkJCQkJCUlOVEVMX09VVFBVVF9IRE1JLCAmbl9lbnRyaWVzKTsKPiAgCQllbHNlCj4gQEAg LTE1MzUsNyArMTUzNSw3IEBAIHN0YXRpYyB2b2lkIGljbF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJdWludDMyX3QgcGxsX2lkOwo+ICAKPiAgCXBsbF9p ZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJl ZF9kcGxsKTsKPiAtCWlmIChwb3J0ID09IFBPUlRfQSB8fCBwb3J0ID09IFBPUlRfQikgewo+ICsJ aWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gIAkJaWYgKGlu dGVsX2NydGNfaGFzX3R5cGUocGlwZV9jb25maWcsIElOVEVMX09VVFBVVF9IRE1JKSkKPiAgCQkJ bGlua19jbG9jayA9IGNubF9jYWxjX3dycGxsX2xpbmsoZGV2X3ByaXYsIHBsbF9pZCk7Cj4gIAkJ ZWxzZQo+IEBAIC0yMjM1LDcgKzIyMzUsNyBAQCB1OCBpbnRlbF9kZGlfZHBfdm9sdGFnZV9tYXgo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIAlpbnQgbl9lbnRyaWVzOwo+ICAKPiAg CWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+IC0JCWlmIChwb3J0ID09IFBPUlRfQSB8fCBw b3J0ID09IFBPUlRfQikKPiArCQlpZiAoaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwg cG9ydCkpCj4gIAkJCWljbF9nZXRfY29tYm9fYnVmX3RyYW5zKGRldl9wcml2LCBwb3J0LCBlbmNv ZGVyLT50eXBlLAo+ICAJCQkJCQkmbl9lbnRyaWVzKTsKPiAgCQllbHNlCj4gQEAgLTI2NjksOSAr MjY2OSwxMCBAQCBzdGF0aWMgdm9pZCBpY2xfZGRpX3Zzd2luZ19zZXF1ZW5jZShzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkJCSAgICB1MzIgbGV2ZWwsCj4gIAkJCQkgICAgZW51 bSBpbnRlbF9vdXRwdXRfdHlwZSB0eXBlKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAgCWVudW0gcG9ydCBw b3J0ID0gZW5jb2Rlci0+cG9ydDsKPiAgCj4gLQlpZiAocG9ydCA9PSBQT1JUX0EgfHwgcG9ydCA9 PSBQT1JUX0IpCj4gKwlpZiAoaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkp Cj4gIAkJaWNsX2NvbWJvX3BoeV9kZGlfdnN3aW5nX3NlcXVlbmNlKGVuY29kZXIsIGxldmVsLCB0 eXBlKTsKPiAgCWVsc2UKPiAgCQlpY2xfbWdfcGh5X2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2Rl ciwgbGlua19jbG9jaywgbGV2ZWwpOwo+IEBAIC0yNzU3LDcgKzI3NTgsNyBAQCB2b2lkIGljbF9t YXBfcGxsc190b19wb3J0cyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJdmFsID0gSTkxNV9S RUFEKERQQ0xLQV9DRkdDUjBfSUNMKTsKPiAgCQlXQVJOX09OKCh2YWwgJiBEUENMS0FfQ0ZHQ1Iw X0RESV9DTEtfT0ZGKHBvcnQpKSA9PSAwKTsKPiAgCj4gLQkJaWYgKHBvcnQgPT0gUE9SVF9BIHx8 IHBvcnQgPT0gUE9SVF9CKSB7Cj4gKwkJaWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3By aXYsIHBvcnQpKSB7Cj4gIAkJCXZhbCAmPSB+RFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTF9NQVNL KHBvcnQpOwo+ICAJCQl2YWwgfD0gRFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTChwbGwtPmluZm8t PmlkLCBwb3J0KTsKPiAgCQkJSTkxNV9XUklURShEUENMS0FfQ0ZHQ1IwX0lDTCwgdmFsKTsKPiBA QCAtMjgxMCw3ICsyODExLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX2Nsa19zZWxlY3Qoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHBs bF9sb2NrKTsKPiAgCj4gIAlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpIHsKPiAtCQlpZiAocG9y dCA+PSBQT1JUX0MpCj4gKwkJaWYgKCFpbnRlbF9wb3J0X2lzX2NvbWJvcGh5KGRldl9wcml2LCBw b3J0KSkKPiAgCQkJSTkxNV9XUklURShERElfQ0xLX1NFTChwb3J0KSwKPiAgCQkJCSAgIGljbF9w bGxfdG9fZGRpX3BsbF9zZWwoZW5jb2RlciwgcGxsKSk7Cj4gIAl9IGVsc2UgaWYgKElTX0NBTk5P TkxBS0UoZGV2X3ByaXYpKSB7Cj4gQEAgLTI4NTIsNyArMjg1Myw3IEBAIHN0YXRpYyB2b2lkIGlu dGVsX2RkaV9jbGtfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCWVu dW0gcG9ydCBwb3J0ID0gZW5jb2Rlci0+cG9ydDsKPiAgCj4gIAlpZiAoSVNfSUNFTEFLRShkZXZf cHJpdikpIHsKPiAtCQlpZiAocG9ydCA+PSBQT1JUX0MpCj4gKwkJaWYgKCFpbnRlbF9wb3J0X2lz X2NvbWJvcGh5KGRldl9wcml2LCBwb3J0KSkKPiAgCQkJSTkxNV9XUklURShERElfQ0xLX1NFTChw b3J0KSwgRERJX0NMS19TRUxfTk9ORSk7Cj4gIAl9IGVsc2UgaWYgKElTX0NBTk5PTkxBS0UoZGV2 X3ByaXYpKSB7Cj4gIAkJSTkxNV9XUklURShEUENMS0FfQ0ZHQ1IwLCBJOTE1X1JFQUQoRFBDTEtB X0NGR0NSMCkgfAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAzNjQz NGM1MzU5YjEuLjYwYWEwMzM0MDViZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiBAQCAtNTk0NCw2ICs1OTQ0LDE3IEBAIHN0YXRpYyB2b2lkIGk5eHhfcGZpdF9lbmFi bGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAlJOTE1X1dSSVRFKEJDTFJQQVQoY3J0Yy0+ cGlwZSksIDApOwo+ICB9Cj4gIAo+ICtib29sIGludGVsX3BvcnRfaXNfY29tYm9waHkoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiArewo+ICsJaWYg KHBvcnQgPT0gUE9SVF9OT05FKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoSVNfSUNF TEFLRShkZXZfcHJpdikpCj4gKwkJcmV0dXJuIHBvcnQgPD0gUE9SVF9COwo+ICsKPiArCXJldHVy biBmYWxzZTsKPiArfQo+ICsKPiAgYm9vbCBpbnRlbF9wb3J0X2lzX3RjKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpCj4gIHsKPiAgCWlmIChJU19JQ0VM QUtFKGRldl9wcml2KSkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDQzMTkwYzZl OWVmMi4uMDY2MWEzMTE1Zjc2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAt MTUxNSw2ICsxNTE1LDcgQEAgdm9pZCBpbnRlbF9jb25uZWN0b3JfYXR0YWNoX2VuY29kZXIoc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQkJICAgIHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyKTsKPiAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKgo+ICBpbnRlbF9l bmNvZGVyX2N1cnJlbnRfbW9kZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rlcik7Cj4gK2Jv b2wgaW50ZWxfcG9ydF9pc19jb21ib3BoeShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsIGVudW0gcG9ydCBwb3J0KTsKPiAgYm9vbCBpbnRlbF9wb3J0X2lzX3RjKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpOwo+ICBlbnVtIHRjX3BvcnQg aW50ZWxfcG9ydF90b190YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJ CSAgICAgIGVudW0gcG9ydCBwb3J0KTsKPiAtLSAKPiAyLjE2LjIKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==