From: Lucas De Marchi Subject: Re: [PATCH 3/8] drm/i915/icl: Refactor get_ddi_pll using helper func Date: Thu, 4 Oct 2018 14:18:59 -0700 Message-ID: <20181004211857.GC3279@ldmartin-desk.jf.intel.com> References: <20181003072203.12848-1-mahesh1.kumar@intel.com> <20181003072203.12848-4-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BF8A6E0B2 for ; Thu, 4 Oct 2018 21:19:02 +0000 (UTC) Received: by mail-pg1-x536.google.com with SMTP id g12-v6so3746345pgs.1 for ; Thu, 04 Oct 2018 14:19:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181003072203.12848-4-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi , rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTI6NTE6NThQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IEZyb206IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29t Pgo+IAo+IFVzZSB0aGUgZXhpc3RpbmcgcG9ydC10by1pZCBoZWxwZXIgZnVuY3Rpb24sIHRvIHJl ZmFjdG9yCj4gaGVuY2UgbWFraW5nIGl0IHNjYWxhYmxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZh bmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IE1haGVzaCBLdW1hciA8bWFoZXNoMS5rdW1hckBpbnRlbC5jb20+Cj4gQ2M6IEx1Y2FzIERl IE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgo+IENjOiBNYWRoYXYgQ2hhdWhhbiA8 bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29tPgoKClJldmlld2VkLWJ5OiBMdWNhcyBEZSBNYXJjaGkg PGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KCgpMdWNhcyBEZSBNYXJjaGkKCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgfCA4ICstLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwbGxfbWdyLmggfCAxICsKPiAgMyBmaWxlcyBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IGluZGV4IDkxNmViNzFlNzhlZC4uMTZkOWEyMGE0MjBhIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC05MzA3LDE2ICs5MzA3LDEwIEBAIHN0YXRpYyB2 b2lkIGljZWxha2VfZ2V0X2RkaV9wbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAJCQlyZXR1cm47Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIFBPUlRfQzoKPiAtCQlpZCA9IERQ TExfSURfSUNMX01HUExMMTsKPiAtCQlicmVhazsKPiAgCWNhc2UgUE9SVF9EOgo+IC0JCWlkID0g RFBMTF9JRF9JQ0xfTUdQTEwyOwo+IC0JCWJyZWFrOwo+ICAJY2FzZSBQT1JUX0U6Cj4gLQkJaWQg PSBEUExMX0lEX0lDTF9NR1BMTDM7Cj4gLQkJYnJlYWs7Cj4gIAljYXNlIFBPUlRfRjoKPiAtCQlp ZCA9IERQTExfSURfSUNMX01HUExMNDsKPiArCQlpZCA9IGljbF9wb3J0X3RvX21nX3BsbF9pZChw b3J0KTsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gIAkJTUlTU0lOR19DQVNFKHBvcnQpOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IGluZGV4IGU2Y2FjOTIyNTUzNi4u NTEwZWE5MGY2ZjViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw bGxfbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4g QEAgLTI2MjgsNyArMjYyOCw3IEBAIHN0YXRpYyBlbnVtIHBvcnQgaWNsX21nX3BsbF9pZF90b19w b3J0KGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiAgCXJldHVybiBpZCAtIERQTExfSURfSUNMX01H UExMMSArIFBPUlRfQzsKPiAgfQo+ICAKPiAtc3RhdGljIGVudW0gaW50ZWxfZHBsbF9pZCBpY2xf cG9ydF90b19tZ19wbGxfaWQoZW51bSBwb3J0IHBvcnQpCj4gK2VudW0gaW50ZWxfZHBsbF9pZCBp Y2xfcG9ydF90b19tZ19wbGxfaWQoZW51bSBwb3J0IHBvcnQpCj4gIHsKPiAgCXJldHVybiBwb3J0 IC0gUE9SVF9DICsgRFBMTF9JRF9JQ0xfTUdQTEwxOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcGxsX21nci5oCj4gaW5kZXggYmYwZGU4YTRkYzYzLi41MzA1Y2UxYzIxNzUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiBAQCAtMzQ1LDUgKzM0NSw2IEBA IHZvaWQgaW50ZWxfZHBsbF9kdW1wX2h3X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPiAgaW50IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICAgICAgIHVpbnQzMl90IHBsbF9pZCk7Cj4gIGlu dCBjbmxfaGRtaV9wbGxfcmVmX2Nsb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dik7Cj4gK2VudW0gaW50ZWxfZHBsbF9pZCBpY2xfcG9ydF90b19tZ19wbGxfaWQoZW51bSBwb3J0 IHBvcnQpOwo+ICAKPiAgI2VuZGlmIC8qIF9JTlRFTF9EUExMX01HUl9IXyAqLwo+IC0tIAo+IDIu MTYuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK