From: Lucas De Marchi Subject: Re: [PATCH 4/8] drm/i915/icl: Use helper functions to classify the ports Date: Thu, 4 Oct 2018 14:21:02 -0700 Message-ID: <20181004212101.GD3279@ldmartin-desk.jf.intel.com> References: <20181003072203.12848-1-mahesh1.kumar@intel.com> <20181003072203.12848-5-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2582589CD7 for ; Thu, 4 Oct 2018 21:21:06 +0000 (UTC) Received: by mail-pl1-x631.google.com with SMTP id y11-v6so2632208plt.3 for ; Thu, 04 Oct 2018 14:21:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181003072203.12848-5-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi , rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTI6NTE6NTlQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IEZyb206IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29t Pgo+IAo+IFVzZSBpbnRlbF9wb3J0X2lzX3RjIGFuZCBpbnRlbF9wb3J0X2lzX2NvbWJvcGh5Cj4g ZnVuY3Rpb25zIHRvIHJlcGxhY2UgdGhlIGluZGl2aWR1YWwgcG9ydCBjaGVja3MKPiBmcm9tIHBv cnQgQyB0byBGIGFuZCBwb3J0IEEgdG8gQiByZXNwZWN0aXZlbHkuCj4gCj4gU2lnbmVkLW9mZi1i eTogVmFuZGl0YSBLdWxrYXJuaSA8dmFuZGl0YS5rdWxrYXJuaUBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiBDYzogTHVj YXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gQ2M6IE1hZGhhdiBDaGF1 aGFuIDxtYWRoYXYuY2hhdWhhbkBpbnRlbC5jb20+CgoKUmV2aWV3ZWQtYnk6IEx1Y2FzIERlIE1h cmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgoKTHVjYXMgRGUgTWFyY2hpCgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgIHwgMTUgKysrKy0tLS0tLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAxNCArKysrLS0t LS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDE2ZDlhMjBh NDIwYS4uZTMxZDcxNTI2YWZkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC05Mjk2LDI0ICs5Mjk2LDE3IEBAIHN0YXRpYyB2b2lkIGljZWxha2VfZ2V0X2RkaV9w bGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJdTMyIHRlbXA7Cj4gIAo+ ICAJLyogVE9ETzogVEJUIHBsbCBub3QgaW1wbGVtZW50ZWQuICovCj4gLQlzd2l0Y2ggKHBvcnQp IHsKPiAtCWNhc2UgUE9SVF9BOgo+IC0JY2FzZSBQT1JUX0I6Cj4gKwlpZiAoaW50ZWxfcG9ydF9p c19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsKPiAgCQl0ZW1wID0gSTkxNV9SRUFEKERQQ0xL QV9DRkdDUjBfSUNMKSAmCj4gIAkJICAgICAgIERQQ0xLQV9DRkdDUjBfRERJX0NMS19TRUxfTUFT Syhwb3J0KTsKPiAgCQlpZCA9IHRlbXAgPj4gRFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTF9TSElG VChwb3J0KTsKPiAgCj4gIAkJaWYgKFdBUk5fT04oaWQgIT0gRFBMTF9JRF9JQ0xfRFBMTDAgJiYg aWQgIT0gRFBMTF9JRF9JQ0xfRFBMTDEpKQo+ICAJCQlyZXR1cm47Cj4gLQkJYnJlYWs7Cj4gLQlj YXNlIFBPUlRfQzoKPiAtCWNhc2UgUE9SVF9EOgo+IC0JY2FzZSBQT1JUX0U6Cj4gLQljYXNlIFBP UlRfRjoKPiArCX0gZWxzZSBpZiAoaW50ZWxfcG9ydF9pc190YyhkZXZfcHJpdiwgcG9ydCkpIHsK PiAgCQlpZCA9IGljbF9wb3J0X3RvX21nX3BsbF9pZChwb3J0KTsKPiAtCQlicmVhazsKPiAtCWRl ZmF1bHQ6Cj4gLQkJTUlTU0lOR19DQVNFKHBvcnQpOwo+ICsJfSBlbHNlIHsKPiArCQlXQVJOKDEs ICJJbnZhbGlkIHBvcnQgJXhcbiIsIHBvcnQpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggNTEwZWE5MGY2ZjViLi41YjJl ZTQ5YWVlMTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9t Z3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBAQCAt Mjg3NCw2ICsyODc0LDcgQEAgc3RhdGljIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqCj4gIGlj bF9nZXRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yywgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUsCj4gIAkgICAgIHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ ICB7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29k ZXItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19w b3J0ID0KPiAgCQkJZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiAgCXN0cnVjdCBp bnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+IEBAIC0yODgzLDE4ICsyODg0LDEyIEBAIGljbF9nZXRf ZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yywgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUsCj4gIAlpbnQgY2xvY2sgPSBjcnRjX3N0YXRlLT5wb3J0X2Nsb2NrOwo+ICAJYm9v bCByZXQ7Cj4gIAo+IC0Jc3dpdGNoIChwb3J0KSB7Cj4gLQljYXNlIFBPUlRfQToKPiAtCWNhc2Ug UE9SVF9COgo+ICsJaWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKSB7 Cj4gIAkJbWluID0gRFBMTF9JRF9JQ0xfRFBMTDA7Cj4gIAkJbWF4ID0gRFBMTF9JRF9JQ0xfRFBM TDE7Cj4gIAkJcmV0ID0gaWNsX2NhbGNfZHBsbF9zdGF0ZShjcnRjX3N0YXRlLCBlbmNvZGVyLCBj bG9jaywKPiAgCQkJCQkgICZwbGxfc3RhdGUpOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSBQT1JUX0M6 Cj4gLQljYXNlIFBPUlRfRDoKPiAtCWNhc2UgUE9SVF9FOgo+IC0JY2FzZSBQT1JUX0Y6Cj4gKwl9 IGVsc2UgaWYgKGludGVsX3BvcnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gIAkJaWYgKGlu dGVsX2RpZ19wb3J0LT50Y190eXBlID09IFRDX1BPUlRfVEJUKSB7Cj4gIAkJCW1pbiA9IERQTExf SURfSUNMX1RCVFBMTDsKPiAgCQkJbWF4ID0gbWluOwo+IEBAIC0yOTA2LDggKzI5MDEsNyBAQCBp Y2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlLAo+ICAJCQlyZXQgPSBpY2xfY2FsY19tZ19wbGxfc3RhdGUoY3J0Y19z dGF0ZSwgZW5jb2RlciwgY2xvY2ssCj4gIAkJCQkJCSAgICAmcGxsX3N0YXRlKTsKPiAgCQl9Cj4g LQkJYnJlYWs7Cj4gLQlkZWZhdWx0Ogo+ICsJfSBlbHNlIHsKPiAgCQlNSVNTSU5HX0NBU0UocG9y dCk7Cj4gIAkJcmV0dXJuIE5VTEw7Cj4gIAl9Cj4gLS0gCj4gMi4xNi4yCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=