From: Lucas De Marchi Subject: Re: [PATCH 5/8] drm/i915/icl: Refactor icl pll functions Date: Thu, 4 Oct 2018 14:24:43 -0700 Message-ID: <20181004212442.GE3279@ldmartin-desk.jf.intel.com> References: <20181003072203.12848-1-mahesh1.kumar@intel.com> <20181003072203.12848-6-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3BB86E673 for ; Thu, 4 Oct 2018 21:24:46 +0000 (UTC) Received: by mail-pf1-x443.google.com with SMTP id b7-v6so4008721pfo.3 for ; Thu, 04 Oct 2018 14:24:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181003072203.12848-6-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi , rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTI6NTI6MDBQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IEZyb206IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29t Pgo+IAo+IFRoaXMgcGF0Y2ggYWRkcyBoZWxwZXIgZnVuY3Rpb24gZm9yIGlkZW50aWZ5aW5nCj4g d2hldGhlciB0aGUgZ2l2ZW4gUExMIGlzIGNvbWJvIFBIWSBQTEwgb3Igbm90Lgo+IFRoaXMgaGVs cGVyIGZ1bmN0aW9uIGlzIHVzZWQgaW5zaWRlIHZhcmlvdXMgSUNMCj4gZnVuY3Rpb25zIHRvIG1h a2UgdGhlbSBzY2FsYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWYW5kaXRhIEt1bGthcm5pIDx2 YW5kaXRhLmt1bGthcm5pQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIg PG1haGVzaDEua3VtYXJAaW50ZWwuY29tPgo+IENjOiBNYWRoYXYgQ2hhdWhhbiA8bWFkaGF2LmNo YXVoYW5AaW50ZWwuY29tPgo+IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGlu dGVsLmNvbT4KCgpSZXZpZXdlZC1ieTogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBp bnRlbC5jb20+CgpMdWNhcyBEZSBNYXJjaGkKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyAgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cGxsX21nci5jIHwgNTQgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCB8ICAxICsKPiAgMyBmaWxlcyBjaGFu Z2VkLCAxOSBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZTMxZDcxNTI2YWZkLi5hMWM2ODkxY2YxNGIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTkzMDEsNyArOTMwMSw3 IEBAIHN0YXRpYyB2b2lkIGljZWxha2VfZ2V0X2RkaV9wbGwoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ICAJCSAgICAgICBEUENMS0FfQ0ZHQ1IwX0RESV9DTEtfU0VMX01BU0so cG9ydCk7Cj4gIAkJaWQgPSB0ZW1wID4+IERQQ0xLQV9DRkdDUjBfRERJX0NMS19TRUxfU0hJRlQo cG9ydCk7Cj4gIAo+IC0JCWlmIChXQVJOX09OKGlkICE9IERQTExfSURfSUNMX0RQTEwwICYmIGlk ICE9IERQTExfSURfSUNMX0RQTEwxKSkKPiArCQlpZiAoV0FSTl9PTighaW50ZWxfZHBsbF9pc19j b21ib3BoeShpZCkpKQo+ICAJCQlyZXR1cm47Cj4gIAl9IGVsc2UgaWYgKGludGVsX3BvcnRfaXNf dGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gIAkJaWQgPSBpY2xfcG9ydF90b19tZ19wbGxfaWQocG9y dCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggNWIyZWU0OWFl ZTE0Li45M2U4ZTIzMDc5ODkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdy LmMKPiBAQCAtMjYzMyw2ICsyNjMzLDExIEBAIGVudW0gaW50ZWxfZHBsbF9pZCBpY2xfcG9ydF90 b19tZ19wbGxfaWQoZW51bSBwb3J0IHBvcnQpCj4gIAlyZXR1cm4gcG9ydCAtIFBPUlRfQyArIERQ TExfSURfSUNMX01HUExMMTsKPiAgfQo+ICAKPiArYm9vbCBpbnRlbF9kcGxsX2lzX2NvbWJvcGh5 KGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiArewo+ICsJcmV0dXJuIGlkID09IERQTExfSURfSUNM X0RQTEwwIHx8IGlkID09IERQTExfSURfSUNMX0RQTEwxOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9v bCBpY2xfbWdfcGxsX2ZpbmRfZGl2aXNvcnMoaW50IGNsb2NrX2toeiwgYm9vbCBpc19kcCwgYm9v bCB1c2Vfc3NjLAo+ICAJCQkJICAgICB1aW50MzJfdCAqdGFyZ2V0X2Rjb19raHosCj4gIAkJCQkg ICAgIHN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlICpzdGF0ZSkKPiBAQCAtMjkyNiwyMSArMjkz MSwxNiBAQCBpY2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAKPiAgc3RhdGljIGk5MTVfcmVnX3QgaWNsX3Bs bF9pZF90b19lbmFibGVfcmVnKGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiAgewo+IC0Jc3dpdGNo IChpZCkgewo+IC0JZGVmYXVsdDoKPiAtCQlNSVNTSU5HX0NBU0UoaWQpOwo+IC0JCS8qIGZhbGwg dGhyb3VnaCAqLwo+IC0JY2FzZSBEUExMX0lEX0lDTF9EUExMMDoKPiAtCWNhc2UgRFBMTF9JRF9J Q0xfRFBMTDE6Cj4gKwlpZiAoaW50ZWxfZHBsbF9pc19jb21ib3BoeShpZCkpCj4gIAkJcmV0dXJu IENOTF9EUExMX0VOQUJMRShpZCk7Cj4gLQljYXNlIERQTExfSURfSUNMX1RCVFBMTDoKPiArCWVs c2UgaWYgKGlkID09IERQTExfSURfSUNMX1RCVFBMTCkKPiAgCQlyZXR1cm4gVEJUX1BMTF9FTkFC TEU7Cj4gLQljYXNlIERQTExfSURfSUNMX01HUExMMToKPiAtCWNhc2UgRFBMTF9JRF9JQ0xfTUdQ TEwyOgo+IC0JY2FzZSBEUExMX0lEX0lDTF9NR1BMTDM6Cj4gLQljYXNlIERQTExfSURfSUNMX01H UExMNDoKPiArCWVsc2UKPiArCQkvKgo+ICsJCSAqIFRPRE86IE1ha2UgTUdfUExMIG1hY3JvcyB1 c2UKPiArCQkgKiB0YyBwb3J0IGlkIGluc3RlYWQgb2YgcG9ydCBpZAo+ICsJCSAqLwo+ICAJCXJl dHVybiBNR19QTExfRU5BQkxFKGljbF9tZ19wbGxfaWRfdG9fcG9ydChpZCkpOwo+IC0JfQo+ICB9 Cj4gIAo+ICBzdGF0aWMgYm9vbCBpY2xfcGxsX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gQEAgLTI5NTksMTcgKzI5NTksMTEgQEAgc3RhdGljIGJvb2wg aWNsX3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAJaWYgKCEodmFsICYgUExMX0VOQUJMRSkpCj4gIAkJZ290byBvdXQ7Cj4gIAo+IC0Jc3dpdGNo IChpZCkgewo+IC0JY2FzZSBEUExMX0lEX0lDTF9EUExMMDoKPiAtCWNhc2UgRFBMTF9JRF9JQ0xf RFBMTDE6Cj4gLQljYXNlIERQTExfSURfSUNMX1RCVFBMTDoKPiArCWlmIChpbnRlbF9kcGxsX2lz X2NvbWJvcGh5KGlkKSB8fAo+ICsJICAgIGlkID09IERQTExfSURfSUNMX1RCVFBMTCkgewo+ICAJ CWh3X3N0YXRlLT5jZmdjcjAgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IwKGlkKSk7Cj4gIAkJ aHdfc3RhdGUtPmNmZ2NyMSA9IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjEoaWQpKTsKPiAtCQli cmVhazsKPiAtCWNhc2UgRFBMTF9JRF9JQ0xfTUdQTEwxOgo+IC0JY2FzZSBEUExMX0lEX0lDTF9N R1BMTDI6Cj4gLQljYXNlIERQTExfSURfSUNMX01HUExMMzoKPiAtCWNhc2UgRFBMTF9JRF9JQ0xf TUdQTEw0Ogo+ICsJfSBlbHNlIHsKPiAgCQlwb3J0ID0gaWNsX21nX3BsbF9pZF90b19wb3J0KGlk KTsKPiAgCQlod19zdGF0ZS0+bWdfcmVmY2xraW5fY3RsID0gSTkxNV9SRUFEKE1HX1JFRkNMS0lO X0NUTChwb3J0KSk7Cj4gIAkJaHdfc3RhdGUtPm1nX3JlZmNsa2luX2N0bCAmPSBNR19SRUZDTEtJ Tl9DVExfT0RfMl9NVVhfTUFTSzsKPiBAQCAtMzAwNyw5ICszMDAxLDYgQEAgc3RhdGljIGJvb2wg aWNsX3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAKPiAgCQlod19zdGF0ZS0+bWdfcGxsX3RkY19jb2xkc3RfYmlhcyAmPSBod19zdGF0ZS0+bWdf cGxsX3RkY19jb2xkc3RfYmlhc19tYXNrOwo+ICAJCWh3X3N0YXRlLT5tZ19wbGxfYmlhcyAmPSBo d19zdGF0ZS0+bWdfcGxsX2JpYXNfbWFzazsKPiAtCQlicmVhazsKPiAtCWRlZmF1bHQ6Cj4gLQkJ TUlTU0lOR19DQVNFKGlkKTsKPiAgCX0KPiAgCj4gIAlyZXQgPSB0cnVlOwo+IEBAIC0zMDk4LDIx ICszMDg5LDEwIEBAIHN0YXRpYyB2b2lkIGljbF9wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCSAgICBQTExfUE9XRVJfU1RBVEUsIDEpKQo+ICAJCURS TV9FUlJPUigiUExMICVkIFBvd2VyIG5vdCBlbmFibGVkXG4iLCBpZCk7Cj4gIAo+IC0Jc3dpdGNo IChpZCkgewo+IC0JY2FzZSBEUExMX0lEX0lDTF9EUExMMDoKPiAtCWNhc2UgRFBMTF9JRF9JQ0xf RFBMTDE6Cj4gLQljYXNlIERQTExfSURfSUNMX1RCVFBMTDoKPiArCWlmIChpbnRlbF9kcGxsX2lz X2NvbWJvcGh5KGlkKSB8fCBpZCA9PSBEUExMX0lEX0lDTF9UQlRQTEwpCj4gIAkJaWNsX2RwbGxf d3JpdGUoZGV2X3ByaXYsIHBsbCk7Cj4gLQkJYnJlYWs7Cj4gLQljYXNlIERQTExfSURfSUNMX01H UExMMToKPiAtCWNhc2UgRFBMTF9JRF9JQ0xfTUdQTEwyOgo+IC0JY2FzZSBEUExMX0lEX0lDTF9N R1BMTDM6Cj4gLQljYXNlIERQTExfSURfSUNMX01HUExMNDoKPiArCWVsc2UKPiAgCQlpY2xfbWdf cGxsX3dyaXRlKGRldl9wcml2LCBwbGwpOwo+IC0JCWJyZWFrOwo+IC0JZGVmYXVsdDoKPiAtCQlN SVNTSU5HX0NBU0UoaWQpOwo+IC0JfQo+ICAKPiAgCS8qCj4gIAkgKiBEVkZTIHByZSBzZXF1ZW5j ZSB3b3VsZCBiZSBoZXJlLCBidXQgaW4gb3VyIGRyaXZlciB0aGUgY2RjbGsgY29kZQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+IGluZGV4IDUzMDVjZTFjMjE3NS4uNmE3OWNl ZDkyM2U5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdy LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCj4gQEAgLTM0 Niw1ICszNDYsNiBAQCBpbnQgaWNsX2NhbGNfZHBfY29tYm9fcGxsX2xpbmsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICAgICAgdWludDMyX3QgcGxsX2lkKTsKPiAg aW50IGNubF9oZG1pX3BsbF9yZWZfY2xvY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KTsKPiAgZW51bSBpbnRlbF9kcGxsX2lkIGljbF9wb3J0X3RvX21nX3BsbF9pZChlbnVtIHBv cnQgcG9ydCk7Cj4gK2Jvb2wgaW50ZWxfZHBsbF9pc19jb21ib3BoeShlbnVtIGludGVsX2RwbGxf aWQgaWQpOwo+ICAKPiAgI2VuZGlmIC8qIF9JTlRFTF9EUExMX01HUl9IXyAqLwo+IC0tIAo+IDIu MTYuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK