From: Lucas De Marchi Subject: Re: [PATCH 8/8] drm/i915/icl: Fix DDI/TC port clk_off bits Date: Thu, 4 Oct 2018 14:26:52 -0700 Message-ID: <20181004212651.GF3279@ldmartin-desk.jf.intel.com> References: <20181003072203.12848-1-mahesh1.kumar@intel.com> <20181003072203.12848-9-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC77E6E674 for ; Thu, 4 Oct 2018 21:26:56 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id y11-v6so2638406plt.3 for ; Thu, 04 Oct 2018 14:26:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181003072203.12848-9-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar , h@ldmartin-desk.jf.intel.com Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi , rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTI6NTI6MDNQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IERESS9UQyBjbG9jay1vZmYgYml0cyBhcmUgbm90IGVxdWFsbHkgZGlzdGFuY2VkLiBU QzEtMyBiaXRzIGFyZQo+IGZyb20gb2Zmc2V0IDEyICYgVEM0IGlzIGF0IG9mZnNldCAyMS4KPiBD cmVhdGUgYSBmdW5jdGlvbiB0byBjaG9vc2UgY29ycmVjdCBjbGstb2ZmIGJpdC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50ZWwuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29tPgo+ IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KCk1pc3Npbmcg Rml4ZXMgdGFnLgoKCkx1Y2FzIERlIE1hcmNoaQoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaCAgfCAgMyArKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp LmMgfCAyMSArKysrKysrKysrKysrKysrKystLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGlu ZGV4IGVhZjNlMGQ1MjlkMy4uZTFhMjg1MWEyOGNmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oCj4gQEAgLTkzMDIsNiArOTMwMiw5IEBAIGVudW0gc2tsX3Bvd2VyX2dhdGUgewo+ICAjZGVm aW5lIERQQ0xLQV9DRkdDUjBfSUNMCQkJX01NSU8oMHgxNjQyODApCj4gICNkZWZpbmUgIERQQ0xL QV9DRkdDUjBfRERJX0NMS19PRkYocG9ydCkJKDEgPDwgKChwb3J0KSA9PSAgUE9SVF9GID8gMjMg OiBcCj4gIAkJCQkJCSAgICAgIChwb3J0KSArIDEwKSkKPiArI2RlZmluZSAgSUNMX0RQQ0xLQV9D RkdDUjBfRERJX0NMS19PRkYocG9ydCkgICAoMSA8PCAoKHBvcnQpICsgMTApKQo+ICsjZGVmaW5l ICBJQ0xfRFBDTEtBX0NGR0NSMF9UQ19DTEtfT0ZGKHRjX3BvcnQpICgxIDw8ICgodGNfcG9ydCkg PT0gUE9SVF9UQzQgPyBcCj4gKwkJCQkJCSAgICAgIDIxIDogKHRjX3BvcnQpICsgMTIpKQo+ICAj ZGVmaW5lICBEUENMS0FfQ0ZHQ1IwX0RESV9DTEtfU0VMX1NISUZUKHBvcnQpCSgocG9ydCkgPT0g UE9SVF9GID8gMjEgOiBcCj4gIAkJCQkJCShwb3J0KSAqIDIpCj4gICNkZWZpbmUgIERQQ0xLQV9D RkdDUjBfRERJX0NMS19TRUxfTUFTSyhwb3J0KQkoMyA8PCBEUENMS0FfQ0ZHQ1IwX0RESV9DTEtf U0VMX1NISUZUKHBvcnQpKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggYjViOGRh ZTA2Y2RlLi45ODgzZjAyNzU2YWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBA IC0yNzMzLDYgKzI3MzMsMjEgQEAgdWludDMyX3QgZGRpX3NpZ25hbF9sZXZlbHMoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCkKPiAgCXJldHVybiBERElfQlVGX1RSQU5TX1NFTEVDVChsZXZlbCk7 Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxpbmUKPiArdWludDMyX3QgaWNsX2RwY2xrYV9jZmdjcjBf Y2xrX29mZihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgICBlbnVt IHBvcnQgcG9ydCkKPiArewo+ICsJaWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYs IHBvcnQpKSB7Cj4gKwkJcmV0dXJuIElDTF9EUENMS0FfQ0ZHQ1IwX0RESV9DTEtfT0ZGKHBvcnQp Owo+ICsJfSBlbHNlIGlmIChpbnRlbF9wb3J0X2lzX3RjKGRldl9wcml2LCBwb3J0KSkgewo+ICsJ CWVudW0gdGNfcG9ydCB0Y19wb3J0ID0gaW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCk7 Cj4gKwo+ICsJCXJldHVybiBJQ0xfRFBDTEtBX0NGR0NSMF9UQ19DTEtfT0ZGKHRjX3BvcnQpOwo+ ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICB2b2lkIGljbF9tYXBfcGxsc190b19w b3J0cyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0 YXRlKQo+IEBAIC0yNzU2LDcgKzI3NzEsNyBAQCB2b2lkIGljbF9tYXBfcGxsc190b19wb3J0cyhz dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9j ayk7Cj4gIAo+ICAJCXZhbCA9IEk5MTVfUkVBRChEUENMS0FfQ0ZHQ1IwX0lDTCk7Cj4gLQkJV0FS Tl9PTigodmFsICYgRFBDTEtBX0NGR0NSMF9ERElfQ0xLX09GRihwb3J0KSkgPT0gMCk7Cj4gKwkJ V0FSTl9PTigodmFsICYgaWNsX2RwY2xrYV9jZmdjcjBfY2xrX29mZihkZXZfcHJpdiwgcG9ydCkp ID09IDApOwo+ICAKPiAgCQlpZiAoaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9y dCkpIHsKPiAgCQkJdmFsICY9IH5EUENMS0FfQ0ZHQ1IwX0RESV9DTEtfU0VMX01BU0socG9ydCk7 Cj4gQEAgLTI3NjUsNyArMjc4MCw3IEBAIHZvaWQgaWNsX21hcF9wbGxzX3RvX3BvcnRzKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJUE9TVElOR19SRUFEKERQQ0xLQV9DRkdDUjBfSUNMKTsK PiAgCQl9Cj4gIAo+IC0JCXZhbCAmPSB+RFBDTEtBX0NGR0NSMF9ERElfQ0xLX09GRihwb3J0KTsK PiArCQl2YWwgJj0gfmljbF9kcGNsa2FfY2ZnY3IwX2Nsa19vZmYoZGV2X3ByaXYsIHBvcnQpOwo+ ICAJCUk5MTVfV1JJVEUoRFBDTEtBX0NGR0NSMF9JQ0wsIHZhbCk7Cj4gIAo+ICAJCW11dGV4X3Vu bG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gQEAgLTI3OTMsNyArMjgwOCw3IEBAIHZvaWQg aWNsX3VubWFwX3BsbHNfdG9fcG9ydHMoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCW11dGV4 X2xvY2soJmRldl9wcml2LT5kcGxsX2xvY2spOwo+ICAJCUk5MTVfV1JJVEUoRFBDTEtBX0NGR0NS MF9JQ0wsCj4gIAkJCSAgIEk5MTVfUkVBRChEUENMS0FfQ0ZHQ1IwX0lDTCkgfAo+IC0JCQkgICBE UENMS0FfQ0ZHQ1IwX0RESV9DTEtfT0ZGKHBvcnQpKTsKPiArCQkJICAgaWNsX2RwY2xrYV9jZmdj cjBfY2xrX29mZihkZXZfcHJpdiwgcG9ydCkpOwo+ICAJCW11dGV4X3VubG9jaygmZGV2X3ByaXYt PmRwbGxfbG9jayk7Cj4gIAl9Cj4gIH0KPiAtLSAKPiAyLjE2LjIKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==