Date: Mon, 8 Oct 2018 20:47:13 +0200 (CEST) Message-Id: <201810081847.w98IlDNo033724@...2054...> From: Gert Doering In-Reply-To: <20181008181618.8976-2-arne@...1227...> References: <20181008181618.8976-2-arne@...1227...> Subject: [Openvpn-devel] [PATCH applied] Re: Remove AUTO_USERID feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arne Schwabe Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering For the reasons given - it's code that has not been activated anywhere in the last 5+ years, there is no way to turn it on by configure, and it's likely not working right on half the platforms. And less #ifdef! I had to whack the patch to make it apply - no changes to the actual code, but the context was full of ENABLE_MANAGEMENT where our tree has ENABLE_CLIENT_CR. I seem to remember that there was a patch to get rid of the letter (because it is auto-defined #if ENABLE_MANAGEMENT) but we seem to have lost track of it... only your tree remembers. Your patch has been applied to the master branch. commit 00d78cd57fa52aa5a65df1707922791e72313663 Author: Arne Schwabe Date: Mon Oct 8 20:16:16 2018 +0200 Remove AUTO_USERID feature Acked-by: Gert Doering Message-Id: <20181008181618.8976-2-arne@...1227...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17664.html Signed-off-by: Gert Doering -- kind regards, Gert Doering