From: Daniel Vetter Subject: Re: [PATCH] drm: Get ref on CRTC commit object when waiting for flip_done Date: Fri, 12 Oct 2018 09:34:03 +0200 Message-ID: <20181012073403.GM31561@phenom.ffwll.local> References: <1539304063-9518-1-git-send-email-sunpeng.li@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id C08F86E44B for ; Fri, 12 Oct 2018 07:34:07 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id g32-v6so10565081edg.13 for ; Fri, 12 Oct 2018 00:34:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1539304063-9518-1-git-send-email-sunpeng.li@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: sunpeng.li@amd.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMDg6Mjc6NDNQTSAtMDQwMCwgc3VucGVuZy5saUBhbWQu Y29tIHdyb3RlOgo+IEZyb206IExlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPgo+IAo+IFRoaXMg Zml4ZXMgYSBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQsIGNhdXNlZCBieSBhY2Nlc3NpbmcgdGhl IGNvbnRlbnRzCj4gb2YgYSBmbGlwX2RvbmUgY29tcGxldGlvbiBvYmplY3QgdGhhdCBoYXMgYWxy ZWFkeSBiZWVuIGZyZWVkLiBJdCBvY2N1cnMKPiBkdWUgdG8gdGhlIHByZWVtcHRpb24gb2YgYSBu b24tYmxvY2tpbmcgY29tbWl0IHdvcmtlciB0aHJlYWQgVyBieQo+IGFub3RoZXIgY29tbWl0IHRo cmVhZCBYLiBYIGNvbnRpbnVlcyB0byBjbGVhciBpdHMgYXRvbWljIHN0YXRlIGF0IHRoZQo+IGVu ZCwgZGVzdHJveWluZyB0aGUgQ1JUQyBjb21taXQgb2JqZWN0IHRoYXQgVyBzdGlsbCBuZWVkcy4g U3dpdGNoaW5nCj4gYmFjayB0byBXIGFuZCBhY2Nlc3NpbmcgdGhlIGNvbW1pdCBvYmplY3RzIHRo ZW4gbGVhZHMgdG8gYmFkIHJlc3VsdHMuCj4gCj4gV29ya2VyIFcgYmVjb21lcyBwcmVlbXB0YWJs ZSB3aGVuIHdhaXRpbmcgZm9yIGZsaXBfZG9uZSB0byBjb21wbGV0ZS4gQXQKPiB0aGlzIHBvaW50 LCBhIGZyZXF1ZW50bHkgb2NjdXJyaW5nIGNvbW1pdCB0aHJlYWQgWCBjYW4gdGFrZSBvdmVyLiBI ZXJlJ3MKPiBhbiBleGFtcGxlIHdoZXJlIFcgaXMgYSB3b3JrZXIgdGhyZWFkIHRoYXQgZmxpcHMg b24gYm90aCBDUlRDcywgYW5kIFgKPiBkb2VzIGEgbGVnYWN5IGN1cnNvciB1cGRhdGUgb24gYm90 aCBDUlRDczoKPiAKPiAgICAgICAgIC4uLgo+ICAgICAgMS4gVyBkb2VzIGZsaXAgd29yawo+ICAg ICAgMi4gVyBydW5zIGNvbW1pdF9od19kb25lKCkKPiAgICAgIDMuIFcgd2FpdHMgZm9yIGZsaXBf ZG9uZSBvbiBDUlRDIDEKPiAgICAgIDQuID4gZmxpcF9kb25lIGZvciBDUlRDIDEgY29tcGxldGVz Cj4gICAgICA1LiBXIGZpbmlzaGVzIHdhaXRpbmcgZm9yIENSVEMgMQo+ICAgICAgNi4gVyB3YWl0 cyBmb3IgZmxpcF9kb25lIG9uIENSVEMgMgo+IAo+ICAgICAgNy4gPiBQcmVlbXB0ZWQgYnkgWAo+ ICAgICAgOC4gPiBmbGlwX2RvbmUgZm9yIENSVEMgMiBjb21wbGV0ZXMKPiAgICAgIDkuIFggYXRv bWljX2NoZWNrOiBod19kb25lIGFuZCBmbGlwX2RvbmUgYXJlIGNvbXBsZXRlIG9uIGFsbCBDUlRD cwo+ICAgICAxMC4gWCB1cGRhdGVzIGN1cnNvciBvbiBib3RoIENSVENzCj4gICAgIDExLiBYIGRl c3Ryb3lzIGF0b21pYyBzdGF0ZQo+ICAgICAxMi4gWCBkb25lCj4gCj4gICAgIDEzLiA+IFN3aXRj aCBiYWNrIHRvIFcKPiAgICAgMTQuIFcgd2FpdHMgZm9yIGZsaXBfZG9uZSBvbiBDUlRDIDIKPiAg ICAgMTUuIFcgcmFpc2VzIGdlbmVyYWwgcHJvdGVjdGlvbiBmYXVsdAo+IAo+IFRoZSBlcnJvciBs b29rcyBsaWtlIHNvOgo+IAo+ICAgICBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQ6IDAwMDAgWyMx XSBQUkVFTVBUIFNNUCBQVEkKPiAgICAgKipzbmlwKioKPiAgICAgQ2FsbCBUcmFjZToKPiAgICAg IGxvY2tfYWNxdWlyZSsweGEyLzB4MWIwCj4gICAgICBfcmF3X3NwaW5fbG9ja19pcnErMHgzOS8w eDcwCj4gICAgICB3YWl0X2Zvcl9jb21wbGV0aW9uX3RpbWVvdXQrMHgzMS8weDEzMAo+ICAgICAg ZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxpcF9kb25lKzB4NjQvMHg5MCBbZHJtX2ttc19o ZWxwZXJdCj4gICAgICBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsKzB4Y2FlLzB4ZGQwIFth bWRncHVdCj4gICAgICBjb21taXRfdGFpbCsweDNkLzB4NzAgW2RybV9rbXNfaGVscGVyXQo+ICAg ICAgcHJvY2Vzc19vbmVfd29yaysweDIxMi8weDY1MAo+ICAgICAgd29ya2VyX3RocmVhZCsweDQ5 LzB4NDIwCj4gICAgICBrdGhyZWFkKzB4ZmIvMHgxMzAKPiAgICAgIHJldF9mcm9tX2ZvcmsrMHgz YS8weDUwCj4gICAgIE1vZHVsZXMgbGlua2VkIGluOiB4ODZfcGtnX3RlbXBfdGhlcm1hbCBhbWRn cHUoTykgY2hhc2goTykKPiAgICAgZ3B1X3NjaGVkKE8pIGRybV9rbXNfaGVscGVyKE8pIHN5c2Nv cHlhcmVhIHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdAo+ICAgICBmYl9zeXNfZm9wcyB0dG0oTykgZHJt KE8pCj4gCj4gTm90ZSB0aGF0IGk5MTUgaGFzIHRoaXMgaXNzdWUgbWFza2VkLCBzaW5jZSBod19k b25lIGlzIHNpZ25hbGVkIGFmdGVyCj4gd2FpdGluZyBmb3IgZmxpcF9kb25lLiBEb2luZyBzbyB3 aWxsIGJsb2NrIHRoZSBjdXJzb3IgdXBkYXRlIGZyb20KPiBoYXBwZW5pbmcgdW50aWwgaHdfZG9u ZSBpcyBzaWduYWxlZCwgcHJldmVudGluZyB0aGUgY3Vyc29yIGNvbW1pdCBmcm9tCj4gZGVzdHJv eWluZyB0aGUgc3RhdGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGVvIExpIDxzdW5wZW5nLmxpQGFt ZC5jb20+CgpHcmVhdCBhbmFseXNpcyEKCkJ1Z2ZpeCBpdHNlbGYgbmVlZHMgYSBiaXQgbW9yZSB3 b3JrIHRob3VnaCwgc2VlIGJlbG93LgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMgfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCA4MGJlNzRkLi5lZmRmMDQzIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMTQxMCwyMCArMTQxMCw0MiBAQCB2b2lk IGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlOwo+ICAJ c3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJc3RydWN0IGRybV9jcnRjX2NvbW1pdCAqKmNvbW1p dHM7Cj4gIAlpbnQgaTsKPiArCWludCBudW1fY3J0YyA9IGRldi0+bW9kZV9jb25maWcubnVtX2Ny dGM7Cj4gIAo+ICsJY29tbWl0cyA9IGtjYWxsb2MobnVtX2NydGMsIHNpemVvZigqY29tbWl0cyks IEdGUF9LRVJORUwpOwo+ICsKPiArCS8qCj4gKwkgKiBCZWNhdXNlIHdlIG9wZW4gb3Vyc2VsdmVz IHRvIHByZWVtcHRpb24gYnkgY2FsbGluZwo+ICsJICogd2FpdF9mb3JfY29tcGxldGlvbl90aW1l b3V0KCksIHdlIG5lZWQgdG8gZ2V0IG91ciBvd24gcmVmZXJlbmNlcyB0bwo+ICsJICogdGhlIGNv bW1pdCBvYmplY3RzLiBUaGlzIGlzIHNvIHRoYXQgYSBwcmVlbXB0aW5nIGNvbW1pdCB3b24ndCBm cmVlCj4gKwkgKiB0aGVtLgo+ICsJICovCgpUaGUgc2NoZWR1bGVyIGNhbiBwcmVlbXB0IHlvdSBh dCBhbnkgcG9pbnQgYmVmb3JlIGhlcmUgdG9vLCBpZiB5b3UgZW5hYmxlCkNPTkZJR19QUkVFTVBU LiBJdCBkZWZpbml0ZWx5IGNhbiBwcmVlbXB0L2Jsb2NrIGluIHRoZSBrY2FsbG9jIGFib3ZlLCBl dmVuCmlmIHlvdSBoYXZlIENPTkZJR19QUkVFTVBUIGRpc2FibGVkLiBUaGUgc2NoZWR1bGluZyBw b2ludCB5b3UgaWRlbnRpZmllZApiZWxvdyBpcyBzaW1wbHkgdGhlIG1vc3QgbGlrZWx5LgoKVGhl IHVuZGVybHlpbmcgYnVnIGlzIHRoYXQgYWZ0ZXIgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X2h3 X2RvbmUoKSB3ZQp1bmJsb2NrIHRoZSBuZXh0IGNvbW1pdCB3b3JrZXIgKHRocmVhZCBYIGluIHlv dXIgZXhhbXBsZSksIGFuZCBjYW5ub3QKYXNzdW1lIGFueW1vcmUgdGhhdCB0aGUgbmV3IHN0YXRl IHdpbGwgc3RheSBhcm91bmQgKHNpbmNlIG5ldyBzdGF0ZSBpcwpyZWxlYXNlZCBieSB0aGUgc3Vi c2VxdWVudCBjb21taXQgd29yayBydW4gaW4gdGhyZWFkIFgpLgoKVGhlcmVmb3JlIHlvdXIgZHJt X2NydGNfY29tbWl0X2dldCBoZXJlIGFscmVhZHkgY2FuIGFjY2VzcyBmcmVlZCBtZW1vcnkuClRo ZSBjb3JyZWN0IGZpeCBoZXJlIGlzIHRvIHN0b3JlIHRoZSB0ZW1wb3JhcnkgcmVmZXJlbmNlIGJl Zm9yZSB3ZSBjYWxsCmRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9od19kb25lKCksIGFuZCB0aGVu IHVzZSB0aGF0IGluIHRoaXMgZnVuY3Rpb24KaGVyZS4gVGhlIHByb2JsZW0gaXMgdGhhdCB0aGlz IGlzIHNvbWV3aGF0IHRyaWNreSB0byBwdWxsIG9mZiwgc2luY2Ugc29tZQpkcml2ZXJzIGNhbGwg d2FpdF9mb3JfZmxpcF9kb25lKCkgYmVmb3JlIGh3X2RvbmUoKSAobGlrZSBpOTE1KS4KCkhlcmUn cyB3aGF0IEknZCBkbzoKLSBBZGQgYSBuZXcgZHJtX2NydGNfY29tbWl0IHBvaW50ZXIgdG8gc3Ry dWN0IF9fZHJtX2NydGNzX3N0YXRlLgoKLSBGaWxsIHRoYXQgb3V0IGluIGRybV9hdG9taWNfaGVs cGVyX3NldHVwX2NvbW1pdCwgYW5kIG1ha2Ugc3VyZSB5b3UKICByZWxlYXNlIHRoZSByZWZlcmVu Y2UgZm9yIGl0IGluIGRybV9hdG9taWNfc3RhdGVfZGVmYXVsdF9jbGVhcigpLgoKLSBVc2UgdGhh dCBwb2ludGVyIGluc3RlYWQgaW4gZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxpcF9kb25l KCkgaGVyZS4KCkNoZWVycywgRGFuaWVsCj4gIAlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShv bGRfc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4gLQkJc3RydWN0IGRybV9jcnRj X2NvbW1pdCAqY29tbWl0ID0gbmV3X2NydGNfc3RhdGUtPmNvbW1pdDsKPiArCQljb21taXRzW2ld ID0gbmV3X2NydGNfc3RhdGUtPmNvbW1pdDsKPiArCQlpZiAoY29tbWl0c1tpXSkKPiArCQkJZHJt X2NydGNfY29tbWl0X2dldChjb21taXRzW2ldKTsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAwOyBp IDwgbnVtX2NydGM7IGkrKykgewo+ICAJCWludCByZXQ7Cj4gIAo+IC0JCWlmICghY29tbWl0KQo+ ICsJCWlmICghY29tbWl0c1tpXSkKPiAgCQkJY29udGludWU7Cj4gIAo+IC0JCXJldCA9IHdhaXRf Zm9yX2NvbXBsZXRpb25fdGltZW91dCgmY29tbWl0LT5mbGlwX2RvbmUsIDEwICogSFopOwo+ICsJ CXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91dCgmY29tbWl0c1tpXS0+ZmxpcF9kb25l LAo+ICsJCQkJCQkgIDEwICogSFopOwo+ICAJCWlmIChyZXQgPT0gMCkKPiAgCQkJRFJNX0VSUk9S KCJbQ1JUQzolZDolc10gZmxpcF9kb25lIHRpbWVkIG91dFxuIiwKPiAtCQkJCSAgY3J0Yy0+YmFz ZS5pZCwgY3J0Yy0+bmFtZSk7Cj4gKwkJCQkgIGNvbW1pdHNbaV0tPmNydGMtPmJhc2UuaWQsCj4g KwkJCQkgIGNvbW1pdHNbaV0tPmNydGMtPm5hbWUpOwo+ICAJfQo+ICsKPiArCWZvciAoaSA9IDA7 IGkgPCBudW1fY3J0YzsgaSsrKQo+ICsJCWlmIChjb21taXRzW2ldKQo+ICsJCQlkcm1fY3J0Y19j b21taXRfcHV0KGNvbW1pdHNbaV0pOwo+ICsJa2ZyZWUoY29tbWl0cyk7Cj4gIH0KPiAgRVhQT1JU X1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUpOwo+ICAKPiAtLSAK PiAyLjcuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=