From: Daniel Vetter Subject: Re: [PATCH v2] drm: Get ref on CRTC commit object when waiting for flip_done Date: Tue, 16 Oct 2018 14:33:17 +0200 Message-ID: <20181016123317.GV31561@phenom.ffwll.local> References: <1539380010-9221-1-git-send-email-sunpeng.li@amd.com> <1539611200-6184-1-git-send-email-sunpeng.li@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1539611200-6184-1-git-send-email-sunpeng.li-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: sunpeng.li-5C7GfCeVMHo@public.gmane.org Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, harry.wentland-5C7GfCeVMHo@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMDk6NDY6NDBBTSAtMDQwMCwgc3VucGVuZy5saUBhbWQu Y29tIHdyb3RlOgo+IEZyb206IExlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPgo+IAo+IFRoaXMg Zml4ZXMgYSBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQsIGNhdXNlZCBieSBhY2Nlc3NpbmcgdGhl IGNvbnRlbnRzCj4gb2YgYSBmbGlwX2RvbmUgY29tcGxldGlvbiBvYmplY3QgdGhhdCBoYXMgYWxy ZWFkeSBiZWVuIGZyZWVkLiBJdCBvY2N1cnMKPiBkdWUgdG8gdGhlIHByZWVtcHRpb24gb2YgYSBu b24tYmxvY2tpbmcgY29tbWl0IHdvcmtlciB0aHJlYWQgVyBieQo+IGFub3RoZXIgY29tbWl0IHRo cmVhZCBYLiBYIGNvbnRpbnVlcyB0byBjbGVhciBpdHMgYXRvbWljIHN0YXRlIGF0IHRoZQo+IGVu ZCwgZGVzdHJveWluZyB0aGUgQ1JUQyBjb21taXQgb2JqZWN0IHRoYXQgVyBzdGlsbCBuZWVkcy4g U3dpdGNoaW5nCj4gYmFjayB0byBXIGFuZCBhY2Nlc3NpbmcgdGhlIGNvbW1pdCBvYmplY3RzIHRo ZW4gbGVhZHMgdG8gYmFkIHJlc3VsdHMuCj4gCj4gV29ya2VyIFcgYmVjb21lcyBwcmVlbXB0YWJs ZSB3aGVuIHdhaXRpbmcgZm9yIGZsaXBfZG9uZSB0byBjb21wbGV0ZS4gQXQKPiB0aGlzIHBvaW50 LCBhIGZyZXF1ZW50bHkgb2NjdXJyaW5nIGNvbW1pdCB0aHJlYWQgWCBjYW4gdGFrZSBvdmVyLiBI ZXJlJ3MKPiBhbiBleGFtcGxlIHdoZXJlIFcgaXMgYSB3b3JrZXIgdGhyZWFkIHRoYXQgZmxpcHMg b24gYm90aCBDUlRDcywgYW5kIFgKPiBkb2VzIGEgbGVnYWN5IGN1cnNvciB1cGRhdGUgb24gYm90 aCBDUlRDczoKPiAKPiAgICAgICAgIC4uLgo+ICAgICAgMS4gVyBkb2VzIGZsaXAgd29yawo+ICAg ICAgMi4gVyBydW5zIGNvbW1pdF9od19kb25lKCkKPiAgICAgIDMuIFcgd2FpdHMgZm9yIGZsaXBf ZG9uZSBvbiBDUlRDIDEKPiAgICAgIDQuID4gZmxpcF9kb25lIGZvciBDUlRDIDEgY29tcGxldGVz Cj4gICAgICA1LiBXIGZpbmlzaGVzIHdhaXRpbmcgZm9yIENSVEMgMQo+ICAgICAgNi4gVyB3YWl0 cyBmb3IgZmxpcF9kb25lIG9uIENSVEMgMgo+IAo+ICAgICAgNy4gPiBQcmVlbXB0ZWQgYnkgWAo+ ICAgICAgOC4gPiBmbGlwX2RvbmUgZm9yIENSVEMgMiBjb21wbGV0ZXMKPiAgICAgIDkuIFggYXRv bWljX2NoZWNrOiBod19kb25lIGFuZCBmbGlwX2RvbmUgYXJlIGNvbXBsZXRlIG9uIGFsbCBDUlRD cwo+ICAgICAxMC4gWCB1cGRhdGVzIGN1cnNvciBvbiBib3RoIENSVENzCj4gICAgIDExLiBYIGRl c3Ryb3lzIGF0b21pYyBzdGF0ZQo+ICAgICAxMi4gWCBkb25lCj4gCj4gICAgIDEzLiA+IFN3aXRj aCBiYWNrIHRvIFcKPiAgICAgMTQuIFcgd2FpdHMgZm9yIGZsaXBfZG9uZSBvbiBDUlRDIDIKPiAg ICAgMTUuIFcgcmFpc2VzIGdlbmVyYWwgcHJvdGVjdGlvbiBmYXVsdAo+IAo+IFRoZSBlcnJvciBs b29rcyBsaWtlIHNvOgo+IAo+ICAgICBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQ6IDAwMDAgWyMx XSBQUkVFTVBUIFNNUCBQVEkKPiAgICAgKipzbmlwKioKPiAgICAgQ2FsbCBUcmFjZToKPiAgICAg IGxvY2tfYWNxdWlyZSsweGEyLzB4MWIwCj4gICAgICBfcmF3X3NwaW5fbG9ja19pcnErMHgzOS8w eDcwCj4gICAgICB3YWl0X2Zvcl9jb21wbGV0aW9uX3RpbWVvdXQrMHgzMS8weDEzMAo+ICAgICAg ZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxpcF9kb25lKzB4NjQvMHg5MCBbZHJtX2ttc19o ZWxwZXJdCj4gICAgICBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsKzB4Y2FlLzB4ZGQwIFth bWRncHVdCj4gICAgICBjb21taXRfdGFpbCsweDNkLzB4NzAgW2RybV9rbXNfaGVscGVyXQo+ICAg ICAgcHJvY2Vzc19vbmVfd29yaysweDIxMi8weDY1MAo+ICAgICAgd29ya2VyX3RocmVhZCsweDQ5 LzB4NDIwCj4gICAgICBrdGhyZWFkKzB4ZmIvMHgxMzAKPiAgICAgIHJldF9mcm9tX2ZvcmsrMHgz YS8weDUwCj4gICAgIE1vZHVsZXMgbGlua2VkIGluOiB4ODZfcGtnX3RlbXBfdGhlcm1hbCBhbWRn cHUoTykgY2hhc2goTykKPiAgICAgZ3B1X3NjaGVkKE8pIGRybV9rbXNfaGVscGVyKE8pIHN5c2Nv cHlhcmVhIHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdAo+ICAgICBmYl9zeXNfZm9wcyB0dG0oTykgZHJt KE8pCj4gCj4gTm90ZSB0aGF0IGk5MTUgaGFzIHRoaXMgaXNzdWUgbWFza2VkLCBzaW5jZSBod19k b25lIGlzIHNpZ25hbGVkIGFmdGVyCj4gd2FpdGluZyBmb3IgZmxpcF9kb25lLiBEb2luZyBzbyB3 aWxsIGJsb2NrIHRoZSBjdXJzb3IgdXBkYXRlIGZyb20KPiBoYXBwZW5pbmcgdW50aWwgaHdfZG9u ZSBpcyBzaWduYWxlZCwgcHJldmVudGluZyB0aGUgY3Vyc29yIGNvbW1pdCBmcm9tCj4gZGVzdHJv eWluZyB0aGUgc3RhdGUuCj4gCj4gdjI6IFRoZSByZWZlcmVuY2Ugb24gdGhlIGNvbW1pdCBvYmpl Y3QgbmVlZHMgdG8gYmUgb2J0YWluZWQgYmVmb3JlCj4gICAgIGh3X2RvbmUoKSBpcyBzaWduYWxl ZCwgc2luY2UgdGhhdCdzIHRoZSBwb2ludCB3aGVyZSBhbm90aGVyIGNvbW1pdAo+ICAgICBpcyBh bGxvd2VkIHRvIG1vZGlmeSB0aGUgc3RhdGUuIEFzc3VtaW5nIHRoYXQgdGhlCj4gICAgIG5ld19j cnRjX3N0YXRlLT5jb21taXQgb2JqZWN0IHN0aWxsIGV4aXN0cyB3aXRoaW4gZmxpcF9kb25lKCkg aXMKPiAgICAgaW5jb3JyZWN0Lgo+IAo+ICAgICBGaXggYnkgZ2V0dGluZyBhIHJlZmVyZW5jZSBp biBzZXR1cF9jb21taXQoKSwgYW5kIHJlbGVhc2luZyBpdAo+ICAgICBkdXJpbmcgZGVmYXVsdF9j bGVhcigpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IExlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPgo+ IC0tLQo+IAo+IFNlbmRpbmcgYWdhaW4sIHRoaXMgdGltZSB0byB0aGUgY29ycmVjdCBtYWlsaW5n IGxpc3QgOikKPiAKPiBMZW8KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKSSB0aGluayBpdCdkIGJl IHJlYWxseSBnb29kIGlmIHlvdSBjb3VsZCBnZXQgaW50ZWwtZ2Z4LWNpIHRvIHRlc3QgdGhpcwpw YXRjaC4gU2ltcGx5IHN1Ym1pdCBpdCB0byBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn LiBJJ2xsIGxlYXZlCmFwcGx5aW5nIHRvIG9uZSBvZiB0aGUgYW1kIGRybS1taXNjIGNvbW1pdHRl cnMsIG9uY2UgaXQncyBwYXNzZWQgQ0kuCgpDaGVlcnMsIERhbmllbAoKPiAKPiAgZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAgfCAgNSArKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYyB8IDEyICsrKysrKysrLS0tLQo+ICBpbmNsdWRlL2RybS9kcm1f YXRvbWljLmggICAgICAgICAgICB8IDExICsrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwg MjQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBp bmRleCAzZWIwNjFlLi4xMmFlOTE3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTE3NCw2 ICsxNzQsMTEgQEAgdm9pZCBkcm1fYXRvbWljX3N0YXRlX2RlZmF1bHRfY2xlYXIoc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJCXN0YXRlLT5jcnRjc1tpXS5zdGF0ZSA9IE5VTEw7 Cj4gIAkJc3RhdGUtPmNydGNzW2ldLm9sZF9zdGF0ZSA9IE5VTEw7Cj4gIAkJc3RhdGUtPmNydGNz W2ldLm5ld19zdGF0ZSA9IE5VTEw7Cj4gKwo+ICsJCWlmIChzdGF0ZS0+Y3J0Y3NbaV0uY29tbWl0 KSB7Cj4gKwkJCWRybV9jcnRjX2NvbW1pdF9wdXQoc3RhdGUtPmNydGNzW2ldLmNvbW1pdCk7Cj4g KwkJCXN0YXRlLT5jcnRjc1tpXS5jb21taXQgPSBOVUxMOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAlm b3IgKGkgPSAwOyBpIDwgY29uZmlnLT5udW1fdG90YWxfcGxhbmU7IGkrKykgewo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggODBiZTc0ZC4uMWJiNGMzMSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gQEAgLTE0MDgsMTUgKzE0MDgsMTYgQEAgRVhQ T1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl92YmxhbmtzKTsKPiAgdm9pZCBk cm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiAgCQkJCQkgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpCj4gIHsKPiAt CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJtX2Ny dGMgKmNydGM7Cj4gIAlpbnQgaTsKPiAgCj4gLQlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShv bGRfc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4gLQkJc3RydWN0IGRybV9jcnRj X2NvbW1pdCAqY29tbWl0ID0gbmV3X2NydGNfc3RhdGUtPmNvbW1pdDsKPiArCWZvciAoaSA9IDA7 IGkgPCBkZXYtPm1vZGVfY29uZmlnLm51bV9jcnRjOyBpKyspIHsKPiArCQlzdHJ1Y3QgZHJtX2Ny dGNfY29tbWl0ICpjb21taXQgPSBvbGRfc3RhdGUtPmNydGNzW2ldLmNvbW1pdDsKPiAgCQlpbnQg cmV0Owo+ICAKPiAtCQlpZiAoIWNvbW1pdCkKPiArCQljcnRjID0gb2xkX3N0YXRlLT5jcnRjc1tp XS5wdHI7Cj4gKwo+ICsJCWlmICghY3J0YyB8fCAhY29tbWl0KQo+ICAJCQljb250aW51ZTsKPiAg Cj4gIAkJcmV0ID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCZjb21taXQtPmZsaXBfZG9u ZSwgMTAgKiBIWik7Cj4gQEAgLTE5MzQsNiArMTkzNSw5IEBAIGludCBkcm1fYXRvbWljX2hlbHBl cl9zZXR1cF9jb21taXQoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJCWRybV9j cnRjX2NvbW1pdF9nZXQoY29tbWl0KTsKPiAgCj4gIAkJY29tbWl0LT5hYm9ydF9jb21wbGV0aW9u ID0gdHJ1ZTsKPiArCj4gKwkJc3RhdGUtPmNydGNzW2ldLmNvbW1pdCA9IGNvbW1pdDsKPiArCQlk cm1fY3J0Y19jb21taXRfZ2V0KGNvbW1pdCk7Cj4gIAl9Cj4gIAo+ICAJZm9yX2VhY2hfb2xkbmV3 X2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubiwgb2xkX2Nvbm5fc3RhdGUsIG5ld19jb25u X3N0YXRlLCBpKSB7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaCBiL2lu Y2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IGluZGV4IGRhOWQ5NWEuLjFlNzEzMTUgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0 b21pYy5oCj4gQEAgLTE1Myw2ICsxNTMsMTcgQEAgc3RydWN0IF9fZHJtX3BsYW5lc19zdGF0ZSB7 Cj4gIHN0cnVjdCBfX2RybV9jcnRjc19zdGF0ZSB7Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKnB0cjsK PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUsICpvbGRfc3RhdGUsICpuZXdfc3RhdGU7 Cj4gKwo+ICsJLyoqCj4gKwkgKiBAY29tbWl0Ogo+ICsJICoKPiArCSAqIEEgcmVmZXJlbmNlIHRv IHRoZSBDUlRDIGNvbW1pdCBvYmplY3QgdGhhdCBpcyBrZXB0IGZvciB1c2UgYnkKPiArCSAqIGRy bV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGFmdGVyCj4gKwkgKiBkcm1fYXRv bWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgpIGlzIGNhbGxlZC4gVGhpcyBlbnN1cmVzIHRoYXQg YQo+ICsJICogY29uY3VycmVudCBjb21taXQgd29uJ3QgZnJlZSBhIGNvbW1pdCBvYmplY3QgdGhh dCBpcyBzdGlsbCBpbiB1c2UuCj4gKwkgKi8KPiArCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNv bW1pdDsKPiArCj4gIAlzMzIgX191c2VyICpvdXRfZmVuY2VfcHRyOwo+ICAJdTY0IGxhc3RfdmJs YW5rX2NvdW50Owo+ICB9Owo+IC0tIAo+IDIuNy40Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==