From: Daniel Vetter Subject: Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind" Date: Tue, 16 Oct 2018 18:45:28 +0200 Message-ID: <20181016164528.GD31561@phenom.ffwll.local> References: <20181016160923.2042-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D53F6E264 for ; Tue, 16 Oct 2018 16:45:33 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id x31-v6so22005193edd.8 for ; Tue, 16 Oct 2018 09:45:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181016160923.2042-1-stefan@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rmk+kernel@armlinux.org.uk List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDY6MDk6MjNQTSArMDIwMCwgU3RlZmFuIEFnbmVyIHdy b3RlOgo+IFRoaXMgcmV2ZXJ0cyBjb21taXQgOGUzYjE2ZTIxMTc0MDk2MjViODk4MDdkZTM5MTJm Zjc3M2FlYTM1NC4KPiAKPiBVc2luZyB0aGUgY29tcG9uZW50IGZyYW1ld29yayByZXF1aXJlcyBh bGwgY29tcG9uZW50cyB0byB1bmRvIGluCj4gLT51bmJpbmQgd2hhdCAtPmJpbmQgZG9lcy4gVW5m b3J0dW5hdGVseSB0aGF0IHBhcnRpY3VsYXIgY29tbWl0Cj4gYnJva2UgdGhpcyBydWxlLiBJbiBw YXJ0aWN1bGFyLCB0aGlzIGlzIGFuIGlzc3VlIGlmIGEgc2luZ2xlCj4gY29tcG9uZW50IGR1cmlu ZyBwcm9iZSBmYWlscy4gSW4gdGhhdCBjYXNlLCBjb21wb25lbnRfYmluZF9hbGwoKQo+IGNhbGxz IHVuYmluZCBvbiBhbHJlYWR5IHN1Y2N1c3NmdWxseSBib3VuZCBjb21wb25lbnRzLCBhbmQgdGhl bgo+IGZyZWVzIG1lbW9yeSBhbGxvY2F0ZWQgdXNpbmcgZGV2bS4gSWYgb25lIG9mIHRob3NlIGNv bXBvbmVudHMKPiByZWdpc3RlcmVkIGUuZy4gYW4gZW5jb2RlciB3aXRoIHRoZSBmcmFtZXdvcmsg dGhlbiB0aGlzIGxlYWRzIHRvCj4gdXNlIGFmdGVyIGZyZWUgc2l0dWF0aW9ucy4KPiAKPiBSZXZl cnQgdGhlIGNvbW1pdCB0byBlbnN1cmUgdGhhdCBhbGwgY29tcG9uZW50cyBwcm9wZXJseSB1bmRv Cj4gd2hhdCAtPmJpbmQgZG9lcy4KPiAKPiBMaW5rOiBodHRwczovL3d3dy5tYWlsLWFyY2hpdmUu Y29tL2RyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcvbXNnMjMzMzI3Lmh0bWwKPiBTdWdn ZXN0ZWQtYnk6IFJ1c3NlbGwgS2luZyA8cm1rK2tlcm5lbEBhcm1saW51eC5vcmcudWs+Cj4gU2ln bmVkLW9mZi1ieTogU3RlZmFuIEFnbmVyIDxzdGVmYW5AYWduZXIuY2g+CgpBZGRpbmcgQmVuamFt aW4sIHdobyBqdXN0IG1hZGUgdGhlIHNhbWUgbWlzdGFrZSBJIHRoaW5rIChhbmQgSSByZXZpZXdl ZCBpdAouLi4gb2ggd2VsbCkuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pbXgv aW14LWRybS1jb3JlLmMgICAgIHwgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWxk Yi5jICAgICAgICAgIHwgNiArKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtdHZlLmMg ICAgICAgICAgfCAzICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaW14L3BhcmFsbGVsLWRpc3BsYXku YyB8IDMgKysrCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtZHJtLWNvcmUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWRybS1jb3JlLmMKPiBpbmRleCA1ZWEwYzgyZjk5 NTcuLmNhYTYwNjFhOThiYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lteC1k cm0tY29yZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtZHJtLWNvcmUuYwo+IEBA IC0zMDUsMTEgKzMwNSwxMSBAQCBzdGF0aWMgdm9pZCBpbXhfZHJtX3VuYmluZChzdHJ1Y3QgZGV2 aWNlICpkZXYpCj4gIAo+ICAJZHJtX2ZiX2NtYV9mYmRldl9maW5pKGRybSk7Cj4gIAo+IC0JZHJt X21vZGVfY29uZmlnX2NsZWFudXAoZHJtKTsKPiAtCj4gIAljb21wb25lbnRfdW5iaW5kX2FsbChk cm0tPmRldiwgZHJtKTsKPiAgCWRldl9zZXRfZHJ2ZGF0YShkZXYsIE5VTEwpOwo+ICAKPiArCWRy bV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybSk7Cj4gKwo+ICAJZHJtX2Rldl9wdXQoZHJtKTsKPiAg fQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtbGRiLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaW14L2lteC1sZGIuYwo+IGluZGV4IDNiZDBmOGExOGU3NC4uNTkyYWFiYzRh MjYyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWxkYi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtbGRiLmMKPiBAQCAtNzIzLDYgKzcyMywxMiBAQCBzdGF0 aWMgdm9pZCBpbXhfbGRiX3VuYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Ug Km1hc3RlciwKPiAgCQlpZiAoY2hhbm5lbC0+cGFuZWwpCj4gIAkJCWRybV9wYW5lbF9kZXRhY2go Y2hhbm5lbC0+cGFuZWwpOwo+ICAKPiArCQlpZiAoIWNoYW5uZWwtPmNvbm5lY3Rvci5mdW5jcykK PiArCQkJY29udGludWU7Cj4gKwo+ICsJCWNoYW5uZWwtPmNvbm5lY3Rvci5mdW5jcy0+ZGVzdHJv eSgmY2hhbm5lbC0+Y29ubmVjdG9yKTsKPiArCQljaGFubmVsLT5lbmNvZGVyLmZ1bmNzLT5kZXN0 cm95KCZjaGFubmVsLT5lbmNvZGVyKTsKPiArCj4gIAkJa2ZyZWUoY2hhbm5lbC0+ZWRpZCk7Cj4g IAkJaTJjX3B1dF9hZGFwdGVyKGNoYW5uZWwtPmRkYyk7Cj4gIAl9Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pbXgvaW14LXR2ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtdHZl LmMKPiBpbmRleCBjZmZkMzMxMDI0MGUuLjhkNmU4OWNlMWVkYiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaW14L2lteC10dmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14 LXR2ZS5jCj4gQEAgLTY3Myw2ICs2NzMsOSBAQCBzdGF0aWMgdm9pZCBpbXhfdHZlX3VuYmluZChz dHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwKPiAgewo+ICAJc3RydWN0 IGlteF90dmUgKnR2ZSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICAKPiArCXR2ZS0+Y29ubmVj dG9yLmZ1bmNzLT5kZXN0cm95KCZ0dmUtPmNvbm5lY3Rvcik7Cj4gKwl0dmUtPmVuY29kZXIuZnVu Y3MtPmRlc3Ryb3koJnR2ZS0+ZW5jb2Rlcik7Cj4gKwo+ICAJaWYgKCFJU19FUlIodHZlLT5kYWNf cmVnKSkKPiAgCQlyZWd1bGF0b3JfZGlzYWJsZSh0dmUtPmRhY19yZWcpOwo+ICB9Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwtZGlzcGxheS5jIGIvZHJpdmVycy9n cHUvZHJtL2lteC9wYXJhbGxlbC1kaXNwbGF5LmMKPiBpbmRleCBhZWZkMDRlMThmOTMuLjZmMTFi ZmZjZGUzNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaW14L3BhcmFsbGVsLWRpc3Bs YXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwtZGlzcGxheS5jCj4gQEAg LTI1OCw2ICsyNTgsOSBAQCBzdGF0aWMgdm9pZCBpbXhfcGRfdW5iaW5kKHN0cnVjdCBkZXZpY2Ug KmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+ICAJaWYgKGlteHBkLT5wYW5lbCkKPiAgCQlk cm1fcGFuZWxfZGV0YWNoKGlteHBkLT5wYW5lbCk7Cj4gIAo+ICsJaW14cGQtPmVuY29kZXIuZnVu Y3MtPmRlc3Ryb3koJmlteHBkLT5lbmNvZGVyKTsKPiArCWlteHBkLT5jb25uZWN0b3IuZnVuY3Mt PmRlc3Ryb3koJmlteHBkLT5jb25uZWN0b3IpOwo+ICsKPiAgCWtmcmVlKGlteHBkLT5lZGlkKTsK PiAgfQo+ICAKPiAtLSAKPiAyLjE5LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2lu ZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK