Date: Wed, 17 Oct 2018 13:29:44 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20181017162944.GF31060@habkost.net>
References: <20181016232201.16829-1-crosa@redhat.com>
	<CAFEAcA_KFOay7zBoYMSqqEYd0ZhTcW5wp3bs28cr=oK4W4FL3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_KFOay7zBoYMSqqEYd0ZhTcW5wp3bs28cr=oK4W4FL3A@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch
 name mapping
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cleber Rosa <crosa@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Caio Carrara <ccarrara@redhat.com>

On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote:
> On 17 October 2018 at 00:22, Cleber Rosa <crosa@redhat.com> wrote:
> > The host arch name is not always the target arch name, so it's
> > necessary to have a mapping.
> >
> > The configure scripts contains what is the authoritative and failproof
> > mapping, but, reusing it is not straightforward, so it's replicated in
> > the acceptance tests supporting code.
> 
> So, why does the test code need to care? It's not clear
> from the patch... My expectation would be that you'd
> just test all the testable target architectures,
> regardless of what the host architecture is.

I tend to agree.  Maybe the right solution is to get rid of the
os.uname().  I think the default should be testing all QEMU
binaries that were built, and the host architecture shouldn't
matter.

That said, I think the dictionary is a nice temporary workaround
until we fix that.

-- 
Eduardo