Received: from eggs.gnu.org ([2001:4830:134:3::10]:33663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCu6f-0004IN-Fj for qemu-devel@nongnu.org; Wed, 17 Oct 2018 18:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCu6c-0005xo-BR for qemu-devel@nongnu.org; Wed, 17 Oct 2018 18:15:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33988) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCu6c-0005xE-4y for qemu-devel@nongnu.org; Wed, 17 Oct 2018 18:15:54 -0400 Date: Wed, 17 Oct 2018 19:15:46 -0300 From: Eduardo Habkost Message-ID: <20181017221546.GR31060@habkost.net> References: <20181016232201.16829-1-crosa@redhat.com> <20181017162944.GF31060@habkost.net> <20181017190951.GG31060@habkost.net> <20181017204618.GB18379@kermit-br-ibm-com> <46beb9dd-d3b7-de7a-313c-523ce036949e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46beb9dd-d3b7-de7a-313c-523ce036949e@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cleber Rosa Cc: Murilo Opsfelder Araujo , Peter Maydell , Caio Carrara , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , QEMU Developers , Wainer dos Santos Moschetta On Wed, Oct 17, 2018 at 04:59:25PM -0400, Cleber Rosa wrote: > On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote: [...] > > Then avocado could multiplex these variants file and call ./tests/acceptance/run > > for each value of qemu_bin. `run` script could skip and return if $qemu_bin > > doesn't exist. This approach also allows user forcing a value of qemu_bin when > > calling `run` manually, for example: > > > > ./tests/acceptance/run --qemu_bin=/path/to/your/qemu-system-blah ... > > > > This ./tests/acceptance/run can serve as an entry point to run all the tests. > > If more parameters are considered mandatory in the future, the logic can be > > placed there. > > > > I'm completely favorable to having extra scripts or make rules that > define a standard "job" behavior. In fact, I think we'll end up having > many of those. "make check-acceptance" is just the first one. > > But being able to running individual tests should still be possible, and > easy IMO. Agreed. But is there anything that requires "running an individual test" to be synonymous to "running a test against only one QEMU binary"? We seem to have a terminology problem here: "I'm running one individual test" may mean something to an user, but mean something completely different to somebody thinking about Avocado test cases. Is this the source of our disagreement? -- Eduardo