From: Daniel Vetter Subject: Re: [PATCH] drm/drm_pci.c: Use dma_zalloc_coherent Date: Tue, 23 Oct 2018 15:58:55 +0200 Message-ID: <20181023135855.GU324@phenom.ffwll.local> References: <20181023040222.GA1540@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181023040222.GA1540@jordon-HP-15-Notebook-PC> Sender: linux-kernel-owner@vger.kernel.org To: Souptick Joarder Cc: gustavo@padovan.org, maarten.lankhorst@linux.intel.com, sean@poorly.run, airlied@linux.ie, brajeswar.linux@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sabyasachi.linux@gmail.com List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 23, 2018 at 09:32:22AM +0530, Souptick Joarder wrote: > Replace dma_alloc_coherent + memset with dma_zalloc_coherent. > > Signed-off-by: Souptick Joarder Applied, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_pci.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c > index 896e42a..1427879 100644 > --- a/drivers/gpu/drm/drm_pci.c > +++ b/drivers/gpu/drm/drm_pci.c > @@ -61,15 +61,14 @@ drm_dma_handle_t *drm_pci_alloc(struct drm_device * dev, size_t size, size_t ali > return NULL; > > dmah->size = size; > - dmah->vaddr = dma_alloc_coherent(&dev->pdev->dev, size, &dmah->busaddr, GFP_KERNEL | __GFP_COMP); > + dmah->vaddr = dma_zalloc_coherent(&dev->pdev->dev, size, &dmah->busaddr, > + GFP_KERNEL | __GFP_COMP); > > if (dmah->vaddr == NULL) { > kfree(dmah); > return NULL; > } > > - memset(dmah->vaddr, 0, size); > - > /* XXX - Is virt_to_page() legal for consistent mem? */ > /* Reserve */ > for (addr = (unsigned long)dmah->vaddr, sz = size; > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch