Received-SPF: neutral (google.com: 2a00:1450:4864:20::543 is neither permitted nor denied by best guess record for domain of daniel@ffwll.ch) client-ip=2a00:1450:4864:20::543;
Sender: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Tue, 23 Oct 2018 15:59:56 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Sean Paul <sean@poorly.run>
Cc: Mamta Shukla <mamtashukla555@gmail.com>,
	outreachy-kernel@googlegroups.com, Dave Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH DRM] drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than
 if(IS_ERR(...)) +PTR_ERR
Message-ID: <20181023135955.GV324@phenom.ffwll.local>
References: <20181018204815.GA23390@armorer>
 <CAMavQKLZu7nKpYb0N45dNZhm2L9bC6LNf87hSHpOrzYrAPK6eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMavQKLZu7nKpYb0N45dNZhm2L9bC6LNf87hSHpOrzYrAPK6eQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Tue, Oct 23, 2018 at 08:54:36AM -0400, Sean Paul wrote:
> On Thu, Oct 18, 2018 at 7:11 PM Mamta Shukla <mamtashukla555@gmail.com> wrote:
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its
> > better to have inlined function rather than code-opened implementation.
> >
> > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> 
> Reviewed-by: Sean Paul <sean@poorly.run>

Applied to drm-misc-next so Julia can easily spot them all. Thanks for
patch&review.
-Daniel
> 
> > ---
> >  drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > index 6a68493..b751b76 100644
> > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > @@ -1222,10 +1222,7 @@ static int a5xx_crashdumper_init(struct msm_gpu *gpu,
> >                 SZ_1M, MSM_BO_UNCACHED, gpu->aspace,
> >                 &dumper->bo, &dumper->iova);
> >
> > -       if (IS_ERR(dumper->ptr))
> > -               return PTR_ERR(dumper->ptr);
> > -
> > -       return 0;
> > +       return PTR_ERR_OR_ZERO(dumper->ptr);
> >  }
> >
> >  static void a5xx_crashdumper_free(struct msm_gpu *gpu,
> > --
> > 1.9.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch