From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings Date: Thu, 25 Oct 2018 11:35:11 +0200 Message-ID: <20181025093511.GC21967@phenom.ffwll.local> References: <20181025083634.7178-1-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181025083634.7178-1-david1.zhou@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou Cc: Christian =?iso-8859-1?Q?K=F6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMDQ6MzY6MzRQTSArMDgwMCwgQ2h1bm1pbmcgWmhvdSB3 cm90ZToKPiBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYzoyMDI6NC0xNDogRVJST1I6IGZ1 bmN0aW9uIGRybV9zeW5jb2JqX2ZpbmRfc2lnbmFsX3B0X2Zvcl9wb2ludCBjYWxsZWQgb24gbGlu ZSAzOTAgaW5zaWRlIGxvY2sgb24gbGluZSAzODkgYnV0IHVzZXMgR0ZQX0tFUk5FTAo+IAo+ICAg RmluZCBmdW5jdGlvbnMgdGhhdCByZWZlciB0byBHRlBfS0VSTkVMIGJ1dCBhcmUgY2FsbGVkIHdp dGggbG9ja3MgaGVsZC4KClVoIC4uLiBpZiB5b3VyIGludGVybmFsIHZhbGlkYXRpb24gZG9lc24n dCBjYXRjaCBzdHVmZiBsaWtlIHRoaXMgKGJvaWxzCmRvd24gdG8gYSkgcnVuIGNvZGUgYikgd2l0 aCBzbGVlcCBkZWJ1Z2dpbmcgZW5hYmxlZCkgd2hhdCBleGFjdGx5IGRvIHlvdQpkbz8KCk5vdCBy ZWFsbHkgaW5zcGlyaW5nIGNvbmZpbmRlbmNlLgotRGFuaWVsCgo+IAo+IFNlbWFudGljIHBhdGNo IGluZm9ybWF0aW9uOgo+ICAgVGhlIHByb3Bvc2VkIGNoYW5nZSBvZiBjb252ZXJ0aW5nIHRoZSBH RlBfS0VSTkVMIGlzIG5vdCBuZWNlc3NhcmlseSB0aGUKPiAgIGNvcnJlY3Qgb25lLiAgSXQgbWF5 IGJlIGRlc2lyZWQgdG8gdW5sb2NrIHRoZSBsb2NrLCBvciB0byBub3QgY2FsbCB0aGUKPiAgIGZ1 bmN0aW9uIHVuZGVyIHRoZSBsb2NrIGluIHRoZSBmaXJzdCBwbGFjZS4KPiAKPiBHZW5lcmF0ZWQg Ynk6IHNjcmlwdHMvY29jY2luZWxsZS9sb2Nrcy9jYWxsX2tlcm4uY29jY2kKPiAKPiBTaWduZWQt b2ZmLWJ5OiBDaHVubWluZyBaaG91IDxkYXZpZDEuemhvdUBhbWQuY29tPgo+IENjOiBNYWFydGVu IExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBpbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IENocmlzdGlhbiBLw7ZuaWcgPGVhc3ky cmVtZW1iZXIuY2hrQGdvb2dsZW1haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJt X3N5bmNvYmouYyB8IDEyICsrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX3N5bmNvYmouYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gaW5kZXggYjdl YWE2MDNmMzY4Li5jOTA5OTU0OWRkY2IgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9zeW5jb2JqLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+IEBAIC0x MTEsNiArMTExLDcgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgCQkJCSAgICAgIHVpbnQ2 NF90IHBvaW50KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0ICpzaWduYWxf cHQ7Cj4gKwlzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSA9IE5VTEw7Cj4gIAo+ICAJaWYgKChzeW5j b2JqLT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfVElNRUxJTkUpICYmCj4gIAkgICAgKHBvaW50 IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkgewo+IEBAIC0xMzEsMTUgKzEzMiwxOCBAQCBzdGF0aWMg c3RydWN0IGRtYV9mZW5jZQo+ICAJCXJldHVybiAmZmVuY2UtPmJhc2U7Cj4gIAl9Cj4gIAo+ICsJ c3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgCWxpc3RfZm9yX2VhY2hfZW50cnkoc2ln bmFsX3B0LCAmc3luY29iai0+c2lnbmFsX3B0X2xpc3QsIGxpc3QpIHsKPiAgCQlpZiAocG9pbnQg PiBzaWduYWxfcHQtPnZhbHVlKQo+ICAJCQljb250aW51ZTsKPiAgCQlpZiAoKHN5bmNvYmotPnR5 cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9CSU5BUlkpICYmCj4gIAkJICAgIChwb2ludCAhPSBzaWdu YWxfcHQtPnZhbHVlKSkKPiAgCQkJY29udGludWU7Cj4gLQkJcmV0dXJuIGRtYV9mZW5jZV9nZXQo JnNpZ25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJCWZlbmNlID0gZG1hX2ZlbmNlX2dl dCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7Cj4gKwkJYnJlYWs7Cj4gIAl9Cj4gLQly ZXR1cm4gTlVMTDsKPiArCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiArCXJldHVy biBmZW5jZTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZHJtX3N5bmNvYmpfYWRkX2NhbGxiYWNr X2xvY2tlZChzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosCj4gQEAgLTE2Niw5ICsxNzAsNyBA QCBzdGF0aWMgdm9pZCBkcm1fc3luY29ial9mZW5jZV9nZXRfb3JfYWRkX2NhbGxiYWNrKHN0cnVj dCBkcm1fc3luY29iaiAqc3luY29iaiwKPiAgCX0KPiAgCj4gIAltdXRleF9sb2NrKCZzeW5jb2Jq LT5jYl9tdXRleCk7Cj4gLQlzcGluX2xvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+ICAJKmZlbmNl ID0gZHJtX3N5bmNvYmpfZmluZF9zaWduYWxfcHRfZm9yX3BvaW50KHN5bmNvYmosIHB0X3ZhbHVl KTsKPiAtCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgCWlmICghKmZlbmNlKQo+ ICAJCWRybV9zeW5jb2JqX2FkZF9jYWxsYmFja19sb2NrZWQoc3luY29iaiwgY2IsIGZ1bmMpOwo+ ICAJbXV0ZXhfdW5sb2NrKCZzeW5jb2JqLT5jYl9tdXRleCk7Cj4gQEAgLTM3OSwxMSArMzgxLDkg QEAgZHJtX3N5bmNvYmpfcG9pbnRfZ2V0KHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwgdTY0 IHBvaW50LCB1NjQgZmxhZ3MsCj4gIAkJaWYgKHJldCA8IDApCj4gIAkJCXJldHVybiByZXQ7Cj4g IAl9Cj4gLQlzcGluX2xvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+ICAJKmZlbmNlID0gZHJtX3N5 bmNvYmpfZmluZF9zaWduYWxfcHRfZm9yX3BvaW50KHN5bmNvYmosIHBvaW50KTsKPiAgCWlmICgh KmZlbmNlKQo+ICAJCXJldCA9IC1FSU5WQUw7Cj4gLQlzcGluX3VubG9jaygmc3luY29iai0+cHRf bG9jayk7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IC0tIAo+IDIuMTcuMQo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=