Return-Path: <SRS0=nbvZ=NF=suse.cz=dsterba@kernel.org>
Date: Thu, 25 Oct 2018 17:12:48 +0200
From: David Sterba <dsterba@suse.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Chris Mason <clm@fb.com>, Jeff Mahoney <jeffm@suse.com>
Subject: Re: [PATCH AUTOSEL 4.4 15/65] btrfs: don't create or leak aliased
 root while cleaning up orphans
Message-ID: <20181025151247.GE16290@suse.cz>
Reply-To: dsterba@suse.cz
References: <20181025141705.213937-1-sashal@kernel.org>
 <20181025141705.213937-15-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181025141705.213937-15-sashal@kernel.org>
List-ID: <stable.vger.kernel.org>

On Thu, Oct 25, 2018 at 10:16:15AM -0400, Sasha Levin wrote:
> From: Jeff Mahoney <jeffm@suse.com>
> 
> [ Upstream commit 35bbb97fc898aeb874cb7c8b746f091caa359994 ]
> 
> commit 909c3a22da3 (Btrfs: fix loading of orphan roots leading to BUG_ON)
> avoids the BUG_ON but can add an aliased root to the dead_roots list or
> leak the root.
> 
> Since we've already been loading roots into the radix tree, we should
> use it before looking the root up on disk.
> 
> Cc: <stable@vger.kernel.org> # 4.5

Ack for 4.4 stable.