Return-path: Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gGLa5-00016s-48 for kexec@lists.infradead.org; Sat, 27 Oct 2018 10:12:34 +0000 Date: Sat, 27 Oct 2018 12:12:21 +0200 From: Borislav Petkov Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo Message-ID: <20181027101221.GC1046@nazgul.tnic> References: <20181026093630.8520-1-lijiang@redhat.com> <053CC83A-9A95-4C12-9627-AABD1427DA9C@alien8.de> <1263471c-a27d-a698-15f0-b5947f13ea93@redhat.com> <20181026182440.20a4b107@ezekiel.suse.cz> <20181026222517.GB26927@nazgul.tnic> <20181027081343.GA1884@MiWiFi-R3L-srv> <20181027091007.GB1046@nazgul.tnic> <20181027093917.GA14493@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181027093917.GA14493@MiWiFi-R3L-srv> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Baoquan He Cc: lijiang , Petr Tesarik , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, dyoung@redhat.com On Sat, Oct 27, 2018 at 05:39:17PM +0800, Baoquan He wrote: > Not very sure about this, we have arch_crash_save_vmcoreinfo() in > arch/x86/kernel/machine_kexec_64.c to export arch-specific stuffs > outside. Is there any special reason about a mask in one architecture > when expose it out? Yes, we don't export random arch-specific details to the outside which we then cannot change later. So vmcoreinfo needs to define its own. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec