From: Ville Syrjala Subject: [PATCH v4 2/2] drm/i915: Eliminate the horrendous format check code Date: Mon, 29 Oct 2018 20:34:53 +0200 Message-ID: <20181029183453.28541-2-ville.syrjala@linux.intel.com> References: <20181029183453.28541-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181029183453.28541-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: dri-devel@lists.freedesktop.org RnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJl cGxhY2UgdGhlIG1lc3N5IGZyYW1lYnVmZmVyIGZvcm1hdC9tb2RpZmllciB2YWxpZGF0aW9uIGNv ZGUKd2l0aCBhIHNpbmdsZSBjYWxsIHRvIGRybV9hbnlfcGxhbmVfaGFzX2Zvcm1hdCgpLiBUaGUg Y29kZSB3YXMKZXh0cmVtZWx5IGFubm95aW5nIHRvIG1haW50YWluIGFzIHlvdSBoYWQgdG8gaGF2 ZSBhIGxvdCBvZiBwbGF0Zm9ybQpjaGVja3MgZm9yIGRpZmZlcmVudCBmb3JtYXRzLiBUaGUgbmV3 IGNvZGUgcmVxdWlyZXMgemVybyBtYWludGVuYW5jZS4KCnYyOiBOdWtlIHRoZSBtb2RpZmllciBj aGVja3MgYXMgd2VsbCBzaW5jZSB0aGUgY29yZSBkb2VzIHRoYXQgdG9vIG5vdwp2MzogQ2FsbCBk cm1fYW55X3BsYW5lX2hhc19mb3JtYXQoKSBmcm9tIHRoZSBkcml2ZXIgY29kZQp2NDogUmViYXNl CgpDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+ ClNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTA1ICsr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygr KSwgOTcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCmluZGV4 IDliNTQ5ZDNkZDA1NS4uZGUzOGQ1NTQ1ZjNiIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCkBAIC0xNDM2OCw3ICsxNDM2OCw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZm ZXJfaW5pdChzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAogewogCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUob2JqLT5iYXNlLmRldik7CiAJc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSAmaW50ZWxfZmItPmJhc2U7Ci0Jc3RydWN0IGRybV9m b3JtYXRfbmFtZV9idWYgZm9ybWF0X25hbWU7CiAJdTMyIHBpdGNoX2xpbWl0OwogCXVuc2lnbmVk IGludCB0aWxpbmcsIHN0cmlkZTsKIAlpbnQgcmV0ID0gLUVJTlZBTDsKQEAgLTE0Mzk5LDM5ICsx NDM5OCwxNCBAQCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVs X2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKIAkJfQogCX0KIAotCS8qIFBhc3NlZCBpbiBtb2RpZmll ciBzYW5pdHkgY2hlY2tpbmcuICovCi0Jc3dpdGNoIChtb2RlX2NtZC0+bW9kaWZpZXJbMF0pIHsK LQljYXNlIEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUzoKLQljYXNlIEk5MTVfRk9STUFUX01P RF9ZZl9USUxFRF9DQ1M6Ci0JCXN3aXRjaCAobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCkgewotCQlj YXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Ci0JCWNhc2UgRFJNX0ZPUk1BVF9BQkdSODg4ODoKLQkJ Y2FzZSBEUk1fRk9STUFUX1hSR0I4ODg4OgotCQljYXNlIERSTV9GT1JNQVRfQVJHQjg4ODg6Ci0J CQlicmVhazsKLQkJZGVmYXVsdDoKLQkJCURSTV9ERUJVR19LTVMoIlJDIHN1cHBvcnRlZCBvbmx5 IHdpdGggUkdCODg4OCBmb3JtYXRzXG4iKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCS8qIGZhbGwg dGhyb3VnaCAqLwotCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEOgotCQlpZiAobW9kZV9j bWQtPnBpeGVsX2Zvcm1hdCA9PSBEUk1fRk9STUFUX0M4KSB7Ci0JCQlEUk1fREVCVUdfS01TKCJJ bmRleGVkIGZvcm1hdCBkb2VzIG5vdCBzdXBwb3J0IFlmIHRpbGluZ1xuIik7Ci0JCQlnb3RvIGVy cjsKLQkJfQotCQkvKiBmYWxsIHRocm91Z2ggKi8KLQljYXNlIEk5MTVfRk9STUFUX01PRF9ZX1RJ TEVEOgotCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDkpIHsKLQkJCURSTV9ERUJVR19LTVMo IlVuc3VwcG9ydGVkIHRpbGluZyAweCVsbHghXG4iLAotCQkJCSAgICAgIG1vZGVfY21kLT5tb2Rp ZmllclswXSk7Ci0JCQlnb3RvIGVycjsKLQkJfQotCQlicmVhazsKLQljYXNlIERSTV9GT1JNQVRf TU9EX0xJTkVBUjoKLQljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgotCQlicmVhazsKLQlk ZWZhdWx0OgotCQlEUk1fREVCVUdfS01TKCJVbnN1cHBvcnRlZCBmYiBtb2RpZmllciAweCVsbHgh XG4iLAorCWlmICghZHJtX2FueV9wbGFuZV9oYXNfZm9ybWF0KCZkZXZfcHJpdi0+ZHJtLAorCQkJ CSAgICAgIG1vZGVfY21kLT5waXhlbF9mb3JtYXQsCisJCQkJICAgICAgbW9kZV9jbWQtPm1vZGlm aWVyWzBdKSkgeworCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1lX2J1ZiBmb3JtYXRfbmFtZTsKKwor CQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQgJXMgLyBtb2RpZmllciAw eCVsbHhcbiIsCisJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9m b3JtYXQsCisJCQkJCQkgICZmb3JtYXRfbmFtZSksCiAJCQkgICAgICBtb2RlX2NtZC0+bW9kaWZp ZXJbMF0pOwogCQlnb3RvIGVycjsKIAl9CkBAIC0xNDQ2Niw2OSArMTQ0NDAsNiBAQCBzdGF0aWMg aW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRl bF9mYiwKIAkJZ290byBlcnI7CiAJfQogCi0JLyogUmVqZWN0IGZvcm1hdHMgbm90IHN1cHBvcnRl ZCBieSBhbnkgcGxhbmUgZWFybHkuICovCi0Jc3dpdGNoIChtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0 KSB7Ci0JY2FzZSBEUk1fRk9STUFUX0M4OgotCWNhc2UgRFJNX0ZPUk1BVF9SR0I1NjU6Ci0JY2Fz ZSBEUk1fRk9STUFUX1hSR0I4ODg4OgotCWNhc2UgRFJNX0ZPUk1BVF9BUkdCODg4ODoKLQkJYnJl YWs7Ci0JY2FzZSBEUk1fRk9STUFUX1hSR0IxNTU1OgotCQlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+IDMpIHsKLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNc biIsCi0JCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0 LCAmZm9ybWF0X25hbWUpKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCWJyZWFrOwotCWNhc2UgRFJN X0ZPUk1BVF9BQkdSODg4ODoKLQkJaWYgKCFJU19WQUxMRVlWSUVXKGRldl9wcml2KSAmJiAhSVNf Q0hFUlJZVklFVyhkZXZfcHJpdikgJiYKLQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPCA5KSB7 Ci0JCQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAotCQkJ CSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1h dF9uYW1lKSk7Ci0JCQlnb3RvIGVycjsKLQkJfQotCQlicmVhazsKLQljYXNlIERSTV9GT1JNQVRf WEJHUjg4ODg6Ci0JY2FzZSBEUk1fRk9STUFUX1hSR0IyMTAxMDEwOgotCWNhc2UgRFJNX0ZPUk1B VF9YQkdSMjEwMTAxMDoKLQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA0KSB7Ci0JCQlEUk1f REVCVUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAotCQkJCSAgICAgIGRy bV9nZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7 Ci0JCQlnb3RvIGVycjsKLQkJfQotCQlicmVhazsKLQljYXNlIERSTV9GT1JNQVRfQUJHUjIxMDEw MTA6Ci0JCWlmICghSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgJiYgIUlTX0NIRVJSWVZJRVcoZGV2 X3ByaXYpKSB7Ci0JCQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVz XG4iLAotCQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1h dCwgJmZvcm1hdF9uYW1lKSk7Ci0JCQlnb3RvIGVycjsKLQkJfQotCQlicmVhazsKLQljYXNlIERS TV9GT1JNQVRfWVVZVjoKLQljYXNlIERSTV9GT1JNQVRfVVlWWToKLQljYXNlIERSTV9GT1JNQVRf WVZZVToKLQljYXNlIERSTV9GT1JNQVRfVllVWToKLQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg PCA1ICYmICFJU19HNFgoZGV2X3ByaXYpKSB7Ci0JCQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRl ZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAotCQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUobW9k ZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Ci0JCQlnb3RvIGVycjsKLQkJfQot CQlicmVhazsKLQljYXNlIERSTV9GT1JNQVRfTlYxMjoKLQkJaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPCA5IHx8IElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8Ci0JCSAgICBJU19CUk9YVE9OKGRldl9w cml2KSkgewotCQkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xu IiwKLQkJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQs Ci0JCQkJCQkJICAmZm9ybWF0X25hbWUpKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCWJyZWFrOwot CWRlZmF1bHQ6Ci0JCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNc biIsCi0JCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQs ICZmb3JtYXRfbmFtZSkpOwotCQlnb3RvIGVycjsKLQl9Ci0KIAkvKiBGSVhNRSBuZWVkIHRvIGFk anVzdCBMSU5PRkYvVElMRU9GRiBhY2NvcmRpbmdseS4gKi8KIAlpZiAobW9kZV9jbWQtPm9mZnNl dHNbMF0gIT0gMCkKIAkJZ290byBlcnI7Ci0tIAoyLjE4LjEKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=