From: Zhenyu Wang Subject: Re: [PATCH] drm/i915/gtt: Revert "Disable read-only support under GVT" Date: Wed, 31 Oct 2018 13:17:48 +0800 Message-ID: <20181031051748.GI31661@zhen-hp.sh.intel.com> References: <1540883281-11359-1-git-send-email-hang.yuan@linux.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2078406191==" Return-path: In-Reply-To: <1540883281-11359-1-git-send-email-hang.yuan@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Yuan, Hang" Cc: Hang Yuan , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2078406191== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q6STzHxy03qt/hK9" Content-Disposition: inline --Q6STzHxy03qt/hK9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2018.10.30 15:08:01 +0800, intel-gfx-bounces@lists.freedesktop.org wrote: > From: Hang Yuan >=20 > This reverts commit c9e666880de5a1fed04dc412b046916d542b72dd. >=20 > Checked GVT codes that guest PPGTT PTE flag bits are propagated > to shadow PTE. Read/write bit is not changed. Further tested by > i915 self-test case "igt_ctx_readonly". No error or GPU hang was > detected. So enable read-only support under GVT. >=20 > Signed-off-by: Hang Yuan > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i= 915_gem_gtt.c > index 19b2d99..bdf9f9f 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -1602,12 +1602,8 @@ static struct i915_hw_ppgtt *gen8_ppgtt_create(str= uct drm_i915_private *i915) > 1ULL << 48 : > 1ULL << 32; > =20 > - /* > - * From bdw, there is support for read-only pages in the PPGTT. > - * > - * XXX GVT is not honouring the lack of RW in the PTE bits. > - */ > - ppgtt->vm.has_read_only =3D !intel_vgpu_active(i915); > + /* From bdw, there is support for read-only pages in the PPGTT. */ > + ppgtt->vm.has_read_only =3D true; > =20 > i915_address_space_init(&ppgtt->vm, i915); > =20 In consider we have that shadow logic from initial of gvt support, this is ok. Acked-by: Zhenyu Wang thanks --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --Q6STzHxy03qt/hK9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCW9k6/AAKCRCxBBozTXgY J3vxAJ0QxyA+VtJjbj0KXdWas3lvbBcSZACglbyeFOGRjxEz5C5Hz185m/lR8m8= =FsMZ -----END PGP SIGNATURE----- --Q6STzHxy03qt/hK9-- --===============2078406191== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============2078406191==--